New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769809 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

memory_desktop.browse_accessibility:tools:gmail_compose flaky

Project Member Reported by xidac...@chromium.org, Sep 28 2017

Issue description

Cc: nedngu...@google.com perezju@chromium.org
Components: Speed>Benchmarks
Labels: -Pri-3 Pri-1
Owner: dominicc@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3d01ad2e2cbe7c35801ba4f75bb301307a4679e

commit a3d01ad2e2cbe7c35801ba4f75bb301307a4679e
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Sep 28 17:17:46 2017

Disable browse_accessibility:tools:gmail_compose

It has been very flaky. Please re-enable it with fix

TBR=nednguyen@chromium.org
NOTRY=true

Bug:  769809 
Change-Id: I7077fbfa752ca5c046ae63475d974896f42e1225
Reviewed-on: https://chromium-review.googlesource.com/690515
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505071}
[modify] https://crrev.com/a3d01ad2e2cbe7c35801ba4f75bb301307a4679e/tools/perf/benchmarks/system_health_smoke_test.py

Labels: -Pri-1 Pri-2
Test is disabled, lowering Pri.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b8c25431f2bfca4a022d4b2db25626f0292204e

commit 1b8c25431f2bfca4a022d4b2db25626f0292204e
Author: Sami Kyostila <skyostil@chromium.org>
Date: Fri Sep 29 16:52:54 2017

perf: Disable browse_accessibility:tools:gmail_compose due to flake

BUG= 769809 

Change-Id: Ie4f3f0a26c911948b7b8cda1fbe8e8fde2e3d8b0
Reviewed-on: https://chromium-review.googlesource.com/692774
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505394}
[modify] https://crrev.com/1b8c25431f2bfca4a022d4b2db25626f0292204e/tools/perf/page_sets/system_health/expectations.py

Just because its not stated anywhere in the bug and I had to do some digging to figure it out:

That story was recently added, so its never been stable on the waterfall.
https://chromium-review.googlesource.com/c/chromium/src/+/663208


Owner: dmazz...@chromium.org
Cc: dmazz...@chromium.org
 Issue 771332  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9bdfa9fc9834032a8ec11794f84ca07a0c12fa6

commit a9bdfa9fc9834032a8ec11794f84ca07a0c12fa6
Author: rnephew <rnephew@chromium.org>
Date: Wed Oct 04 16:13:38 2017

[Telemetry] Disable gmail compose story on system_health.memory_desktop.

Previously it was only disable on system_health.common_desktop

TBR=nednguyen@google.com

Bug:  769809 
Change-Id: I02143441e0cee13faab7cf33ba570218a59c480c
Reviewed-on: https://chromium-review.googlesource.com/699053
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506404}
[modify] https://crrev.com/a9bdfa9fc9834032a8ec11794f84ca07a0c12fa6/tools/perf/page_sets/system_health/expectations.py

Cc: achuith@chromium.org erosky@chromium.org michae...@chromium.org jonr...@chromium.org
 Issue 769128  has been merged into this issue.
This fails locally for me. It doesn't look like dmazzoni@ has cycles to fix, so I'm going to remove the story from the code for now, but feel free to revert my removal if anyone wants to fix this in the future.
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4023189272a6fc29b336d15d70fe9049f6bcd1e

commit e4023189272a6fc29b336d15d70fe9049f6bcd1e
Author: Annie Sullivan <sullivan@chromium.org>
Date: Thu Jul 19 17:25:39 2018

Remove browse_accessibility:tools:gmail_compose from system_health benchmark as it has never passed consistently.

Bug:  769809 
Change-Id: Ib5015379a59ea2a1d16618e94e2ff125a8341780
Reviewed-on: https://chromium-review.googlesource.com/1143595
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576539}
[modify] https://crrev.com/e4023189272a6fc29b336d15d70fe9049f6bcd1e/tools/perf/benchmarks/system_health_smoke_test.py
[modify] https://crrev.com/e4023189272a6fc29b336d15d70fe9049f6bcd1e/tools/perf/expectations.config
[modify] https://crrev.com/e4023189272a6fc29b336d15d70fe9049f6bcd1e/tools/perf/page_sets/system_health/accessibility_stories.py
[modify] https://crrev.com/e4023189272a6fc29b336d15d70fe9049f6bcd1e/tools/perf/system_health_stories.csv

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc81511e95ae3122ce010ad52a92959211d4af94

commit cc81511e95ae3122ce010ad52a92959211d4af94
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Fri Oct 05 17:39:33 2018

Remove system health story browse_accessibility:tools:gmail_compose

The benchmark was not completely removed in crrev/c/1143595.

Bug:  769809 
Change-Id: I131b226b7388d97eb380943275b6b16c222d2260
Reviewed-on: https://chromium-review.googlesource.com/c/1257669
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597187}
[modify] https://crrev.com/cc81511e95ae3122ce010ad52a92959211d4af94/tools/perf/page_sets/data/system_health_desktop.json

Status: Fixed (was: Assigned)
Closing since this has been deleted and we have several other good accessibility benchmarks.

Sign in to add a comment