New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769804 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Add endpoint to sheriff-o-matic for retrieving the current sheriff(s)

Project Member Reported by bore...@google.com, Sep 28 2017

Issue description

Add endpoint to sheriff-o-matic for retrieving the current sheriff(s)

I am working on bringing up a couple of instances of Skia's autoroller which will roll repos into chromium/src, eg. depot_tools.  The roller adds the current sheriff as a reviewer to all rolls.  Skia has https://skia-tree-status.appspot.com/current-sheriff which the roller can query for the current sheriff, and other rollers just use a specific person or mailing list as the trooper.  agable@ suggested adding an endpoint to sheriff-o-matic which could return similar information for the roller to use.
 
Labels: Milestone-Skia
Cool! Sheriff-o-Matic sounds like a good place for this to live. At the moment, it's a bit confusing to get started on working on Sheriff-o-Matic, which we want to improve, but I believe the README should have enough information. 

The list of routes in Sheriff-o-Matic is at frontend/main.go. Then, we usually add the handlers for routes to som/handler. If you need any help while working on Sheriff-o-Matic, feel free to ask me or Sean. 

(Also, does this mean Skia might have some interest in usin Sheriff-o-Matic? If so, that's something we could follow up on separately. We're always open to supporting new clients.)

Comment 2 by bore...@google.com, Oct 5 2017

Cc: phajdan.jr@chromium.org
So this was a request from Paweł so that he doesn't have to be all-time sheriff for these rollers.  I was hoping it'd be something you folks could knock out easily, but I can take a look after clearing my stack a bit.

As for Skia on Sheriff-o-Matic, I think it's something which could be useful for us, but I assume there are fundamental differences in the way we run tests (eg. we don't use gtest) which would make it difficult to get useful data into SoM.  Most of our sheriffing is done on perf.skia.org and gold.skia.org for performance and correctness, respectively.  Pass/fail test failures are comparatively rare.
Status: WontFix (was: Untriaged)
Consult the rotations for current sheriffs, SoM isn't the source of truth for this data.

Sign in to add a comment