New issue
Advanced search Search tips

Issue 769770 link

Starred by 2 users
Status: Fixed
Owner:
zhuoyu.q...@samsung.com
Closed: Jan 2018
Cc:
jakearchibald@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Deprecate old Background Fetch getters from the API

Project Member Reported by peter@chromium.org, Sep 28 2017 
A number of changes have been made to the Background Fetch API that remove certain properties from BackgroundFetchRegistration:

  BackgroundFetchRegistration.icons
  BackgroundFetchRegistration.title

They have been removed because the registration is now a live object, so the synchronisation in case of changes may be tough to achieve correctly. Our implementation should follow, but only once we know it's safe.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/509db87d9fae9bf58c69aa56fb43db1d00526224

commit 509db87d9fae9bf58c69aa56fb43db1d00526224
Author: zhuoyu.qian <zhuoyu.qian@samsung.com>
Date: Thu Nov 23 12:28:02 2017

Delete icons of BackgroundFetchRegistration

The BackgroundFetchRegistration.icons is deprecated, remove it.

BUG= 769770 
R=peter@chromium.org

Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Change-Id: Iab41ba0d4593af5006f2b0fb4476653e715220b5
Reviewed-on: https://chromium-review.googlesource.com/778622
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518903}
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/content/browser/background_fetch/background_fetch_data_manager.cc
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/content/browser/background_fetch/storage/create_registration_task.cc
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/content/common/background_fetch/background_fetch_struct_traits.cc
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/content/common/background_fetch/background_fetch_struct_traits.h
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/content/common/background_fetch/background_fetch_struct_traits_unittest.cc
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/content/common/background_fetch/background_fetch_types.h
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-fetch.https.html
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-get.https.html
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.cpp
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.h
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.idl
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchTypeConverters.cpp
[modify] https://crrev.com/509db87d9fae9bf58c69aa56fb43db1d00526224/third_party/WebKit/public/platform/modules/background_fetch/background_fetch.mojom
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32d039c92b61ceea12d36e6b69906af52b3989f1

commit 32d039c92b61ceea12d36e6b69906af52b3989f1
Author: zhuoyu.qian <zhuoyu.qian@samsung.com>
Date: Wed Nov 29 06:46:58 2017

Delete title of BackgroundFetchRegistration

The BackgroundFetchRegistration.title is deprecated, remove it.

BUG= 769770 
R=peter@chromium.org

Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Change-Id: I8f9da3138ffddffd06d611dd52b3379f5f72289b
Reviewed-on: https://chromium-review.googlesource.com/792770
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520032}
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/content/browser/background_fetch/background_fetch_data_manager.cc
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/content/browser/background_fetch/storage/create_registration_task.cc
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/content/common/background_fetch/background_fetch_struct_traits.cc
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/content/common/background_fetch/background_fetch_struct_traits.h
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/content/common/background_fetch/background_fetch_struct_traits_unittest.cc
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/content/common/background_fetch/background_fetch_types.h
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-fetch.https.html
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-get.https.html
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.cpp
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.h
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.idl
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchTypeConverters.cpp
[modify] https://crrev.com/32d039c92b61ceea12d36e6b69906af52b3989f1/third_party/WebKit/public/platform/modules/background_fetch/background_fetch.mojom
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efa4364b705cb4f504b61064e9c675a79249685f

commit efa4364b705cb4f504b61064e9c675a79249685f
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Tue Jan 09 01:20:54 2018

Delete totalDownloadSize of BackgroundFetchRegistration

The BackgroundFetchRegistration.totalDownloadSize is deprecated,
remove it.

BUG= 769770 

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Ica6d93ee49ccd6aa28f3785f79bdfcecfa7039ce
Reviewed-on: https://chromium-review.googlesource.com/853815
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527848}
[modify] https://crrev.com/efa4364b705cb4f504b61064e9c675a79249685f/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-fetch.https.html
[modify] https://crrev.com/efa4364b705cb4f504b61064e9c675a79249685f/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-get.https.html
[modify] https://crrev.com/efa4364b705cb4f504b61064e9c675a79249685f/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/efa4364b705cb4f504b61064e9c675a79249685f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/efa4364b705cb4f504b61064e9c675a79249685f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/efa4364b705cb4f504b61064e9c675a79249685f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/efa4364b705cb4f504b61064e9c675a79249685f/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.idl

Comment 4 by peter@chromium.org, Jan 9 2018

Owner: zhuoyu.q...@samsung.com
Status: Fixed (was: Assigned)
This is done, thank you! :)
►

Sign in to add a comment