Issue metadata
Sign in to add a comment
|
FindPropertiesNeedingUpdate.h DCHCK on ChromeOS login screen. |
||||||||||||||||||||||
Issue descriptionHit this on ToT chrome (r504782). Running chromeos chrome with --login-manager. Renderer for gaia <webview> crashed because of the DCHECK. [1:1:0927/161544.466158:FATAL:FindPropertiesNeedingUpdate.h(170)] Check failed: *original_properties_->Effect() == *object_properties->Effect(). Property was updated without the l ayout object ("LayoutSVGContainer g id='YGlOvc' class='yhFy6d sOEOU'") needing a paint property update. Original: {"parent":"0x241fa20dbf30","localTransformSpace":"0x241fa20b2790","outputClip":"(nil)","opacity":0,"compositorElementId":"(528)"} Updated: {"parent":"0x241fa20dbf30","localTransformSpace":"0x241fa20b2790","outputClip":"(nil)","opacity":0,"directCompositingReasons":"activeAnimation","compositorElementId":"(528)"} #0 0x7ff6ae2d7bad base::debug::StackTrace::StackTrace() #1 0x7ff6ae2d612c base::debug::StackTrace::StackTrace() #2 0x7ff6ae35fe1d logging::LogMessage::~LogMessage() #3 0x7ff699e4c46f blink::FindObjectPropertiesNeedingUpdateScope::~FindObjectPropertiesNeedingUpdateScope() #4 0x7ff699e48cdd blink::PaintPropertyTreeBuilder::UpdateFragmentPropertiesForSelf() #5 0x7ff699e44c4c blink::PaintPropertyTreeBuilder::UpdatePropertiesForSelf() #6 0x7ff699e744d8 blink::PrePaintTreeWalk::Walk() ... #19 0x7ff699e741c2 blink::PrePaintTreeWalk::Walk() #20 0x7ff69943256d blink::LocalFrameView::PrePaint() #21 0x7ff699430d0f blink::LocalFrameView::UpdateLifecyclePhasesInternal() #22 0x7ff6994304c2 blink::LocalFrameView::UpdateAllLifecyclePhases() #23 0x7ff699d67e07 blink::PageAnimator::UpdateAllLifecyclePhases() #24 0x7ff699d6d3a5 blink::PageWidgetDelegate::UpdateAllLifecyclePhases() #25 0x7ff6993a3010 blink::WebViewImpl::UpdateAllLifecyclePhases() #26 0x7ff6994cff61 blink::WebViewFrameWidget::UpdateAllLifecyclePhases() #27 0x7ff6a9466cfb content::RenderWidget::UpdateVisualState() #28 0x7ff6a92a2a5a content::RenderWidgetCompositor::UpdateLayerTreeHost() #29 0x7ff6a6313b5a cc::LayerTreeHost::RequestMainFrameUpdate() #30 0x7ff6a6406207 cc::ProxyMain::BeginMainFrame() #31 0x7ff6a6402dbe _ZN4base8internal13FunctorTraitsIMN2cc9ProxyMainEFvNSt3__110unique_ptrINS2_28BeginMainFrameAndCommitStateENS4_14default_deleteIS6_EEEEEvE6InvokeINS_7WeakPtrIS3_ EEJS9_EEEvSB_OT_DpOT0_ #32 0x7ff6a6402bb5 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIMN2cc9ProxyMainEFvNSt3__110unique_ptrINS4_28BeginMainFrameAndCommitStateENS6_14default_deleteIS8_EEEEENS_7WeakPt rIS5_EEJSB_EEEvOT_OT0_DpOT1_ #33 0x7ff6a6402a66 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9ProxyMainEFvNSt3__110unique_ptrINS3_28BeginMainFrameAndCommitStateENS5_14default_deleteIS7_EEEEEJNS_7WeakPtrIS4_E ENS0_13PassedWrapperISA_EEEEEFvvEE7RunImplISC_NS5_5tupleIJSE_SG_EEEJLm0ELm1EEEEvOT_OT0_NS5_16integer_sequenceImJXspT1_EEEE #34 0x7ff6a6402959 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9ProxyMainEFvNSt3__110unique_ptrINS3_28BeginMainFrameAndCommitStateENS5_14default_deleteIS7_EEEEEJNS_7WeakPtrIS4_E ENS0_13PassedWrapperISA_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #35 0x7ff6ae285f21 _ZNO4base12OnceCallbackIFvvEE3RunEv #36 0x7ff6ae2dc4f0 base::debug::TaskAnnotator::RunTask()
,
Sep 28 2017
,
Sep 28 2017
Probably not related, but I'm also seeing a wallpaper issue after clicking "Back" in the add user dialog, see issue 769492
,
Sep 28 2017
I think this is because https://chromium-review.googlesource.com/c/chromium/src/+/667756 enabled effect paint property nodes for SPv1. Will disable general effect paint property nodes (while keeping filter nodes) for SPv1.
,
Sep 28 2017
Can you try https://chromium-review.googlesource.com/c/chromium/src/+/690616 to see if it can fix the DCHECK failure? Thanks.
,
Sep 28 2017
Issue 769853 has been merged into this issue.
,
Sep 28 2017
I can confirm that the CL from comment #5 fixes the problem.
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4ea774e15887bec1533db047a739004f6817305 commit a4ea774e15887bec1533db047a739004f6817305 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Sep 29 03:17:55 2017 Disable generic effect paint property nodes for SPv1 We seem to have some under-invalidation of effect paint properties. This CL avoids the bug for SPv1. We will fix the bug in SPv175/SPv2. Bug: 769769 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iade52f8b1748318edacf959c872552278a116321 Reviewed-on: https://chromium-review.googlesource.com/690616 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505274} [modify] https://crrev.com/a4ea774e15887bec1533db047a739004f6817305/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
,
Sep 29 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by xiy...@chromium.org
, Sep 28 201716.8 KB
16.8 KB View Download