New issue
Advanced search Search tips

Issue 769756 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

BrandcodeConfigFetcher shouldn't hardcode Chrome's appguid

Project Member Reported by grt@chromium.org, Sep 28 2017

Issue description

kPostXml has {8A69D345-D564-463C-AFF1-A69D9E530F96} baked into it. This should instead use install_static::GetAppGuid() to get the appguid for the current install mode (canary and side-by-side dev/beta all use distinct guids).
 
It seems that install_static::GetAppGuid() is Windows-only util. BUILD.gn file in which it is listed starts with "assert(is_win)": https://cs.chromium.org/chromium/src/chrome/install_static/BUILD.gn
So adding install_static_util as dependency throws an error.

File with implementation of this util also looks Windows-specific: https://cs.chromium.org/chromium/src/chrome/install_static/install_util.h


Is BrandcodeConfigFetcher used only on Windows? If not, is there a way of obtaining app GUID on Mac and Android builds too?
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 13 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Available)
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 3

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c5aa07be11cd63d953fbe66370c5869a52170bf

commit 7c5aa07be11cd63d953fbe66370c5869a52170bf
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Sep 11 12:32:57 2018

Use install_static::GetAppGuid instead of the hardcoded string in BrandcodeConfigFetcher.

Bug:  769756 
Change-Id: Ifdcb0a5145ffad1d563562e2b2ea2390ff074cdc
Reviewed-on: https://chromium-review.googlesource.com/1213178
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590275}
[modify] https://crrev.com/7c5aa07be11cd63d953fbe66370c5869a52170bf/chrome/browser/profile_resetter/brandcode_config_fetcher.cc

Status: Fixed (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5de631d1998856afca9459f9d43f92750d13fe12

commit 5de631d1998856afca9459f9d43f92750d13fe12
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Sep 11 17:11:46 2018

Revert "Use install_static::GetAppGuid instead of the hardcoded string in BrandcodeConfigFetcher."

This reverts commit 7c5aa07be11cd63d953fbe66370c5869a52170bf.

Reason for revert: we don't need it. The hardcoded string works probaly better for Canary/Beta channels.

Original change's description:
> Use install_static::GetAppGuid instead of the hardcoded string in BrandcodeConfigFetcher.
> 
> Bug:  769756 
> Change-Id: Ifdcb0a5145ffad1d563562e2b2ea2390ff074cdc
> Reviewed-on: https://chromium-review.googlesource.com/1213178
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590275}

TBR=battre@chromium.org,vasilii@chromium.org,engedy@chromium.org

Change-Id: I3819f79aa36e61bfe61a825618496751b11a03ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  769756 
Reviewed-on: https://chromium-review.googlesource.com/1219616
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590364}
[modify] https://crrev.com/5de631d1998856afca9459f9d43f92750d13fe12/chrome/browser/profile_resetter/brandcode_config_fetcher.cc

Sign in to add a comment