New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 769744 link

Starred by 1 user
Status: Fixed
Owner:
xidac...@chromium.org
Closed: Oct 2017
Cc:
█ jmatth...@mozilla.com
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move CSS paint tests using non-standardized browser zoom CSS property out of WPT.

Project Member Reported by flackr@chromium.org, Sep 28 2017 
In https://chromium-review.googlesource.com/c/chromium/src/+/678019/8/third_party/WebKit/LayoutTests/external/wpt/css-paint-api/hidpi/geometry-with-hidip-zoom.html#33 it was pointed out that body.style.zoom is not standardized: https://developer.mozilla.org/en-US/docs/Web/CSS/zoom

I see three other paint tests using this which should be moved out as well:
https://cs.chromium.org/search/?q=file:third_party%5C/WebKit%5C/LayoutTests%5C/external%5C/wpt+style%5C.zoom&sq=package:chromium&type=cs

Make sure that the only purpose of the tests is to test browser zoom, if there's anything else they test that we could still be testing we want to keep that testing coverage.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bccdefb463ca6986c796a06af48382090ce4f0b7

commit bccdefb463ca6986c796a06af48382090ce4f0b7
Author: Xida Chen <xidachen@chromium.org>
Date: Wed Oct 11 02:37:17 2017

Move 3 tests out of wpt/css-paint-api/

Currently there are 3 tests under wpt/css-paint-api/ that uses
document.body.style.zoom which is not standardized. This CL moves the
3 tests to http/tests/csspaint

Doing this won't lose coverage on wpt/ because we have equivalent tests
without zoom. Here are the corresponding ones:
            zoom                     the same test without zoom
       paint2d-zoom.html           -- paint2d-transform.html
geometry-border-image-005.html     -- geometry-border-image-004.html
geometry-background-image-003.html -- geometry-background-image-002.html

Bug:  769744 
Change-Id: I325efec51a0747ad2adc7c463c20e44d2c1ef566
Reviewed-on: https://chromium-review.googlesource.com/706585
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507867}
[rename] https://crrev.com/bccdefb463ca6986c796a06af48382090ce4f0b7/third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-background-image-zoom-expected.html
[rename] https://crrev.com/bccdefb463ca6986c796a06af48382090ce4f0b7/third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-background-image-zoom.html
[rename] https://crrev.com/bccdefb463ca6986c796a06af48382090ce4f0b7/third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-border-image-zoom-expected.html
[rename] https://crrev.com/bccdefb463ca6986c796a06af48382090ce4f0b7/third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-border-image-zoom.html
[rename] https://crrev.com/bccdefb463ca6986c796a06af48382090ce4f0b7/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-zoom-expected.html
[rename] https://crrev.com/bccdefb463ca6986c796a06af48382090ce4f0b7/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-zoom.html

Comment 2 by xidac...@chromium.org, Oct 11 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment