New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769738 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Not on Chrome anymore
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

TileGridLayoutTest#testModernTileGridAppearance_Two flaky

Project Member Reported by xidac...@chromium.org, Sep 28 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6a0794d6b7915ba17fc627e9ba0c2f5aaad002c

commit b6a0794d6b7915ba17fc627e9ba0c2f5aaad002c
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Sep 28 14:33:56 2017

Disable TileGridLayoutTest#testModernTileGridAppearance_Two

TBR=dgn@chromium.org
NOTRY=true

Bug:  769738 
Change-Id: Ied6cdecac72229353f3c41ca769b6d872ea7a2ea
Reviewed-on: https://chromium-review.googlesource.com/690238
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505016}
[modify] https://crrev.com/b6a0794d6b7915ba17fc627e9ba0c2f5aaad002c/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGridLayoutTest.java

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df10c3999313f67ebecda53eafe39635ba18ac12

commit df10c3999313f67ebecda53eafe39635ba18ac12
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Sep 28 14:48:00 2017

Revert "Disable TileGridLayoutTest#testModernTileGridAppearance_Two"

This reverts commit b6a0794d6b7915ba17fc627e9ba0c2f5aaad002c.

Reason for revert: <INSERT REASONING HERE>
Causing build error:
https://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/103347

Original change's description:
> Disable TileGridLayoutTest#testModernTileGridAppearance_Two
> 
> TBR=dgn@chromium.org
> NOTRY=true
> 
> Bug:  769738 
> Change-Id: Ied6cdecac72229353f3c41ca769b6d872ea7a2ea
> Reviewed-on: https://chromium-review.googlesource.com/690238
> Reviewed-by: Xida Chen <xidachen@chromium.org>
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505016}

TBR=dgn@chromium.org,xidachen@chromium.org

Change-Id: I546039abb34116b5897a9ffaf1f9134229d5659b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  769738 
Reviewed-on: https://chromium-review.googlesource.com/690674
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505020}
[modify] https://crrev.com/df10c3999313f67ebecda53eafe39635ba18ac12/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGridLayoutTest.java

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29a51ce74d34b116ee1a069af2f34b84c52388c9

commit 29a51ce74d34b116ee1a069af2f34b84c52388c9
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Sep 28 16:09:37 2017

Disable TileGridLayoutTest#testModernTileGridAppearance_Two

It has been flaky. I will let this CL go through CQ to make sure there is
no build failure

TBR=dgn@chromium.org

Bug:  769738 
Change-Id: I495c98457d6139d6c46577d30d101b1ca4c4aa29
Reviewed-on: https://chromium-review.googlesource.com/690320
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505042}
[modify] https://crrev.com/29a51ce74d34b116ee1a069af2f34b84c52388c9/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGridLayoutTest.java

Comment 4 by dgn@chromium.org, Sep 28 2017

Mergedinto: 768779
Status: Duplicate (was: Available)

Sign in to add a comment