New issue
Advanced search Search tips

Issue 769729 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug



Sign in to add a comment

video-paint-invalidation.html crashes

Project Member Reported by xidac...@chromium.org, Sep 28 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/254e208459bbad1de03c735ec313e7f2caae156d

commit 254e208459bbad1de03c735ec313e7f2caae156d
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Sep 28 14:07:08 2017

paint/invalidation/video-paint-invalidation.html crash on MSAN

TBR=schenney@chromium.org
NOTRY=true

Bug:  769729 
Change-Id: I51b2f08827a09602ced344f9d3413a198d333b4a
Reviewed-on: https://chromium-review.googlesource.com/690534
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505014}
[modify] https://crrev.com/254e208459bbad1de03c735ec313e7f2caae156d/third_party/WebKit/LayoutTests/MSANExpectations

Components: Blink>Paint>Invalidation
Labels: Test-Layout OS-Linux OS-Windows
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1753c4cbedb7eb3780458d6ca53e8bda2355db9

commit c1753c4cbedb7eb3780458d6ca53e8bda2355db9
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Sep 28 17:26:16 2017

paint/invalidation/video-paint-invalidation.html crashes

TBR=schenney@chromium.org
NOTRY=true

Bug:  769729 
Change-Id: I51576dffb92b28cfff21143517433c3b2e9ac00e
Reviewed-on: https://chromium-review.googlesource.com/690745
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505075}
[modify] https://crrev.com/c1753c4cbedb7eb3780458d6ca53e8bda2355db9/third_party/WebKit/LayoutTests/TestExpectations

 Issue 769881  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/206bdc858ad26bc02172a308e6836921a1e41b38

commit 206bdc858ad26bc02172a308e6836921a1e41b38
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Sep 29 03:28:09 2017

Fix false-positives of under-invalidation checking in layout tests

In the following few cases we intentionally allow under-invalidations in
cached subsequences:
- offscreen image animation
- media buffered range

We intentionally don't update each time the contents change to improve
performance or avoid complex implementation of real time change
notification.

Now allow cache skipping in cached subsequences.

Enable under-invalidation checking for tests that would have reported
under-invalidation with the checking enabled.

This also helps clusterfuzz not to trigger under-invaldiation checking
failures when it creates a test for the above cases.

Bug:  769729 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2149e9d2304dbad5d7486c822d5452c5dba237fe
Reviewed-on: https://chromium-review.googlesource.com/690851
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505281}
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/media/media-document-audio-repaint.html
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-offscreen.html
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-transformed-offscreen.html
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/paint/invalidation/animated-png-offscreen.html
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/paint/invalidation/animated-webp-offscreen.html
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/paint/invalidation/svg/animated-svg-as-image-background-offscreen.html
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/paint/invalidation/svg/animated-svg-as-image-offscreen.html
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/paint/invalidation/svg/animated-svg-as-image-transformed-offscreen.html
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint.html
[rename] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint.html
[delete] https://crrev.com/2eb8bf2dd9cc73c9cd94bec994d5023b6c85a736/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/video-paint-invalidation-expected.txt
[delete] https://crrev.com/2eb8bf2dd9cc73c9cd94bec994d5023b6c85a736/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-paint-invalidation-expected.txt
[delete] https://crrev.com/2eb8bf2dd9cc73c9cd94bec994d5023b6c85a736/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/206bdc858ad26bc02172a308e6836921a1e41b38/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5830561dbba8913c652a7589d3b691708d4c0c0

commit d5830561dbba8913c652a7589d3b691708d4c0c0
Author: Mike West <mkwst@chromium.org>
Date: Fri Sep 29 08:09:49 2017

Revert "Fix false-positives of under-invalidation checking in layout tests"

This reverts commit 206bdc858ad26bc02172a308e6836921a1e41b38.

Reason for revert:

Several paint-related tests have begun crashing on "Linux Trusty (dbg)" after landing this patch, flakily hitting a CHECK in
`PaintController.cpp` (see the log in 
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty__dbg_/5565/layout-test-results/paint/invalidation/video-mute-repaint-stderr.txt).
It looks like this kind of crash happened while landing the patch as
well, at least on https://storage.googleapis.com/chromium-layout-test-archives/linux_layout_tests_slimming_paint_v2/6682/layout-test-results/results.html).
I'll revert it.


Original change's description:
> Fix false-positives of under-invalidation checking in layout tests
> 
> In the following few cases we intentionally allow under-invalidations in
> cached subsequences:
> - offscreen image animation
> - media buffered range
> 
> We intentionally don't update each time the contents change to improve
> performance or avoid complex implementation of real time change
> notification.
> 
> Now allow cache skipping in cached subsequences.
> 
> Enable under-invalidation checking for tests that would have reported
> under-invalidation with the checking enabled.
> 
> This also helps clusterfuzz not to trigger under-invaldiation checking
> failures when it creates a test for the above cases.
> 
> Bug:  769729 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I2149e9d2304dbad5d7486c822d5452c5dba237fe
> Reviewed-on: https://chromium-review.googlesource.com/690851
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505281}

TBR=wangxianzhu@chromium.org,chrishtr@chromium.org

Change-Id: Id0ddbc90d9cf4436fe10dc81485d9f13edef6f1a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  769729 ,  769879 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/691814
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505327}
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/media/media-document-audio-repaint.html
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-offscreen.html
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-transformed-offscreen.html
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/paint/invalidation/animated-png-offscreen.html
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/paint/invalidation/animated-webp-offscreen.html
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/paint/invalidation/svg/animated-svg-as-image-background-offscreen.html
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/paint/invalidation/svg/animated-svg-as-image-offscreen.html
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/paint/invalidation/svg/animated-svg-as-image-transformed-offscreen.html
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint.html
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint.html
[add] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/video-paint-invalidation-expected.txt
[add] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-paint-invalidation-expected.txt
[rename] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-paint-invalidation-expected.txt
[add] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/d5830561dbba8913c652a7589d3b691708d4c0c0/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp

Status: Assigned (was: Fixed)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25eefe8eafbb81a6bcdd55ca1b1557009adef922

commit 25eefe8eafbb81a6bcdd55ca1b1557009adef922
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Oct 03 18:25:13 2017

Reland "Fix false-positives of under-invalidation checking in layout tests"

This reverts commit d5830561dbba8913c652a7589d3b691708d4c0c0.

This reland fixes bugs in the original CL:
- When ending under-invalidation checking for a subsequence containing
  cache skipping display items, set next_item_to_match_ and next_item_to_index_
  to let remaining display items match normally.
- Fix DCHECK failure when ending an empty subsequence in a cached
  subsequence.
- Fix bug that under-invalidation checking of a parent subsequence
  was end by a child subsequence.

Original change's description:
> Revert "Fix false-positives of under-invalidation checking in layout tests"
> 
> This reverts commit 206bdc858ad26bc02172a308e6836921a1e41b38.
> 
> Reason for revert:
> 
> Several paint-related tests have begun crashing on "Linux Trusty (dbg)" after landing this patch, flakily hitting a CHECK in
> `PaintController.cpp` (see the log in 
> https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty__dbg_/5565/layout-test-results/paint/invalidation/video-mute-repaint-stderr.txt).
> It looks like this kind of crash happened while landing the patch as
> well, at least on https://storage.googleapis.com/chromium-layout-test-archives/linux_layout_tests_slimming_paint_v2/6682/layout-test-results/results.html).
> I'll revert it.
> 
> 
> Original change's description:
> > Fix false-positives of under-invalidation checking in layout tests
> > 
> > In the following few cases we intentionally allow under-invalidations in
> > cached subsequences:
> > - offscreen image animation
> > - media buffered range
> > 
> > We intentionally don't update each time the contents change to improve
> > performance or avoid complex implementation of real time change
> > notification.
> > 
> > Now allow cache skipping in cached subsequences.
> > 
> > Enable under-invalidation checking for tests that would have reported
> > under-invalidation with the checking enabled.
> > 
> > This also helps clusterfuzz not to trigger under-invaldiation checking
> > failures when it creates a test for the above cases.
> > 
> > Bug:  769729 
> > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Change-Id: I2149e9d2304dbad5d7486c822d5452c5dba237fe
> > Reviewed-on: https://chromium-review.googlesource.com/690851
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#505281}
> 
> TBR=wangxianzhu@chromium.org,chrishtr@chromium.org
> 
> Change-Id: Id0ddbc90d9cf4436fe10dc81485d9f13edef6f1a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  769729 ,  769879 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/691814
> Reviewed-by: Mike West <mkwst@chromium.org>
> Commit-Queue: Mike West <mkwst@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505327}

Change-Id: Idd2cd531d8fb6ac7b1a7e0330e69c2e8c93f6c33
Bug:  769729 ,  769772 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/692495
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506110}
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/media/media-document-audio-repaint.html
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-offscreen.html
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-transformed-offscreen.html
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/paint/invalidation/animated-png-offscreen.html
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/paint/invalidation/animated-webp-offscreen.html
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/paint/invalidation/svg/animated-svg-as-image-background-offscreen.html
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/paint/invalidation/svg/animated-svg-as-image-offscreen.html
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/paint/invalidation/svg/animated-svg-as-image-transformed-offscreen.html
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint.html
[rename] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint.html
[delete] https://crrev.com/67c1b8b0c8dc413606d8d03685d3549b1ac6c6b2/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/video-paint-invalidation-expected.txt
[delete] https://crrev.com/67c1b8b0c8dc413606d8d03685d3549b1ac6c6b2/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-paint-invalidation-expected.txt
[delete] https://crrev.com/67c1b8b0c8dc413606d8d03685d3549b1ac6c6b2/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/25eefe8eafbb81a6bcdd55ca1b1557009adef922/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment