Reenable TabSwitcherControllerTestCase/testCloseTabWithDialog |
|||||||||
Issue descriptionTest is flaky on iOS11 failures: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad11-device-x64/builds/672 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad11-device-x64/builds/671 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad11-device-x64/builds/669 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad11-device-x64/builds/667 ...
,
Oct 10 2017
Kurt, please take a look at this test. We are branching this week.
,
Oct 10 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e6cb39457ae9fc0d631aea1e0f21457a25501d3 commit 1e6cb39457ae9fc0d631aea1e0f21457a25501d3 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Oct 12 22:10:09 2017 [iOS] Reenable TabSwitcherControllerTestCase.testCloseTabWithDialog This CL updates the test to use the test fixture close tabs selector to leverage its built-in synchronization code. Bug: 769708 Change-Id: Ide740a246f75e933ae92a3711190fc482a119d11 Reviewed-on: https://chromium-review.googlesource.com/711382 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mike Baxley <baxley@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#508498} [modify] https://crrev.com/1e6cb39457ae9fc0d631aea1e0f21457a25501d3/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm
,
Oct 12 2017
Not sure if this landed before branch or not...
,
Oct 12 2017
This bug requires manual review: We don't branch M63 until 2017-10-12. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 23 2017
,
Oct 27 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 27 2017
,
Oct 27 2017
,
Jan 24 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by cma...@chromium.org
, Oct 3 2017