Have ProfileOAuth2TokenService explicitly remove account from AccountTrackerService on token revocation |
||||
Issue descriptionCurrently, AccountFetcherService observes PO2TS and on token revocation, removes the corresponding account from AccountTrackerService. This behavior is problematic because other observers of PO2TS can't necessarily get the info from the account in *their* OnRefreshTokenRevoked() callbacks. Instead, PO2TS should remove the account from the AccountTrackerService explicitly after calling OnRefreshTokenRevoked() on all its observers. That way observers (including IdentityManager) could just get the account information from AccountTrackerService in the PO2TS::OnRefreshTokenRevoked() observer callback. Several questions we need to answer: - How does that interact with AccountFetcherService observing OnRefreshTokenRevoked(), and how does it interact with AccountFetcherService removing the account from AccountTrackerService in other cases? - Will changing the ordering here break anything? Nothing should be relying on the current ordering in any case. - Do we need to make a corresponding change to the flow for the account being added to the AccountTrackerService when a refresh token is made available, or does that work differently?
,
Nov 1 2017
,
Nov 7 2017
,
Nov 6
--Chrome Identity automated triaging-- This bug is Available and has gone one year without any activity. If another month passes without any activity, this bug will be closed out. Please provide an update with the latest status for this bug. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 6
--Chrome Identity automated triaging-- This available, signin or profiles-related bug has gone at least 30 days since the last automated post without any further update. This bug will be closed out due to inactivity. Please re-open the bug and provide an update if it is still a valid or reproducible bug. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||
►
Sign in to add a comment |
||||
Comment 1 by blundell@chromium.org
, Sep 28 2017