New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769683 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task

Blocked on:
issue 779532
issue 780175

Blocking:
issue 767579
issue 756514
issue 772307
issue 777888



Sign in to add a comment

Update the android support library to 26.1.0

Project Member Reported by dgn@chromium.org, Sep 28 2017

Issue description

Requested to pull bug fixes to RecyclerView.

26.1.0 is the latest version at this time.

Also update the instructions at https://sites.google.com/a/google.com/clank/engineering/sdk-build/roll-support-library
 

Comment 1 by dgn@chromium.org, Sep 28 2017

Cc: bauerb@chromium.org paulmiller@chromium.org
Updating to 26.1 will be tricky as we can't use the SDK manager and there are new dependencies (arch components) that trigger new issues. Planning to step it up to 25.1.0 for now, which is already in the repo. That release already contains bugfixes

Comment 2 by dgn@chromium.org, Sep 29 2017

Cc: awdf@chromium.org
Updates, since I'll be off for 2 weeks.
I gave a shot to the 2 updates and ran into various issues:

- 25.1.0: builds fine, send a CL already (https://chromium-review.googlesource.com/c/chromium/src/+/690003) but it seems to affect UIs. Would need to check quickly that everything is all right and that the triggering of render test is not reflecting a UX issue. Additionally it introduces a bug (related to media router, freezes device and requires reboot) only fixed in 25.2. Not too keen on rolling to fix a bug if we introduce a potentially worse one.

- 26.1.0: added a script to download it, but there seems to be backwards incompatible changes: 
  + style removed: TextAppearance.StatusBar.EventContent.* => I don't see mentions of the change but we can't reference it anymore. awdf@, any thoughts on this? It affects Web notifications
  + AsyncInitializationActivity depends on LifecycleOwner from the Architecture components now, so that additional dependency needs to be added in a bunch of places.
CLs:
 + New binaries:  https://chromium-review.googlesource.com/#/c/android_tools/+/692895
 + Chromium changes: https://chromium-review.googlesource.com/#/c/chromium/src/+/692894

Comment 3 by dgn@chromium.org, Sep 29 2017

Additional script for direct download of dependencies, rather than using maven:
https://paste.googleplex.com/5843778548006912

Comment 4 by dgn@chromium.org, Sep 29 2017

Description: Show this description

Comment 5 by awdf@chromium.org, Oct 6 2017

Blocking: 767579
Cc: twelling...@chromium.org
We build release builds with the 26.0.0 version of the support library. We could roll downstream. Or, ideally, pull in the new support library in our upstream android-26 directory.
Blocking: 772307

Comment 8 by wnwen@chromium.org, Oct 25 2017

Wow, this is great! Thanks for working on this and a script to boot!
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/android_tools/+/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc

commit 8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Wed Oct 25 17:25:24 2017

Add support library v26.1.0 and arch v1.0.0

The architecture components are a new dependency of the support
library.

Bug:  769683 
Change-Id: Ic54d301b1b3c4a5ffa71a1db67f970ffd94026c3
Reviewed-on: https://chromium-review.googlesource.com/735544
Reviewed-by: John Budorick <jbudorick@chromium.org>

[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/support-core-utils/26.1.0/support-core-utils-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/support-core-ui/26.1.0/support-core-ui-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/support-annotations/26.1.0/support-annotations-26.1.0.jar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/transition/26.1.0/transition-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/appcompat-v7/26.1.0/appcompat-v7-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/preference-v7/26.1.0/preference-v7-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/animated-vector-drawable/26.1.0/animated-vector-drawable-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/leanback-v17/26.1.0/leanback-v17-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/preference-v14/26.1.0/preference-v14-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/preference-leanback-v17/26.1.0/preference-leanback-v17-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/support-compat/26.1.0/support-compat-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/cardview-v7/26.1.0/cardview-v7-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/support-vector-drawable/26.1.0/support-vector-drawable-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/android/arch/lifecycle/runtime/1.0.0/runtime-1.0.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/palette-v7/26.1.0/palette-v7-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/recyclerview-v7/26.1.0/recyclerview-v7-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/gridlayout-v7/26.1.0/gridlayout-v7-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/mediarouter-v7/26.1.0/mediarouter-v7-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/support-media-compat/26.1.0/support-media-compat-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/support-v13/26.1.0/support-v13-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/android/arch/lifecycle/common/1.0.0/common-1.0.0.jar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/android/arch/core/common/1.0.0/common-1.0.0.jar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/design/26.1.0/design-26.1.0.aar
[add] https://crrev.com/8e0c4b2a99e3d07ad7412a5e817f24ff4a3fe0cc/sdk/extras/android/m2repository/com/android/support/support-fragment/26.1.0/support-fragment-26.1.0.aar

Blocking: 777888

Comment 11 by dgn@chromium.org, Oct 25 2017

Status: Started (was: Assigned)
So... v27 just rolled out: https://developer.android.com/topic/libraries/support-library/revisions.html

I'll see how much extra work it take to roll to it, and might just go straight to 27 it if's not harder.

Comment 12 by wnwen@chromium.org, Oct 25 2017

Haah, thank you for your hard work, Nicolas! Scripting this is already paying off. :D

Hopefully with the new android_tools sdk refactor this will all be easier in the future.

Comment 13 by dgn@chromium.org, Oct 26 2017

Blocking: 704152
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/android_tools/+/ca0bd083872ad925881736fe2bedc3ff855e08f5

commit ca0bd083872ad925881736fe2bedc3ff855e08f5
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Fri Oct 27 10:10:44 2017

Update the support library to v27.0.0

Bug:  769683 
Change-Id: I07484b06cb129dc4bc84b54c6b289f634bcc9eeb
Reviewed-on: https://chromium-review.googlesource.com/738376
Reviewed-by: John Budorick <jbudorick@chromium.org>

[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/leanback-v17/27.0.0/leanback-v17-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/recyclerview-v7/27.0.0/recyclerview-v7-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/android/arch/lifecycle/runtime/1.0.0/runtime-1.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/palette-v7/27.0.0/palette-v7-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/android/arch/lifecycle/common/1.0.0/common-1.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-v13/27.0.0/support-v13-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/preference-leanback-v17/27.0.0/preference-leanback-v17-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-compat/27.0.0/support-compat-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/mediarouter-v7/27.0.0/mediarouter-v7-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/transition/27.0.0/transition-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/gridlayout-v7/27.0.0/gridlayout-v7-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-vector-drawable/27.0.0/support-vector-drawable-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/gridlayout-v7/27.0.0/gridlayout-v7-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-media-compat/27.0.0/support-media-compat-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/recyclerview-v7/27.0.0/recyclerview-v7-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/mediarouter-v7/27.0.0/mediarouter-v7-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-vector-drawable/27.0.0/support-vector-drawable-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/palette-v7/27.0.0/palette-v7-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/design/27.0.0/design-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/android/arch/core/common/1.0.0/common-1.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-fragment/27.0.0/support-fragment-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/cardview-v7/27.0.0/cardview-v7-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/preference-v14/27.0.0/preference-v14-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-core-utils/27.0.0/support-core-utils-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/preference-leanback-v17/27.0.0/preference-leanback-v17-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-compat/27.0.0/support-compat-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/animated-vector-drawable/27.0.0/animated-vector-drawable-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/animated-vector-drawable/27.0.0/animated-vector-drawable-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/appcompat-v7/27.0.0/appcompat-v7-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-fragment/27.0.0/support-fragment-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/preference-v14/27.0.0/preference-v14-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-core-ui/27.0.0/support-core-ui-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/preference-v7/27.0.0/preference-v7-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/cardview-v7/27.0.0/cardview-v7-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-annotations/27.0.0/support-annotations-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/appcompat-v7/27.0.0/appcompat-v7-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-core-ui/27.0.0/support-core-ui-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-core-utils/27.0.0/support-core-utils-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/leanback-v17/27.0.0/leanback-v17-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/design/27.0.0/design-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/preference-v7/27.0.0/preference-v7-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/transition/27.0.0/transition-27.0.0.aar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-annotations/27.0.0/support-annotations-27.0.0.jar
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-media-compat/27.0.0/support-media-compat-27.0.0.pom
[add] https://crrev.com/ca0bd083872ad925881736fe2bedc3ff855e08f5/sdk/extras/android/m2repository/com/android/support/support-v13/27.0.0/support-v13-27.0.0.aar

Project Member

Comment 15 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57ab37b9931bb0e18ca212d1f54f54d50fbb4e6b

commit 57ab37b9931bb0e18ca212d1f54f54d50fbb4e6b
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Fri Oct 27 10:20:39 2017

📱 Remove dependency on pre v14 support lib styles

The TextAppearance.StatusBar.EventContent.* styles are getting
removed from the support library v26, but since they are in the
framework since API 14, which is older than our min SDK, we can
use the framework styles directly.

Bug:  769683 
Change-Id: I6a221fd5dd2ca22360f75a7ae2fac418ead954bb
Reviewed-on: https://chromium-review.googlesource.com/738132
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512142}
[modify] https://crrev.com/57ab37b9931bb0e18ca212d1f54f54d50fbb4e6b/chrome/android/java/res/values-v17/styles.xml

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15f16222e0377c88a0a68392d7a11be2068a9957

commit 15f16222e0377c88a0a68392d7a11be2068a9957
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Fri Oct 27 13:36:36 2017

📱 Prepare for the support library roll

The support library roll will require update in both the public and
the internal repos. In order to avoid breaking the builders, this
patch declares target we will need downstream so that they can be
referred to early.

Bug:  769683 
Change-Id: If45b97ec373d1e876d0069037e7cbc2005bf7eb8
Reviewed-on: https://chromium-review.googlesource.com/738768
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512169}
[modify] https://crrev.com/15f16222e0377c88a0a68392d7a11be2068a9957/build/secondary/third_party/android_tools/BUILD.gn

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/b9e12ae762bc0608ab94241cfe16b72184300a79

commit b9e12ae762bc0608ab94241cfe16b72184300a79
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Fri Oct 27 19:31:10 2017

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1f36fd3560487bb6f2c2e4d140422780f700c32

commit a1f36fd3560487bb6f2c2e4d140422780f700c32
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Mon Oct 30 12:57:10 2017

📱 Roll android support library to 27.0.0

This patch adds dependencies on the architecture components
to a few of our build targets.

For support library patch notes, see
https://developer.android.com/topic/libraries/support-library/rev-archive.html#25-1-0
and https://developer.android.com/topic/libraries/support-library/revisions.html
(we moved from 25.0.1 to 27.0.0)


TBR=lambroslambrou@chromium.org

Bug:  769683 
Change-Id: Ib7c23043aee0b2e699df12a58e646a8035e8666e
Reviewed-on: https://chromium-review.googlesource.com/692894
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512479}
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/DEPS
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/BUILD.gn
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/BUILD.gn
[add] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_arch_lifecycle_runtime_java.info
[add] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_animated_vector_drawable_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_compat_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_core_ui_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_core_utils_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_design_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_fragment_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_media_compat_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_transition_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_v13_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_v14_preference_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_v17_leanback_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_v17_preference_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_v7_appcompat_java_internal.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_v7_mediarouter_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_v7_palette_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_v7_preference_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/build/secondary/third_party/android_tools/support/android_support_vector_drawable_java.info
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/chrome/android/BUILD.gn
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationCompatBuilder.java
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/chrome/test/android/BUILD.gn
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/components/test/data/payments/render_tests/PaymentRequestFreeShippingTest.unmask.Nexus_5-19.png
[modify] https://crrev.com/a1f36fd3560487bb6f2c2e4d140422780f700c32/remoting/android/client_java_tmpl.gni

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/9bcc135c8a480b95ffbb3810d6f1b3a2c7b16ed1

commit 9bcc135c8a480b95ffbb3810d6f1b3a2c7b16ed1
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Mon Oct 30 17:01:13 2017

Comment 20 by dgn@chromium.org, Nov 1 2017

Blockedon: 780175 779532
Cc: jbudorick@chromium.org agrieve@chromium.org
Status: Assigned (was: Started)
Leaving the issue still open until regressions are resolved:

APK Size: issue 779532
Memory:  issue 780175 

Comment 21 by dgn@chromium.org, Nov 9 2017

Updated the instructions at go/clank/engineering/sdk-build/roll-support-library
with new command line and hints to help resolving dependencies issues.
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2502df47412e2a9ca09f16714846d0babeff6d93

commit 2502df47412e2a9ca09f16714846d0babeff6d93
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Thu Nov 09 21:40:40 2017

📱 Script to update the support lib using Maven

Used to generate the library roll from 
https://chromium-review.googlesource.com/c/android_tools/+/738376

Bug:  769683 
Change-Id: Ifabe8e874624fcfee33bb58c185bf13b20d8e947
Reviewed-on: https://chromium-review.googlesource.com/737800
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515302}
[modify] https://crrev.com/2502df47412e2a9ca09f16714846d0babeff6d93/build/android/play_services/update.py
[add] https://crrev.com/2502df47412e2a9ca09f16714846d0babeff6d93/build/android/pylib/utils/maven_downloader.py
[modify] https://crrev.com/2502df47412e2a9ca09f16714846d0babeff6d93/tools/android/roll/update_support_library.py

Comment 23 by dgn@chromium.org, Dec 18 2017

Status: Fixed (was: Assigned)
CL stuck and we're moving forward. Closing the issue.
Project Member

Comment 24 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0bc83c3c122649b905ed2f354914a520f344fe2

commit b0bc83c3c122649b905ed2f354914a520f344fe2
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Fri May 25 01:52:35 2018

Replace ContextUtils.startForegroundService with support library

Use android.support.v4.content.ContextCompat#startForegroundService(Context, Intent)
instead of ContextUtils.startForegroundService(Context, Intent).

Bug:  769683 
Change-Id: I3989dd04257e1f8ebe61228d6ec6876f04c9faba
Reviewed-on: https://chromium-review.googlesource.com/1065958
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561732}
[modify] https://crrev.com/b0bc83c3c122649b905ed2f354914a520f344fe2/base/android/java/src/org/chromium/base/ContextUtils.java
[modify] https://crrev.com/b0bc83c3c122649b905ed2f354914a520f344fe2/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java

Blocking: -704152

Sign in to add a comment