New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769681 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 728256
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference in blink::HasVerticalAppearance

Project Member Reported by ClusterFuzz, Sep 28 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5692558083883008

Fuzzer: inferno_twister
Job Type: windows_syzyasan_content_shell
Platform Id: windows

Crash Type: Null-dereference
Crash Address: 0x0000000f
Crash State:
  blink::HasVerticalAppearance
  blink::LayoutSliderContainer::UpdateLayout
  blink::LayoutBlockFlow::PositionAndLayoutOnceIfNeeded
  
Memory Tool: SYZYASAN

Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_content_shell&range=504793:504871

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5692558083883008

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: msrchandra@chromium.org pnangunoori@chromium.org
Components: Blink>Layout
Labels: M-63 Test-Predator-Wrong
Owner: dcheng@chromium.org
Status: Assigned (was: Untriaged)
As per the  Issue 765949  owner assigning this issue to @dcheng.
@dcheng -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.
Thanks.

Comment 2 by dcheng@chromium.org, Sep 29 2017

Owner: e...@chromium.org
My CL just changed some names. +eae for routing this to the appropriate person on layout
Project Member

Comment 3 by ClusterFuzz, Oct 1 2017

Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
Labels: -Test-Predator-AutoComponents
Mergedinto: 728256
Status: Duplicate (was: Assigned)
Duping this into 728256, since that one has a more useful stack.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6cc8b72e6cc0d79db438da47fda28971880eb87

commit d6cc8b72e6cc0d79db438da47fda28971880eb87
Author: Emil A Eklund <eae@chromium.org>
Date: Tue Oct 03 01:00:38 2017

Add null check to LayoutSliderContainer::HasVerticalAppearance

Bug:  769681 
Change-Id: I28e9597aa2d1888f9890bb37d536b1e3b3886330
Reviewed-on: https://chromium-review.googlesource.com/692956
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505897}
[modify] https://crrev.com/d6cc8b72e6cc0d79db438da47fda28971880eb87/third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp

Project Member

Comment 7 by ClusterFuzz, Oct 3 2017

ClusterFuzz has detected this issue as fixed in range 505590:505621.

Detailed report: https://clusterfuzz.com/testcase?key=5692558083883008

Fuzzer: inferno_twister
Job Type: windows_syzyasan_content_shell
Platform Id: windows

Crash Type: Null-dereference
Crash Address: 0x0000000f
Crash State:
  blink::HasVerticalAppearance
  blink::LayoutSliderContainer::UpdateLayout
  blink::LayoutBlockFlow::PositionAndLayoutOnceIfNeeded
  
Memory Tool: SYZYASAN

Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_content_shell&range=504793:504871
Fixed: https://clusterfuzz.com/revisions?job=windows_syzyasan_content_shell&range=505590:505621

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5692558083883008

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Comment 8 by e...@chromium.org, Oct 3 2017

Status: Fixed (was: Duplicate)

Sign in to add a comment