New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769670 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 28 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

video tag has caused tab crash when inspect shadow element inspect some element

Reported by congcong...@gmail.com, Sep 28 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36

Steps to reproduce the problem:
1. guarantee to inspect shadow element
2. inspect video shadow elements
3. click the  <input pseudo="-internal-media-controls-overlay-cast-button" type="button" style = "display:none"> in shadow elements to keep it be chosen,then the tab crashed.

What is the expected behavior?
correctly be chosen

What went wrong?
current page get crashed

Did this work before? N/A 

Chrome version: 60.0.3112.113  Channel: stable
OS Version: OS X 10.12.3
Flash Version:
 
2292A34A-98A4-4746-8D07-ABA09958519D.png
93.3 KB View Download
0ADF0D17-ACE0-4348-8897-FDE0FD416D59.png
269 KB View Download
Labels: Needs-Triage-M60
Can you attach the testcase?
1.enter https://www.w3schools.com/html/html5_video.asp
2.open devtool and keep the  'Show user agent shadow DOM' option be selected
2.inspect video shadow elements
3.put you cursor on the ' <input pseudo="-internal-media-controls-overlay-cast-button" type="button" style="display:none"> '
4.then page will crash 100%

it's a devtool's bug maybe.
need more infomation.let me konw
Labels: -Pri-2 Pri-1
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffdd951da2554d439c4c67eb92d6cd464d3f8fd6

commit ffdd951da2554d439c4c67eb92d6cd464d3f8fd6
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Tue Oct 31 05:36:25 2017

CSSSelectorParser: usage reporting should check for stylesheet

StyleSheet is not always defined in the context of CSSSelectorParser.
This patch adds a check to usage reporting that verifies that there's a
stylesheet.

BUG= chromium:769670 
R=pfeldman

Change-Id: I890e561092cf2e53b9f3c392b9e3c4be7fdcb82d
Reviewed-on: https://chromium-review.googlesource.com/744592
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512752}
[modify] https://crrev.com/ffdd951da2554d439c4c67eb92d6cd464d3f8fd6/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

Status: Fixed (was: Assigned)
Labels: TE-Verified-M64 TE-Verified-64.0.3255.0
Verified the fix on Mac 10.12.6 using latest chrome version #64.0.3255.0 as per the comment #2.
Attaching screen cast for reference.
Observed that the current page did not get crash upon clicking the  <input pseudo="-internal-media-controls-overlay-cast-button" type="button" style = "display:none"> in shadow elements. 
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
769670.mp4
3.2 MB View Download

Sign in to add a comment