See the attachment.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40f1676bd7e00f3e91799cbd60d1f267d8a63f91 commit 40f1676bd7e00f3e91799cbd60d1f267d8a63f91 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Thu Sep 28 12:16:16 2017 [Password Manager] Introduce strings for new layout of save prompt New layout introduces two labels: "Username" and "Password". Bug: 769666 , 753806 Change-Id: I04adfef7da32a6c03697d83b57ef764cf31a3496 Reviewed-on: https://chromium-review.googlesource.com/690114 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#504973} [modify] https://crrev.com/40f1676bd7e00f3e91799cbd60d1f267d8a63f91/chrome/app/generated_resources.grd
Fixed alignment of labels
Update bubble screenshots
FYI, labels in bookmarks ui are right aligned.
Thanks for pointing this out. Please follow the current practice and standard behavior: labels are right-aligned in the current UI (your screenshot), Harmony will be using left-alignment (attached screenshot).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc75dfa9a1c98141af036140090e698deb64c2c1 commit dc75dfa9a1c98141af036140090e698deb64c2c1 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Fri Sep 29 12:20:51 2017 [Password Manager] Implement new layout for a save prompt Prompt should have labels: "Username" and "Password" Username and password will be on separate lines. See screenshots in the bug. Since both owners are OOO, but the CL should be landed before feature freeze, the CL will be landed only with TBR. TBR=vasilii@chromium.org Bug: 769666 Change-Id: I9f43163ff4286e6f7c3ef526572f3ca4ae971fab Reviewed-on: https://chromium-review.googlesource.com/690344 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#505352} [modify] https://crrev.com/dc75dfa9a1c98141af036140090e698deb64c2c1/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
Will re-open the bug if corrections are needed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc commit cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Tue Oct 10 11:33:44 2017 Implement password selection and viewing on Mac. The CL changes the layout of the password bubble on Mac according to the mocks. The password selection combobox and eye icon are now fully functional. Bug: 769666 ,753806, 768781 Change-Id: Iac6f6186f07bad3da2e5f66407ddc782b61f1842 Reviewed-on: https://chromium-review.googlesource.com/708261 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#507639} [modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm [modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/password_item_views.h [modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h [modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.mm [modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm [modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.h [modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm [modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm
Comment 1 by kolos@chromium.org
, Sep 28 2017