New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769629 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Move text-decoration-tests to wpt

Project Member Reported by drott@chromium.org, Sep 28 2017

Issue description

We have a set of text-decoration tests in 
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/
which can be moved to wpt, and marked as -visual... tests.


 
@drott - AFAIU we need to move these test cases from src/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/ TO 

src/third_party/WebKit/LayoutTests/external/wpt/ folder .

But I didn't understand "marked as -visual... tests" .

Can you please let me know if this is what is needed and elaborate on "marked as -visual... tests."

Thanks,
Nikhil

Comment 2 by drott@chromium.org, Oct 23 2017

As far as I understand WPT documentation, pixel tests need to follow the filename convention ...-visual.html


Components: Blink>CSS

Comment 4 by gracec@chromium.org, Oct 27 2017

Labels: Test-Layout

Comment 5 by gracec@chromium.org, Oct 27 2017

Labels: Update-Quarterly

Comment 6 by nainar@chromium.org, Nov 30 2017

Labels: -Type-Bug Type-Task
Labels: -Update-Quarterly
Owner: shanmug...@samsung.com
Status: Assigned (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5

commit 18c79fd5d8c63f4c48f23a74123e6540ba8d53d5
Author: Shanmuga Pandi M <shanmuga.m@samsung.com>
Date: Thu Dec 07 12:37:22 2017

Move css3 text-decoration tests to WPT

Bug:  769629 
Change-Id: I996148aba74d03db821bb5f948d2d60dd321c808
Reviewed-on: https://chromium-review.googlesource.com/813440
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#522406}
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/line-through-vertical-ref.html
[add] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/line-through-vertical.html
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/text-decoration-color-recalc-ref.html
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/text-decoration-color-recalc.html
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/text-decoration-color-ref.html
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/text-decoration-color.html
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/text-decoration-line-recalc-ref.html
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/text-decoration-line-recalc.html
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/text-decoration-line-ref.html
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/text-decoration-line.html
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/text-decoration-style-multiple-ref.html
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/text-decoration-style-multiple.html
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/text-decoration-style-recalc-ref.html
[rename] https://crrev.com/18c79fd5d8c63f4c48f23a74123e6540ba8d53d5/third_party/WebKit/LayoutTests/external/wpt/css/CSS3/text-decoration/text-decoration-style-recalc.html
[delete] https://crrev.com/20bea7a68c823e5b7eb37487ee169dc4ff2bf00a/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/line-through-vertical.html

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b0721d2e0a2f632436646b89648959f69a9dce9

commit 3b0721d2e0a2f632436646b89648959f69a9dce9
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Fri Dec 08 13:10:24 2017

Move wpt text-decoration tests into css-text-decor

Bug:  769629 
Change-Id: I6cf1026a3af6853d1870c740f37136ab29a11f92
Reviewed-on: https://chromium-review.googlesource.com/816956
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522770}
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/line-through-vertical-ref.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/line-through-vertical.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-color-recalc-ref.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-color-recalc.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-color-ref.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-color.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-line-recalc-ref.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-line-recalc.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-line-ref.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-line.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-style-multiple-ref.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-style-multiple.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-style-recalc-ref.html
[rename] https://crrev.com/3b0721d2e0a2f632436646b89648959f69a9dce9/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-style-recalc.html

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c4398454e962300f20adf6bd32a2431389509c0

commit 0c4398454e962300f20adf6bd32a2431389509c0
Author: Shanmuga Pandi M <shanmuga.m@samsung.com>
Date: Mon Dec 18 13:51:42 2017

Move wpt css-text-decor/*-ref.html into reference

Bug:  769629 
Change-Id: If9ea16b53f7201a0abe92aebc119e0bc4c6c2e20
Reviewed-on: https://chromium-review.googlesource.com/831383
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524698}
[modify] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/line-through-vertical.html
[rename] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/reference/line-through-vertical-ref.html
[rename] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/reference/text-decoration-color-recalc-ref.html
[rename] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/reference/text-decoration-color-ref.html
[rename] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/reference/text-decoration-line-recalc-ref.html
[rename] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/reference/text-decoration-line-ref.html
[rename] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/reference/text-decoration-style-multiple-ref.html
[rename] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/reference/text-decoration-style-recalc-ref.html
[modify] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-color-recalc.html
[modify] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-color.html
[modify] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-line-recalc.html
[modify] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-line.html
[modify] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-style-multiple.html
[modify] https://crrev.com/0c4398454e962300f20adf6bd32a2431389509c0/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-style-recalc.html

Comment 12 by e...@chromium.org, May 18 2018

Status: Fixed (was: Assigned)

Sign in to add a comment