New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 769615 link

Starred by 1 user
Status: Fixed
Owner:
szager@chromium.org
Closed: Sep 21
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Down arrow of vertical scrollbar doesn't get disable on Add address overlay.

Reported by dchau...@etouch.net, Sep 28 2017 
Chrome Version: 63.0.3226.0 (Official Build)209b73b2d53c279870bd421b7c04a1427798e2ef-refs/heads/master@{#504841} 32/64-bit.
OS: Windows (7,8,8.1,10),Linux (14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://settings/autofill 
2. Click on ADD button under Addresses section to open Add address overlay.
3. Zoom out the page to 33% and scroll down the vertical scroll bar to it's bottom end, observe.

Down arrow of vertical scroll bar doesn't get disable.
Down arrow of vertical scroll bar should get disabled.

This is a regression issue, broken in M-62 series, below is manual regression range.

Good build: 62.0.3178.0
Bad build: 62.0.3179.0

You are probably looking for a change made after 492372 (known good), but no later than 492373 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/8ae3ea1c2efcf9d2786cb1af66315b08f0a95051..01cf6fd553bcc6d5a9ca6763eed42fbca5ecc494

Suspect: https://chromium.googlesource.com/chromium/src/+/01cf6fd553bcc6d5a9ca6763eed42fbca5ecc494

@szager: Kindly help to reassign, if your changes are not related to this issue.

Note: This issue is not seen on Mac OS.

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
897 KB View Download
Expected behavior.mp4
271 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b678fb668cf050db7f630a33c9593262baf7d8a5

commit b678fb668cf050db7f630a33c9593262baf7d8a5
Author: Stefan Zager <szager@chromium.org>
Date: Fri Sep 21 14:48:50 2018

Fix logic for determing if scrollbar is scrolled to the end

Scrollbar::Maximum is used by the theme paint code to determine whether
to disable the scroll arrows, based on whether the current scrollbar
position is all the way at the beginning or end of its range.

The rounding code used to set the visible size and overflow size for
the scrollbar behaves differently from that used by ScrollableArea to
clamp scroll offsets. The CL makes Scrollbar fall back to using values
computed by the ScrollableArea.

BUG= 769615 
R=skobes@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I982e71b485cc402972cb7ac1f5f482c1f84e1a70
Reviewed-on: https://chromium-review.googlesource.com/1237390
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593181}
[modify] https://crrev.com/b678fb668cf050db7f630a33c9593262baf7d8a5/third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc
[modify] https://crrev.com/b678fb668cf050db7f630a33c9593262baf7d8a5/third_party/blink/renderer/core/scroll/scrollbar.cc
[modify] https://crrev.com/b678fb668cf050db7f630a33c9593262baf7d8a5/third_party/blink/renderer/core/scroll/scrollbar.h

Comment 2 by szager@chromium.org, Sep 21

Status: Fixed (was: Assigned)
►

Sign in to add a comment