deleted item still show up in "Download Home" |
||||
Issue description1. On an Android device, click a download link from Gmail, which opens CCT to download. 2. In Android Downloads, delete the file. 3. Repeat 1 to download again. 4. Check in Chrome's "Download Home", there are two entries. Observed in Chrome Dev. Haven't checked the other channels.
,
Sep 28 2017
Xing can you take a look? I believe we have some code to check if files are gone and clean up the entries in that case. This is a bit odd because the file will still be there if our check runs after the second download... I think we need a better/smarter check here.
,
Sep 30 2017
,
Oct 9 2017
For the second download, I think CCT didn't initialize download manager service in Android layer, so it didn't run the code to remove the first download item after the external file removal check. Probably add one line code in CustomTabActivity will work.
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90dd49e01c252474215575850f932c5b4f246522 commit 90dd49e01c252474215575850f932c5b4f246522 Author: Xing Liu <xingliu@chromium.org> Date: Tue Oct 10 20:03:57 2017 Download Android: Fixed an issue with CCT download files check. CCT may not load DownloadManagerService, so external removed files may not be deleted with DownloadHistoryAdapter.updateDeletedFileMap. This CL adds checkForExternallyRemovedDownloads call in ChromeActivity, so CustomTabActivity will also build the native bridge in DownloadManagerService. Currently we have duplicate calls to check file removals. Bug: 769613 Change-Id: I25e6a7e710b4baf642cbc2fbf21984a05086ee07 Reviewed-on: https://chromium-review.googlesource.com/707586 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#507746} [modify] https://crrev.com/90dd49e01c252474215575850f932c5b4f246522/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
,
Nov 3 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 Deleted