New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769608 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Red cross mark is not seen on blocked permission icon.

Reported by shruti.j...@etouch.net, Sep 28 2017

Issue description

Chrome Version:63.0.3226.0 209b73b2d53c279870bd421b7c04a1427798e2ef-refs/heads/master@{#504841}(32/64-bit)  
OS: Windows(7,8,10), Linux(14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, navigate to https://permission.site/.
(2) Click on 'MIDI' button and click on 'block' button in permission bubble.
(3) Observe blocked icon in omnibox

Actual: Red cross mark is not seen on blocked permission icon in omnibox(instead, only single red dot is seen which is not easily visible)

Expected: Red cross mark should be clearly visible for every blocked permission

This is a regression issue, broken in 'M-63', will soon update the bisect info:
Good Build: 63.0.3225.0
Bad Build: 63.0.3226.0
 
expected.mp4
247 KB View Download
Kindly refer the attached actual video
actuall.mp4
502 KB View Download
Labels: hasbisect-per-revision OS-Mac
Owner: sammiequon@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build: 63.0.3225.0 (Revision: 504541)
Bad Build:  63.0.3226.0 (Revision: 504841)  


You are probably looking for a change made after 504775 (known good), but no later than 504776 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/01507a2a20c4d6acfc4338b1caf1763a95a29b99..f7fde4b94712922ea68b740dd7e5d0db914b82d3

Suspect: https://chromium.googlesource.com/chromium/src/+/f7fde4b94712922ea68b740dd7e5d0db914b82d3

Note: Issue is also reproducible on Mac(10.12.6) OS using latest canary 63.0.3226.0.

@sammiequon:Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3b6dc2a303c8b321b4aefaee80ef06c9f03dce

commit 8b3b6dc2a303c8b321b4aefaee80ef06c9f03dce
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Oct 02 19:43:34 2017

vector icon: Fix regression in paint vector icon.

Introduced by https://chromium-review.googlesource.com/c/chromium/src/+/687826.
The x in icons in the omnibox are not drawn properly (see bug on how to
reproduce). This is because ScopedRTLFlipCanvas also saves and restores
the canvas state. Introduce a ScopedCanvas so that the canvas state gets
restored after scaling the image.

Test: manual
Bug:  769608 
Change-Id: Ie26a88befde661add8ea779ae5d6802ad651583c
Reviewed-on: https://chromium-review.googlesource.com/690779
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505729}
[modify] https://crrev.com/8b3b6dc2a303c8b321b4aefaee80ef06c9f03dce/ui/gfx/paint_vector_icon.cc

Labels: Merge-Request-62 Merge-Request-61
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 3 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: TE-Verified-63 TE-Verified-63.0.3231.0
Note:
Retested the above issue on Canary #63.0.3231.0 on Windows(7,8,10), Linux(14.04 LTS) MAC(10.12.6) and fix is working as intended.

Thank You
redcrossverified.mp4
273 KB View Download
Thank You
Labels: -Merge-Review-62 Merge-Approved-62
Thanks for confirming. Approving merge to M62 (branch:3202)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 5 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0472ff0ccfd14fa30d5b5c17032556846bbc1958

commit 0472ff0ccfd14fa30d5b5c17032556846bbc1958
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Oct 05 19:21:13 2017

[merge to 62] vector icon: Fix regression in paint vector icon.

Introduced by https://chromium-review.googlesource.com/c/chromium/src/+/687826.
The x in icons in the omnibox are not drawn properly (see bug on how to
reproduce). This is because ScopedRTLFlipCanvas also saves and restores
the canvas state. Introduce a ScopedCanvas so that the canvas state gets
restored after scaling the image.

TBR=sammiequon@google.com

(cherry picked from commit 8b3b6dc2a303c8b321b4aefaee80ef06c9f03dce)

Test: manual
Bug:  769608 
Change-Id: Ie26a88befde661add8ea779ae5d6802ad651583c
Reviewed-on: https://chromium-review.googlesource.com/690779
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505729}
Reviewed-on: https://chromium-review.googlesource.com/703195
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#596}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/0472ff0ccfd14fa30d5b5c17032556846bbc1958/ui/gfx/paint_vector_icon.cc

Labels: -Merge-Request-61 Merge-Approved-61
We are not planning for another m61 but we can opportunistically merge in case there is one 
Project Member

Comment 12 by sheriffbot@chromium.org, Oct 9 2017

Cc: abdulsyed@chromium.org josa...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: TE-Verified-62 TE-Verified-62.0.3202.52
Note:
Retested the above issue on Beta#62.0.3202.52 on Windows(7,8,10), Linux(14.04 LTS) MAC(10.12.6) and fix is working as intended.

Thank You
redcrospgo.mp4
884 KB View Download
Labels: -TE-Verified-62 -TE-Verified-63 TE-Verified-M63 TE-Verified-M62
If there is no pending work, can we tag this bug as fixed?
Project Member

Comment 16 by sheriffbot@chromium.org, Oct 12 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on M64 dev build (10124.0.0, 64.0.3265.0).

Sign in to add a comment