New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769603 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

pobfuzz: SkMatrix::invertNonIdentity(SkMatrix*) -> SkMatrix::setTypeMask invalid type assert

Project Member Reported by ClusterFuzz, Sep 28 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6263899665203200

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x03e900006e55
Crash State:
  sk_abort_no_print
  SkMatrix::setTypeMask
  SkMatrix::invertNonIdentity
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=493187:493236

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6263899665203200

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Components: Internals>Skia
Labels: M-62 Test-Predator-Wrong

Comment 2 by enne@chromium.org, Sep 28 2017

Cc: enne@chromium.org
Labels: -Pri-1 -M-62 Pri-2
Owner: bsalomon@chromium.org
Status: Assigned (was: Untriaged)
Summary: pobfuzz: SkMatrix::invertNonIdentity(SkMatrix*) -> SkMatrix::setTypeMask invalid type assert (was: Abrt in sk_abort_no_print)
Project Member

Comment 3 by ClusterFuzz, Oct 1 2017

Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
Labels: -Test-Predator-AutoComponents
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8014051d3682961c3b79a6cace11d7351bdd279f

commit 8014051d3682961c3b79a6cace11d7351bdd279f
Author: Adrienne Walker <enne@chromium.org>
Date: Wed Oct 04 02:03:49 2017

cc: Fix identity matrix serialization

https://chromium-review.googlesource.com/667796 was a little overzealous
in clearing serialized SkMatrix flags.  It turns out that Skia is
confused when handed an identity matrix that doesn't know that it's
identity.  I think that probably would have eliminated some
optimizations as well.

To fix this, if a matrix says that it's identity, then clobber values
so that it's not lying.  If a matrix is not, then clobber the type
so that it can figure out the correct derived type.

This patch also adds matrix fixup logic to PaintShader matrices.

Bug:  769603 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0958b27e4613fc16aba230613a875f089039ae5d
Reviewed-on: https://chromium-review.googlesource.com/696181
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506275}
[modify] https://crrev.com/8014051d3682961c3b79a6cace11d7351bdd279f/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/8014051d3682961c3b79a6cace11d7351bdd279f/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/8014051d3682961c3b79a6cace11d7351bdd279f/cc/paint/paint_op_reader.cc
[modify] https://crrev.com/8014051d3682961c3b79a6cace11d7351bdd279f/cc/paint/paint_op_reader.h

Project Member

Comment 6 by ClusterFuzz, Oct 4 2017

ClusterFuzz has detected this issue as fixed in range 506271:506294.

Detailed report: https://clusterfuzz.com/testcase?key=6263899665203200

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x03e900006e55
Crash State:
  sk_abort_no_print
  SkMatrix::setTypeMask
  SkMatrix::invertNonIdentity
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=493187:493236
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=506271:506294

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6263899665203200

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Oct 4 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6263899665203200 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment