Toolbar button tooltip appears after choosing a command |
|||||||||||
Issue descriptionChrome Version: 63.0.3225.0 What steps will reproduce the problem? (1) Click "Sort options" button quickly. Make sure not to hover on the button tool long, so that the tooltip "Sort options" should not appear at this moment. (2) Click any of the menu item. (e.g. "Date modified") (3) Wait for a second. What is the expected result? No tooltip appears, unless mouse pointer is hovering on a button. What happens instead? "Sort options" tooltip appears regardless of mouse pointer position. This could also be reproduced with touchscreen tap instead of mouse. Same issue observed on the context menu button and the gear menu button, after choosing cut, copy, or Help.
,
Oct 2 2017
,
Oct 3 2017
Moving target milestone of non-P1 issues to M63.
,
Oct 4 2017
This does not reproduce when the focus is already on the button before step #1. Adding this step will make it always reproduce. (0) Click/tap on the "Swtich to thumbnail view" button, or any other part of the Files app than the sort options button.
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10a97df6559061ad5b81e9be7b59dd616fb44fe0 commit 10a97df6559061ad5b81e9be7b59dd616fb44fe0 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Tue Oct 10 08:17:22 2017 Do not show tooltip when focus moved as a result of mouse operation. Focus is also moved a menu-button after executing or dismissing menu by mouse/touch. In such case we should not show the tooltip unlike when manually focusing it by keyboard. As a side effect, tooltip will not appear when focusing by keyboard when button focus is made invisible by Issue 748489 . It will be resolved when Issue 748489 is fixed. Bug: 769593 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieda9e391117103d91ddad584705173674b3470ae Reviewed-on: https://chromium-review.googlesource.com/700116 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#507616} [modify] https://crrev.com/10a97df6559061ad5b81e9be7b59dd616fb44fe0/ui/file_manager/file_manager/foreground/elements/files_tooltip.js [modify] https://crrev.com/10a97df6559061ad5b81e9be7b59dd616fb44fe0/ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.js
,
Oct 11 2017
,
Oct 11 2017
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc19783572cb7a575421da6a2b67fb54abef0d75 commit bc19783572cb7a575421da6a2b67fb54abef0d75 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Fri Oct 13 12:34:54 2017 Revert "Do not show tooltip when focus moved as a result of mouse operation." This reverts commit 10a97df6559061ad5b81e9be7b59dd616fb44fe0. Reason for revert: It caused regression crbug/774380 Original change's description: > Do not show tooltip when focus moved as a result of mouse operation. > > Focus is also moved a menu-button after executing or dismissing menu > by mouse/touch. In such case we should not show the tooltip unlike when > manually focusing it by keyboard. > > As a side effect, tooltip will not appear when focusing by keyboard > when button focus is made invisible by Issue 748489 . It will be resolved > when Issue 748489 is fixed. > > Bug: 769593 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Ieda9e391117103d91ddad584705173674b3470ae > Reviewed-on: https://chromium-review.googlesource.com/700116 > Reviewed-by: Naoki Fukino <fukino@chromium.org> > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#507616} TBR=fukino@chromium.org,yamaguchi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 769593 Change-Id: Ieb1442e647ff5db03433438b8eb3338276e98853 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/718217 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#508678} [modify] https://crrev.com/bc19783572cb7a575421da6a2b67fb54abef0d75/ui/file_manager/file_manager/foreground/elements/files_tooltip.js [modify] https://crrev.com/bc19783572cb7a575421da6a2b67fb54abef0d75/ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.js
,
Oct 13 2017
I have reverted the fix as it caused regression crbug/774380. Reopening the bug.
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1e1d8b4c863bd447d75b4c8ecc4ff638b392280 commit a1e1d8b4c863bd447d75b4c8ecc4ff638b392280 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Tue Oct 17 01:33:19 2017 Revert "Do not show tooltip when focus moved as a result of mouse operation." This reverts commit 10a97df6559061ad5b81e9be7b59dd616fb44fe0. Reason for revert: It caused regression crbug/774380 Original change's description: > Do not show tooltip when focus moved as a result of mouse operation. > > Focus is also moved a menu-button after executing or dismissing menu > by mouse/touch. In such case we should not show the tooltip unlike when > manually focusing it by keyboard. > > As a side effect, tooltip will not appear when focusing by keyboard > when button focus is made invisible by Issue 748489 . It will be resolved > when Issue 748489 is fixed. > > Bug: 769593 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Ieda9e391117103d91ddad584705173674b3470ae > Reviewed-on: https://chromium-review.googlesource.com/700116 > Reviewed-by: Naoki Fukino <fukino@chromium.org> > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#507616} TBR=fukino@chromium.org,yamaguchi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 769593 Change-Id: Ieb1442e647ff5db03433438b8eb3338276e98853 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/718217 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508678}(cherry picked from commit bc19783572cb7a575421da6a2b67fb54abef0d75) Reviewed-on: https://chromium-review.googlesource.com/722459 Cr-Commit-Position: refs/branch-heads/3239@{#24} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/a1e1d8b4c863bd447d75b4c8ecc4ff638b392280/ui/file_manager/file_manager/foreground/elements/files_tooltip.js [modify] https://crrev.com/a1e1d8b4c863bd447d75b4c8ecc4ff638b392280/ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.js
,
Dec 5 2017
,
Dec 6 2017
This is not happening on ToT. - 65.0.3282.0 kevin repro. - 65.0.3286.0 kevin no repro. Marking as WontFix. There is a logic to stop showing a tooltip (reset hovering timer) upon mousedown on anywhere in the document. https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/elements/files_tooltip.js?type=cs&q=file:files_tooltip.js+onDocumentMouseDown_&sq=package:chromium&l=228 However it seems the event was consumed somewhere else by some of the recent changes. We'd need a browser test to avoid such regression in a longer term.
,
Dec 6 2017
Looks like #12 was a mistake. I've verified again and reproduced on 65.0.3286.0 and 65.0.3287.0 on kevin.
,
Dec 8 2017
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3104225e0398bcf5655ce9ff909c8da4db2f68e7 commit 3104225e0398bcf5655ce9ff909c8da4db2f68e7 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Tue Dec 12 04:17:58 2017 Keep focus on the original place when closing menu by mouse or touchscreen. This will also affect other UI elements derived from cr.ui.MenuButton like: - Combo Button - Context Menu Button The UI elements are also referred in other places than the Files app. - "Apps" menu in login screen - media control UI in the video player - Bookmark Manager The button is made not to steal the focus when clicking it to open menu, https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/menu_button.js?q=file:menu_button.js+stealing+focus&sq=package:chromium&dr&l=139 however, it had taken focus when the menu item is activated by a click. It made the focus left on the button after finishing operation on a button using either mouse or touchscreen, requiring MenuButton class to hide that focus highlight by attaching "using-mouse" class attribute. Test: browser_tests --gtest_filter=WebUIResourceBrowserTest.MenuButtonTest* Bug: 771024 , 769593 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I23fb1b0ce907a21407ffca514032bfdc083e36de Reviewed-on: https://chromium-review.googlesource.com/816376 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523331} [modify] https://crrev.com/3104225e0398bcf5655ce9ff909c8da4db2f68e7/chrome/test/data/webui/menu_button_test.html [modify] https://crrev.com/3104225e0398bcf5655ce9ff909c8da4db2f68e7/chrome/test/data/webui/webui_resource_browsertest.cc [modify] https://crrev.com/3104225e0398bcf5655ce9ff909c8da4db2f68e7/ui/webui/resources/js/cr/ui/menu_button.js
,
Dec 18 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by yamaguchi@chromium.org
, Sep 28 2017