New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 769579 link

Starred by 1 user
Status: Fixed
Owner:
erikc...@chromium.org
Closed: Nov 2017
Cc:
█ ajwong@chromium.org
etienneb@chromium.org
█ brettw@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

OOP HP: Improvements to integration with chrome://tracing

Project Member Reported by erikc...@chromium.org, Sep 28 2017 
The main problem is that the browser process is requesting a heap dump for every process on the system...which in turn causes that many global vm_region dumps to be requested, and all of those allocations in turn need to be memory-profiled, thus stalling the system.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecc1021b293738ffcabc4c049379b40959f1a512

commit ecc1021b293738ffcabc4c049379b40959f1a512
Author: Erik Chen <erikchen@chromium.org>
Date: Mon Oct 02 23:08:45 2017

Clean up memory dumps for out of process heap profiling.

This CL has consists of several small changes:
  * The browser process now asks the profiling service to dump all profiled
  processes. Previously, the browser process was incorrectly iterating through
  all processes on the system and requesting dumps.
  * The profiling service now only requests a single global vm_regions dump from
  the memory_instrumentation interface.
  * The browser process now emits the results with the correct dump guid and
  pid.

Bug:  769579 
Change-Id: I67778d806729df1fe7c2d82a27a2cf4cf6b62745
Reviewed-on: https://chromium-review.googlesource.com/688717
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505840}
[modify] https://crrev.com/ecc1021b293738ffcabc4c049379b40959f1a512/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/ecc1021b293738ffcabc4c049379b40959f1a512/base/trace_event/memory_dump_request_args.h
[modify] https://crrev.com/ecc1021b293738ffcabc4c049379b40959f1a512/chrome/browser/profiling_host/profiling_process_host.cc
[modify] https://crrev.com/ecc1021b293738ffcabc4c049379b40959f1a512/chrome/browser/profiling_host/profiling_process_host.h
[modify] https://crrev.com/ecc1021b293738ffcabc4c049379b40959f1a512/chrome/common/profiling/memlog.mojom
[modify] https://crrev.com/ecc1021b293738ffcabc4c049379b40959f1a512/chrome/profiling/memlog_connection_manager.cc
[modify] https://crrev.com/ecc1021b293738ffcabc4c049379b40959f1a512/chrome/profiling/memlog_connection_manager.h
[modify] https://crrev.com/ecc1021b293738ffcabc4c049379b40959f1a512/chrome/profiling/memlog_impl.cc
[modify] https://crrev.com/ecc1021b293738ffcabc4c049379b40959f1a512/chrome/profiling/memlog_impl.h

Comment 2 by erikc...@chromium.org, Nov 17 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment