New issue
Advanced search Search tips

Issue 769577 link

Starred by 0 users
Status: Fixed
Owner:
nhiroki@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Merge InProcessWorker* classes into DedicatedWorker* classes

Project Member Reported by nhiroki@chromium.org, Sep 28 2017 
InProcessWorker* classes (e.g., InProcessWorkerMessaginProxy) were used for sharing implementation among DedicatedWorker and CompositorWorker, but CompositorWorker was removed ( issue 746212 ) in favor of AnimationWorklet. To simplify the code base, let's merge InProcessWorker* classes into DedicatedWorker*.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5738043de6fdc66517cbb09e98da8c4aa76be6c2

commit 5738043de6fdc66517cbb09e98da8c4aa76be6c2
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Sep 28 13:34:02 2017

Worker: Merge InProcessWorkerMessagingProxy into DedicatedWorkerMessagingProxy

This CL merges InProcessWorkerMessagingProxy into DedicatedWorkerMessagingProxy
because DedicatedWorkerMessagingProxy is the only subclass of the
InProcessWorkerMessagingProxy after CompositorWorkerMessagingProxy was
removed[1].

Before this CL:
  - ThreadedMessagingProxyBase
    - InProcessWorkerMessagingProxy
      - DedicatedWorkerMessagingProxy
      - (CompositorWorkerMessagingProxy)  <= Removed by the previous CL
    - ThreadedWorkletMessagingProxy
      - AnimationWorkletMessagingProxy
      - AudioWorkletMessagingProxy

After this CL:
  - ThreadedMessagingProxyBase
    - DedicatedWorkerMessagingProxy
    - ThreadedWorkletMessagingProxy
      - AnimationWorkletMessagingProxy
      - AudioWorkletMessagingProxy

[1] https://chromium-review.googlesource.com/c/chromium/src/+/673484

Bug:  769577 
Change-Id: I011136db5f7951fe12cfb6f6d0c411b1027fb274
Reviewed-on: https://chromium-review.googlesource.com/688116
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505001}
[modify] https://crrev.com/5738043de6fdc66517cbb09e98da8c4aa76be6c2/third_party/WebKit/Source/core/leak_detector/BlinkLeakDetector.cpp
[modify] https://crrev.com/5738043de6fdc66517cbb09e98da8c4aa76be6c2/third_party/WebKit/Source/core/workers/BUILD.gn
[modify] https://crrev.com/5738043de6fdc66517cbb09e98da8c4aa76be6c2/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp
[modify] https://crrev.com/5738043de6fdc66517cbb09e98da8c4aa76be6c2/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h
[modify] https://crrev.com/5738043de6fdc66517cbb09e98da8c4aa76be6c2/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/5738043de6fdc66517cbb09e98da8c4aa76be6c2/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/5738043de6fdc66517cbb09e98da8c4aa76be6c2/third_party/WebKit/Source/core/workers/InProcessWorkerBase.h
[delete] https://crrev.com/576ba67bd34df37d4892a20f36f18da85a84598b/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[delete] https://crrev.com/576ba67bd34df37d4892a20f36f18da85a84598b/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/5738043de6fdc66517cbb09e98da8c4aa76be6c2/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[modify] https://crrev.com/5738043de6fdc66517cbb09e98da8c4aa76be6c2/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
[modify] https://crrev.com/5738043de6fdc66517cbb09e98da8c4aa76be6c2/third_party/WebKit/Source/core/workers/Worker.cpp
[modify] https://crrev.com/5738043de6fdc66517cbb09e98da8c4aa76be6c2/third_party/WebKit/Source/core/workers/Worker.h
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f

commit e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Oct 02 11:49:18 2017

Worker: Rename InProcessWorkerObjectProxy to DedicatedWorkerObjectProxy

This CL renames InProcessWorkerObjectProxy to DedicatedWorkerObjectProxy. This
doesn't change any existing behavior.

InProcessWorkerObjectProxy was used by DedicatedWorker and CompositorWorker, but
CompositorWorker was removed[1] and now it's used only by DedicatedWorker.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/673484

Bug:  769577 
Change-Id: Ia01dd4482c53ef8fef713e8a9e6c2ce92f9ddae2
Reviewed-on: https://chromium-review.googlesource.com/690416
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505582}
[modify] https://crrev.com/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f/third_party/WebKit/Source/core/workers/BUILD.gn
[modify] https://crrev.com/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp
[modify] https://crrev.com/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.h
[modify] https://crrev.com/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp
[modify] https://crrev.com/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h
[rename] https://crrev.com/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f/third_party/WebKit/Source/core/workers/DedicatedWorkerObjectProxy.cpp
[rename] https://crrev.com/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f/third_party/WebKit/Source/core/workers/DedicatedWorkerObjectProxy.h
[modify] https://crrev.com/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp
[modify] https://crrev.com/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h
[modify] https://crrev.com/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f/third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.h
[modify] https://crrev.com/e0ae6ec9863fd63aa8a769ec89a5b1de9013fd0f/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6acfae4ebc774f8346b7601a0d57ce82df696e53

commit 6acfae4ebc774f8346b7601a0d57ce82df696e53
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Tue Oct 03 08:50:56 2017

Worker: Merge Worker and InProcessWorkerBase into DedicatedWorker

InProcessWorkerBase was used for sharing implementation among DedicatedWorker
and CompositorWorker, but CompositorWorker was removed[1] and now "Worker" class
is the only subclass of InProcessWorkerBase.

To simplify the code base, this CL merges Worker and InProcessWorkerBase into
DedicatedWorker. This doesn't change any existing behavior.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/673484

Bug:  769577 
Change-Id: I6dae4cf34db413abcf79383cdabb04529fedef73
Reviewed-on: https://chromium-review.googlesource.com/690417
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505987}
[modify] https://crrev.com/6acfae4ebc774f8346b7601a0d57ce82df696e53/third_party/WebKit/Source/core/workers/AbstractWorker.h
[modify] https://crrev.com/6acfae4ebc774f8346b7601a0d57ce82df696e53/third_party/WebKit/Source/core/workers/BUILD.gn
[add] https://crrev.com/6acfae4ebc774f8346b7601a0d57ce82df696e53/third_party/WebKit/Source/core/workers/DedicatedWorker.cpp
[add] https://crrev.com/6acfae4ebc774f8346b7601a0d57ce82df696e53/third_party/WebKit/Source/core/workers/DedicatedWorker.h
[modify] https://crrev.com/6acfae4ebc774f8346b7601a0d57ce82df696e53/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp
[modify] https://crrev.com/6acfae4ebc774f8346b7601a0d57ce82df696e53/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h
[modify] https://crrev.com/6acfae4ebc774f8346b7601a0d57ce82df696e53/third_party/WebKit/Source/core/workers/DedicatedWorkerObjectProxy.h
[delete] https://crrev.com/e685bb01d1ed700492cda24ef85615a21820a0ac/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[delete] https://crrev.com/e685bb01d1ed700492cda24ef85615a21820a0ac/third_party/WebKit/Source/core/workers/InProcessWorkerBase.h
[modify] https://crrev.com/6acfae4ebc774f8346b7601a0d57ce82df696e53/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h
[modify] https://crrev.com/6acfae4ebc774f8346b7601a0d57ce82df696e53/third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.h
[delete] https://crrev.com/e685bb01d1ed700492cda24ef85615a21820a0ac/third_party/WebKit/Source/core/workers/Worker.cpp
[delete] https://crrev.com/e685bb01d1ed700492cda24ef85615a21820a0ac/third_party/WebKit/Source/core/workers/Worker.h
[modify] https://crrev.com/6acfae4ebc774f8346b7601a0d57ce82df696e53/third_party/WebKit/Source/core/workers/Worker.idl
[modify] https://crrev.com/6acfae4ebc774f8346b7601a0d57ce82df696e53/third_party/WebKit/Source/modules/ModulesInitializer.cpp

Comment 4 by nhiroki@chromium.org, Oct 3 2017

Labels: M-63
Status: Fixed (was: Assigned)
►

Sign in to add a comment