MD Extensions: UI to add a shortcut is not intuitive |
|||||
Issue descriptionRepro steps: 1) Try to add a shortcut for some extension, by pressing any button besides the "Ctrl" key 2) Observe an "invalid" entry in the text field, with no error indication. 3) Try to delete it with backspace (does not work). 4) The only thing that works is "ctrl" + <key>. I used this UI without knowing anything about it and was very confused. Some suggestions (open to discussion) - User should be guided with a more appropriate placeholder text. - Errors should trigger the familiar (red underline + message) UI, instead of an "invalid" text.
,
Oct 25 2017
,
Oct 25 2017
From discussion with @bettes: - Add instructions at top of page (outside of card): “Shortcuts must start with Ctrl or Alt” (note: may differ per platform) - Show a proper error (red underline) instead of current "invalid" string - Hide blinking cursor
,
Oct 25 2017
,
Oct 25 2017
,
Oct 31 2017
Whoops, I didn't unmark this Started when I switched to something else, really starting this now.
,
Oct 31 2017
fyi: shortcuts may not start with both ctrl and alt - maybe we should craft a message that reflects that as well. Maybe, "Include either Ctrl or Alt".
,
Oct 31 2017
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7a877cda5f5fc31bd156c029fdffa47045150e1 commit e7a877cda5f5fc31bd156c029fdffa47045150e1 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Nov 01 20:45:28 2017 [MD extensions] shortcuts instructions and feedback This CL provides a line of instructions for creating extensions shortcuts. It also adds interactive feedback during shortcut entry. Bug: 769576 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I419cb1f4e3ee63aa47fc56ca784faa5ec9f2fdb6 Reviewed-on: https://chromium-review.googlesource.com/748082 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#513256} [modify] https://crrev.com/e7a877cda5f5fc31bd156c029fdffa47045150e1/chrome/app/md_extensions_strings.grdp [modify] https://crrev.com/e7a877cda5f5fc31bd156c029fdffa47045150e1/chrome/browser/resources/md_extensions/keyboard_shortcuts.html [modify] https://crrev.com/e7a877cda5f5fc31bd156c029fdffa47045150e1/chrome/browser/resources/md_extensions/shortcut_input.html [modify] https://crrev.com/e7a877cda5f5fc31bd156c029fdffa47045150e1/chrome/browser/resources/md_extensions/shortcut_input.js [modify] https://crrev.com/e7a877cda5f5fc31bd156c029fdffa47045150e1/chrome/browser/ui/webui/extensions/extensions_ui.cc [modify] https://crrev.com/e7a877cda5f5fc31bd156c029fdffa47045150e1/chrome/test/data/webui/extensions/extension_shortcut_input_test.js
,
Nov 1 2017
We're going to hold off on the > - Hide blinking cursor part of this. (A new bug will be made if that is necessary). |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by scottchen@chromium.org
, Oct 17 2017Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)