MD Extensions: Runtime error thrown when turning on developer mode |
||
Issue description
Repro steps
1) Go to the apps page from the side nav
2) Turn on developer mode from the toolbar
Actual: Runtime error thrown in console.
Expected: No error should happen
iron-list-extracted.js:1314 Uncaught TypeError: <item> should be a valid item
at HTMLElement._getNormalizedItem (iron-list-extracted.js:1314)
at HTMLElement.updateSizeForItem (iron-list-extracted.js:1449)
at HTMLElement.itemSizeChanged_ (item_list.js:44)
at HTMLElement.handler (polymer-extracted.js:491)
at HTMLElement.fire (polymer-extracted.js:1268)
at HTMLElement.observeIdVisibility_ (item.js:103)
at HTMLElement._complexObserverEffect (polymer-extracted.js:1597)
at HTMLElement._effectEffects (polymer-extracted.js:1432)
at HTMLElement._propertySetter (polymer-extracted.js:1416)
at TemplateInstance.__setProperty [as __setPropertyOrig] (polymer-extracted.js:1425)
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e23302a784a208b27c10bd6369278ff8fc908720 commit e23302a784a208b27c10bd6369278ff8fc908720 Author: Scott Chen <scottchen@chromium.org> Date: Mon Oct 09 21:06:51 2017 MD Extensions: use CSS grid instead of iron-list for item-lists. This fixes various bug for item-list rendering, and slightly increases performance for window or item resizing. This CL also added a restriction of maximun 3 columns for the grid, whereas iron-list was rendering as many as it could fit on the same row. As a side effect of removing iron-list, we're no longer doing lazy-loading for large lists. Testing with 80 elements, this approach still has a faster first-useful-paint load-time than iron-list. However, scrolling does use slightly more CPU than iron-list. Both have the same CPU usage when resizing. Bug: 769863 , 769573 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib74a5b5e132dd5473ae4a8ca176dddc5946c4db4 Reviewed-on: https://chromium-review.googlesource.com/693407 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#507486} [modify] https://crrev.com/e23302a784a208b27c10bd6369278ff8fc908720/chrome/browser/resources/md_extensions/compiled_resources2.gyp [modify] https://crrev.com/e23302a784a208b27c10bd6369278ff8fc908720/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/e23302a784a208b27c10bd6369278ff8fc908720/chrome/browser/resources/md_extensions/item.js [modify] https://crrev.com/e23302a784a208b27c10bd6369278ff8fc908720/chrome/browser/resources/md_extensions/item_list.html [modify] https://crrev.com/e23302a784a208b27c10bd6369278ff8fc908720/chrome/browser/resources/md_extensions/item_list.js [modify] https://crrev.com/e23302a784a208b27c10bd6369278ff8fc908720/chrome/browser/resources/md_extensions/manager.js [modify] https://crrev.com/e23302a784a208b27c10bd6369278ff8fc908720/chrome/test/data/webui/extensions/extension_item_list_test.js [modify] https://crrev.com/e23302a784a208b27c10bd6369278ff8fc908720/ui/webui/resources/cr_elements/cr_container_shadow_behavior.js
,
Oct 9 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by scottchen@chromium.org
, Sep 29 2017Status: Started (was: Available)