New issue
Advanced search Search tips

Issue 769549 link

Starred by 1 user
Status: Fixed
Owner:
mattm@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: 2017-10-13
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

clean up use_byte_certs and related code

Project Member Reported by mattm@chromium.org, Sep 27 2017 
Following from   issue 671420  , there are some remnants that still need to be cleaned up:
✓ Remove x509_certificate_nss and related code.
✓ Merge x509_certificate.cc and x509_certificate_bytes.cc.
✓ Remove USE_BYTE_CERTS define and use_byte_certs gn flag.
✓ Remove OSCertHandle typedef.
✓ Make X509Certificate use scoped types for CRYPTO_BUFFER ownership.
✓ Clean up unnecessary string copies of the DER cert data (ex: GetDEREncoded method)
✓ ParseCertificateSandboxed can probably be replaced with X509Certificate now.

Since the last platforms for use_byte_certs were switched on in M63, I guess wait until after M63 has branched to start this.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba33e86ae281c644037c93f1581e2b46a3fc8cc8

commit ba33e86ae281c644037c93f1581e2b46a3fc8cc8
Author: Matt Mueller <mattm@chromium.org>
Date: Thu Sep 28 20:15:52 2017

Update SSLClientSocketImpl comment for ERR_SSL_SERVER_CERT_BAD_FORMAT case

With use_byte_certs, creating an X509Certificate does not use the
platform certificate implementation.

Bug:  769549 
Change-Id: I23d7871ee3d3f52f72e2293c60cd231d658a2845
Reviewed-on: https://chromium-review.googlesource.com/690780
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505131}
[modify] https://crrev.com/ba33e86ae281c644037c93f1581e2b46a3fc8cc8/net/socket/ssl_client_socket_impl.cc

Comment 2 by monor...@bugs.chromium.org, Oct 13 2017 

The NextAction date has arrived: 2017-10-13

Comment 3 by mattm@chromium.org, Oct 27 2017

Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/233e451723f38dff807ff0ccc5c560ff19c4ddd4

commit 233e451723f38dff807ff0ccc5c560ff19c4ddd4
Author: Matt Mueller <mattm@chromium.org>
Date: Fri Oct 27 18:27:41 2017

Remove use_byte_certs buildflag and x509_certificate_nss code.

Bug:  769549 
Change-Id: I2b6064bed9a530b46653094e7ddfa201c5b55e8c
Reviewed-on: https://chromium-review.googlesource.com/741551
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512246}
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/BUILD.gn
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/cert/cert_verify_proc_unittest.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/cert/x509_cert_types.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/cert/x509_cert_types.h
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/cert/x509_cert_types_unittest.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/cert/x509_certificate.h
[delete] https://crrev.com/daf3a31611a0e4d7d4d4df164933bf07862a83c2/net/cert/x509_certificate_nss.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/cert/x509_certificate_unittest.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/cert/x509_util.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/cert/x509_util_nss.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/cert/x509_util_nss_unittest.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/http/transport_security_state.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/ssl/client_cert_store_nss.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/ssl/openssl_ssl_util.cc
[modify] https://crrev.com/233e451723f38dff807ff0ccc5c560ff19c4ddd4/net/third_party/nss/ssl/cmpcert.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec89b74dcb075935db64d37fd869e07650f48e2a

commit ec89b74dcb075935db64d37fd869e07650f48e2a
Author: Matt Mueller <mattm@chromium.org>
Date: Tue Oct 31 02:01:30 2017

Merge net/cert/x509_certificate_bytes.cc into x509_certificate.cc

Bug:  769549 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If025a1309f3c4c14ce5f54f5454f8e1307220bd2
Reviewed-on: https://chromium-review.googlesource.com/745222
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512717}
[modify] https://crrev.com/ec89b74dcb075935db64d37fd869e07650f48e2a/net/BUILD.gn
[modify] https://crrev.com/ec89b74dcb075935db64d37fd869e07650f48e2a/net/cert/x509_certificate.cc
[delete] https://crrev.com/67b9397be98e2a87643584013dee61417c5e45b2/net/cert/x509_certificate_bytes.cc

Comment 6 by mattm@chromium.org, Oct 31 2017

Description: Show this description
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/297c20267bfdb9191b7955ecd81303a61f737201

commit 297c20267bfdb9191b7955ecd81303a61f737201
Author: Matt Mueller <mattm@chromium.org>
Date: Wed Nov 08 00:44:48 2017

make net::X509Certificate::CalculateChainFingerprint256 method non-static

Also remove CalculateCAFingerprint256 method which was only used internally.

Bug:  769549 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3635aed59ea99a0dc595f8d4872ce15378a4dd83
Reviewed-on: https://chromium-review.googlesource.com/748263
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514679}
[modify] https://crrev.com/297c20267bfdb9191b7955ecd81303a61f737201/android_webview/browser/aw_ssl_host_state_delegate.cc
[modify] https://crrev.com/297c20267bfdb9191b7955ecd81303a61f737201/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc
[modify] https://crrev.com/297c20267bfdb9191b7955ecd81303a61f737201/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/297c20267bfdb9191b7955ecd81303a61f737201/ios/web/net/cert_host_pair.cc
[modify] https://crrev.com/297c20267bfdb9191b7955ecd81303a61f737201/ios/web/net/cert_policy.cc
[modify] https://crrev.com/297c20267bfdb9191b7955ecd81303a61f737201/net/cert/x509_certificate.cc
[modify] https://crrev.com/297c20267bfdb9191b7955ecd81303a61f737201/net/cert/x509_certificate.h
[modify] https://crrev.com/297c20267bfdb9191b7955ecd81303a61f737201/net/cert/x509_certificate_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dc37d6668fb4371d0974d06fa2b30aea3c0d5fe

commit 0dc37d6668fb4371d0974d06fa2b30aea3c0d5fe
Author: Matt Mueller <mattm@chromium.org>
Date: Thu Nov 16 04:29:46 2017

Cleanup instances of weird pattern for getting cert chain as a vector of strings.

Also adds x509_util::CryptoBufferAsStringPiece as a more efficient replacement for X509Certificate::GetDEREncoded.

Bug:  769549 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4c548dc67ee89ce29f7343a0031d7add5bf16d65
Reviewed-on: https://chromium-review.googlesource.com/762191
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Moe Ahmadi (slow) <mahmadi@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516984}
[modify] https://crrev.com/0dc37d6668fb4371d0974d06fa2b30aea3c0d5fe/chrome/browser/ui/android/page_info/certificate_chain_helper.cc
[modify] https://crrev.com/0dc37d6668fb4371d0974d06fa2b30aea3c0d5fe/ios/chrome/browser/payments/ios_payment_instrument_launcher.mm
[modify] https://crrev.com/0dc37d6668fb4371d0974d06fa2b30aea3c0d5fe/net/cert/cert_verify_proc_android.cc
[modify] https://crrev.com/0dc37d6668fb4371d0974d06fa2b30aea3c0d5fe/net/cert/x509_util.cc
[modify] https://crrev.com/0dc37d6668fb4371d0974d06fa2b30aea3c0d5fe/net/cert/x509_util.h
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4193270b51780e7f1146766cfcc232ea2a971fe

commit a4193270b51780e7f1146766cfcc232ea2a971fe
Author: Matt Mueller <mattm@chromium.org>
Date: Thu Dec 07 00:23:34 2017

Remove OSCertHandle typedefs, use smart pointers for CRYPTO_BUFFER ownership.

Also renames / removes some X509Certificate methods to make more sense
in the use_byte_certs world:

os_cert_handle() -> cert_buffer()
GetIntermediateCertificates() -> intermediate_buffers()
CreateFromHandle() -> CreateFromBuffer()
CreateOSCertHandleFromBytes() -> CreateCertBufferFromBytes()
CreateOSCertHandlesFromBytes() -> CreateCertBuffersFromBytes()
GetDEREncoded() -> x509_util::CryptoBufferAsStringPiece()
IsSameOSCert() -> x509_util::CryptoBufferEqual()
DupOSCertHandle() -> x509_util::DupCryptoBuffer()
FreeOSCertHandle() -> N/A (everything uses bssl::UniquePtr<CRYPTO_BUFFER>)

Bug:  769549 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5d94158ea5e7ba5e9e3b9f2f5e76221564c9683b
Reviewed-on: https://chromium-review.googlesource.com/775540
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522269}
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/android_webview/browser/aw_contents.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/android_webview/browser/aw_contents_client_bridge.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/chromeos/arc/enterprise/arc_cert_store_bridge.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/chromeos/arc/enterprise/arc_cert_store_bridge_browsertest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/chromeos/certificate_provider/thread_safe_certificate_map.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/chromeos/net/cert_verify_proc_chromeos_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/chromeos/platform_keys/platform_keys.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/chromeos/platform_keys/platform_keys_service.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/safe_browsing/download_protection/download_protection_service.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/ssl/ssl_error_handler.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chrome/browser/ui/android/page_info/certificate_chain_helper.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/chromeos/network/client_cert_resolver.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/components/cast_channel/cast_auth_util.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/components/cronet/android/cert/cert_verifier_cache_serializer.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/components/cronet/android/cert/cert_verifier_cache_serializer_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/components/cronet/android/test/mock_cert_verifier.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/components/cronet/ios/test/cronet_test_base.mm
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/components/ssl_errors/error_classification.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/content/browser/devtools/protocol/security_handler.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/content/browser/renderer_host/pepper/pepper_socket_utils.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/content/public/network/ignore_errors_cert_verifier.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/content/public/network/ignore_errors_cert_verifier_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/ios/chrome/browser/payments/ios_payment_instrument_launcher.mm
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/ios/web/net/crw_cert_verification_controller.mm
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/ios/web/net/crw_cert_verification_controller_unittest.mm
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/ios/web/public/crw_session_certificate_policy_cache_storage.mm
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/ios/web/public/crw_session_certificate_policy_cache_storage_unittest.mm
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/caching_cert_verifier_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/cert_verifier.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/cert_verifier_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/cert_verify_proc.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/cert_verify_proc_android.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/cert_verify_proc_android_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/cert_verify_proc_builtin.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/cert_verify_proc_mac.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/cert_verify_proc_mac_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/cert_verify_proc_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/cert_verify_result.h
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/crl_set_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/ct_objects_extractor.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/ct_objects_extractor.h
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/ct_objects_extractor_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/internal/system_trust_store.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/internal/trust_store_mac.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/internal/trust_store_mac_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/merkle_tree_leaf.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/merkle_tree_leaf_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/multi_log_ct_verifier.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/nss_cert_database_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/test_root_certs_android.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/test_root_certs_fuchsia.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/test_root_certs_mac.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/test_root_certs_win.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/x509_certificate.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/x509_certificate.h
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/x509_certificate_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/x509_util.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/x509_util.h
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/x509_util_ios.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/x509_util_ios_and_mac.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/x509_util_ios_and_mac_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/x509_util_mac.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/x509_util_nss.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/x509_util_nss_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/cert/x509_util_win.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/http/transport_security_state_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/quic/chromium/crypto/proof_source_chromium.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/quic/chromium/crypto/proof_verifier_chromium.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/quic/chromium/crypto/proof_verifier_chromium_test.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/quic/chromium/quic_stream_factory_peer.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/socket/ssl_server_socket_impl.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/ssl/client_cert_identity.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/ssl/client_cert_identity.h
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/ssl/client_cert_store_mac.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/ssl/client_cert_store_nss.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/ssl/client_cert_store_nss_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/ssl/client_cert_store_unittest-inl.h
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/ssl/client_cert_store_win.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/ssl/openssl_ssl_util.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/ssl/ssl_platform_key_util.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/test/cert_test_util.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/third_party/nss/ssl/cmpcert.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/tools/cert_verify_tool/verify_using_cert_verify_proc.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/a4193270b51780e7f1146766cfcc232ea2a971fe/remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ff29573457ad07f198126582e3a22d39de8f041

commit 1ff29573457ad07f198126582e3a22d39de8f041
Author: Matt Mueller <mattm@chromium.org>
Date: Fri Dec 08 21:41:03 2017

Delete x509_util::ParseCertificateSandboxed, use X509Certificate in WebURLLoaderImpl

X509Certificate no longer uses any OS certificate handling, so it can
now safely be used in the renderer.

Bug:  769549 
Change-Id: I80081f50006617fe708082a8ac5115e22299c980
Reviewed-on: https://chromium-review.googlesource.com/812959
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522880}
[modify] https://crrev.com/1ff29573457ad07f198126582e3a22d39de8f041/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/1ff29573457ad07f198126582e3a22d39de8f041/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/1ff29573457ad07f198126582e3a22d39de8f041/net/cert/x509_util.cc
[modify] https://crrev.com/1ff29573457ad07f198126582e3a22d39de8f041/net/cert/x509_util.h
[modify] https://crrev.com/1ff29573457ad07f198126582e3a22d39de8f041/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
[modify] https://crrev.com/1ff29573457ad07f198126582e3a22d39de8f041/third_party/WebKit/public/platform/WebURLResponse.h

Comment 11 by mattm@chromium.org, Dec 8 2017

Description: Show this description

Comment 12 by mattm@chromium.org, Dec 8 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment