[CRD iOS] Infinite host layout loop in iOS 9 |
||||
Issue descriptionApp Version: 63.0.3225.0 (ToT) OS: iOS 9.3.2 What steps will reproduce the problem? (1) Connect to a host What is the expected result? Host connects What happens instead? App crashes (due to stack overflow) The [self updateFABConstraintsAnimated:NO] call in viewDidLayoutSubviews and [self layoutIfNeeded] call in updateFABConstraintsAnimated causes an infinite loop. Interestingly this doesn't occur on iOS 11...
,
Sep 27 2017
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d39cc7742f8cd08f9a94815477e114157fa39c30 commit d39cc7742f8cd08f9a94815477e114157fa39c30 Author: Yuwei Huang <yuweih@chromium.org> Date: Thu Sep 28 21:01:41 2017 [CRD iOS] Fixing an infinite layout loop On iOS 9, it seems the [self updateFABConstraintsAnimated:NO] call in viewDidLayoutSubviews and [self layoutIfNeeded] call in updateFABConstraintsAnimated causes an infinite layout loop, which crashes the app right after the HostViewController appears due to stack overflow. This CL fixes this problem by removing the updateFABConstraintsAnimated: call from viewDidLayoutSubviews. Bug: 769533 Change-Id: I311d9168db4bcae097455eb27a908c086de71572 Reviewed-on: https://chromium-review.googlesource.com/687829 Reviewed-by: Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#505152} [modify] https://crrev.com/d39cc7742f8cd08f9a94815477e114157fa39c30/remoting/ios/app/host_view_controller.mm
,
Oct 4 2017
,
Oct 4 2017
FYI Chromium is moving forward to set the minimum deployment target to iOS 10.
,
Nov 3 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yuweih@chromium.org
, Sep 27 2017