New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769529 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Inspect views and toggle options in MD extensions look off

Project Member Reported by rdevlin....@chromium.org, Sep 27 2017

Issue description

See attached screenshot - inspect views should have each entry on a newline and the options should each be on their own line.
 
Selection_397.png
12.6 KB View Download

Comment 1 by dpa...@chromium.org, Oct 10 2017

Cc: dpa...@chromium.org scottchen@chromium.org
 Issue 773153  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d3f6d522526389c0023e16733646e58409e2c12

commit 6d3f6d522526389c0023e16733646e58409e2c12
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Oct 17 02:41:54 2017

MD Extensions: clean up layout for details page.

Bug:  769529 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4b55fe9185c40e93301cae975bad4d56e961667c
Reviewed-on: https://chromium-review.googlesource.com/713952
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509238}
[modify] https://crrev.com/6d3f6d522526389c0023e16733646e58409e2c12/chrome/app/md_extensions_strings.grdp
[modify] https://crrev.com/6d3f6d522526389c0023e16733646e58409e2c12/chrome/browser/resources/md_extensions/detail_view.html

Labels: Needs-Feedback
scottchen@ Could you please provide us the repro steps and sample file/URL where this issue was present to verify at TE end.
Also provide us the expected behaviour for verifying the same.

Thanks..
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4271b6ec6ce5334ca75e236ea7c7f1fedf50cb0

commit c4271b6ec6ce5334ca75e236ea7c7f1fedf50cb0
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Oct 20 23:55:19 2017

MD Extensions: hide inspect-view section when no views inspectable.

Bug:  769529 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie89b6781084179a1d9c0f019605ee7521c52d8d9
Reviewed-on: https://chromium-review.googlesource.com/724163
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510618}
[modify] https://crrev.com/c4271b6ec6ce5334ca75e236ea7c7f1fedf50cb0/chrome/browser/resources/md_extensions/detail_view.html

Status: Fixed (was: Started)
Re-Tested this issue again on Mac OS 10.12.6, Windows 7 and Ubuntu 14.04 on 64.0.3247.0 Chrome version by following the steps mentioned in the merged  issue 773153  and can observe that on clicking the details tab of an extension, all the options are listed in a new line.

Attached is the screen shot for reference.

Could you please check and confirm if the fix is working as intended or no?

Thanks...
769529.png
46.2 KB View Download

Sign in to add a comment