New issue
Advanced search Search tips

Issue 769520 link

Starred by 1 user
Status: Fixed
Owner:
msw@chromium.org
Closed: Sep 2017
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 557406



Sign in to add a comment

mus: Shelf panels items don't minimize/activate correctly.

Project Member Reported by msw@chromium.org, Sep 27 2017 
mus: Shelf panels items don't minimize/activate correctly.

On linux-desktop ChromeOS ToT @ #503942
(1) Run "chrome --mus"
(2) Run an app that shows panels, or download and play an audio file.
(3) Repeatedly (but slowly) click the shelf item for the panel.
Expected: The panel should alternately minimize and unminimize.
Actual: The panel requires two clicks to activate before minimizing.

I have a fix that uses WindowState instead of window util functions.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5b9727f5fc241bf66ff037dec0d0b6f97e30de5

commit b5b9727f5fc241bf66ff037dec0d0b6f97e30de5
Author: Mike Wasserman <msw@chromium.org>
Date: Fri Sep 29 01:27:40 2017

mus: Fix shelf panel item minimize and activate.

Mus WindowTree::SetFocus fails to activate minimized windows.
(The failing condition is that window->IsDrawn() is false)

Add and call ::wm::ActivationChangeObserver::OnWindowActivating.
Use that to unminimize before activating in WorkspaceLayoutManager.
(otherwise, Ash was unminimizing after attempting activation)

Bug:  769520 
Test: See bug.
Change-Id: Id181e463b6f574657e8ccb162ab8a6dfc9b3652c
Reviewed-on: https://chromium-review.googlesource.com/688166
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505242}
[modify] https://crrev.com/b5b9727f5fc241bf66ff037dec0d0b6f97e30de5/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/b5b9727f5fc241bf66ff037dec0d0b6f97e30de5/ash/wm/workspace/workspace_layout_manager.h
[modify] https://crrev.com/b5b9727f5fc241bf66ff037dec0d0b6f97e30de5/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/b5b9727f5fc241bf66ff037dec0d0b6f97e30de5/ui/wm/core/default_activation_client.cc
[modify] https://crrev.com/b5b9727f5fc241bf66ff037dec0d0b6f97e30de5/ui/wm/core/focus_controller.cc
[modify] https://crrev.com/b5b9727f5fc241bf66ff037dec0d0b6f97e30de5/ui/wm/public/activation_change_observer.h

Comment 2 by msw@chromium.org, Sep 29 2017

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment