Quick setting distance from edge of screen in tablet mode should be consistent with clamshell mode |
||||||
Issue descriptionThis is observed in M63 and below. Because we added the overview button to the shelf in tablet mode, quick setting got moved a little to the left as well. This is a regression. See attached images of laptop vs tablet mode.
,
Oct 19 2017
,
Nov 27 2017
,
Dec 26 2017
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/428919da9e6fca97c109fe9f304634133b983c44 commit 428919da9e6fca97c109fe9f304634133b983c44 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jan 10 03:05:34 2018 Anchor system tray bubble to the rightmost on tablet mode. The system tray bubble and notification center tray bubble were not anchored to the rightmost on tablet mode. This CL adds GetSystemTrayAnchor() to StatusAreaWidget and Shelf, and anchor these bubbles to the TrayBackgroundView that is returned by the method. The overview button on the rightmost will be used when tablet mode is enabled. TEST=manual BUG= 769512 Change-Id: I3956b75ee524a31056da3a272c879997b2274e5c Reviewed-on: https://chromium-review.googlesource.com/844053 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#528225} [modify] https://crrev.com/428919da9e6fca97c109fe9f304634133b983c44/ash/shelf/shelf.cc [modify] https://crrev.com/428919da9e6fca97c109fe9f304634133b983c44/ash/shelf/shelf.h [modify] https://crrev.com/428919da9e6fca97c109fe9f304634133b983c44/ash/system/status_area_widget.cc [modify] https://crrev.com/428919da9e6fca97c109fe9f304634133b983c44/ash/system/status_area_widget.h [modify] https://crrev.com/428919da9e6fca97c109fe9f304634133b983c44/ash/system/tray/system_tray.cc [modify] https://crrev.com/428919da9e6fca97c109fe9f304634133b983c44/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/428919da9e6fca97c109fe9f304634133b983c44/ash/system/web_notification/web_notification_tray.h
,
Jan 10 2018
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2b4c722b4a88896050611a0a5542e0cc670c6f8 commit d2b4c722b4a88896050611a0a5542e0cc670c6f8 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jan 10 06:38:01 2018 Revert "Anchor system tray bubble to the rightmost on tablet mode." This reverts commit 428919da9e6fca97c109fe9f304634133b983c44. Reason for revert: Linux Chromium OS ASan LSan Tests failure https://crbug.com/800645 browser_tests: - ChromeNativeAppWindowViewsAuraAshBrowserTest.ImmersiveModeFullscreenRestoreType - ChromeNativeAppWindowViewsAuraAshBrowserTest.ImmersiveWorkFlow unit_tests: - DisplayInfoProviderChromeosTouchviewTest.GetTabletMode ash_unittests : - ScreenRotationAnimatorSmoothAnimationTest.DisplayChangeDuringCopy - ScreenRotationAnimatorSmoothAnimationTest.OverviewButtonTrayHideAnimationAlwaysCompletes - TabletModeControllerTest.ForceTabletModeModeTest Original change's description: > Anchor system tray bubble to the rightmost on tablet mode. > > The system tray bubble and notification center tray bubble were not > anchored to the rightmost on tablet mode. > This CL adds GetSystemTrayAnchor() to StatusAreaWidget and Shelf, > and anchor these bubbles to the TrayBackgroundView that is returned by > the method. > The overview button on the rightmost will be used when tablet mode is > enabled. > > TEST=manual > BUG= 769512 > > Change-Id: I3956b75ee524a31056da3a272c879997b2274e5c > Reviewed-on: https://chromium-review.googlesource.com/844053 > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528225} TBR=jamescook@chromium.org,tetsui@chromium.org Change-Id: Id90b02ccacf28a1a0be32d1f817f207d4c55fc98 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769512 Reviewed-on: https://chromium-review.googlesource.com/859056 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#528251} [modify] https://crrev.com/d2b4c722b4a88896050611a0a5542e0cc670c6f8/ash/shelf/shelf.cc [modify] https://crrev.com/d2b4c722b4a88896050611a0a5542e0cc670c6f8/ash/shelf/shelf.h [modify] https://crrev.com/d2b4c722b4a88896050611a0a5542e0cc670c6f8/ash/system/status_area_widget.cc [modify] https://crrev.com/d2b4c722b4a88896050611a0a5542e0cc670c6f8/ash/system/status_area_widget.h [modify] https://crrev.com/d2b4c722b4a88896050611a0a5542e0cc670c6f8/ash/system/tray/system_tray.cc [modify] https://crrev.com/d2b4c722b4a88896050611a0a5542e0cc670c6f8/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/d2b4c722b4a88896050611a0a5542e0cc670c6f8/ash/system/web_notification/web_notification_tray.h
,
Jan 10 2018
,
Jan 10 2018
,
Jan 12 2018
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/386ce005b1057beb9b86a7cc04201dabf93af81f commit 386ce005b1057beb9b86a7cc04201dabf93af81f Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Jan 12 07:42:08 2018 Reland "Anchor system tray bubble to the rightmost on tablet mode." This is a reland of 428919da9e6fca97c109fe9f304634133b983c44 Change from the original CL: Stopped changing next focusable view of web notification tray depending on whether the device is in tablet mode or not. Original change's description: > Anchor system tray bubble to the rightmost on tablet mode. > > The system tray bubble and notification center tray bubble were not > anchored to the rightmost on tablet mode. > This CL adds GetSystemTrayAnchor() to StatusAreaWidget and Shelf, > and anchor these bubbles to the TrayBackgroundView that is returned by > the method. > The overview button on the rightmost will be used when tablet mode is > enabled. > > TEST=manual > BUG= 769512 > > Change-Id: I3956b75ee524a31056da3a272c879997b2274e5c > Reviewed-on: https://chromium-review.googlesource.com/844053 > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528225} Bug: 769512 Change-Id: I648f60a2dc7067b452461f5d6cf5e25d45037f50 Reviewed-on: https://chromium-review.googlesource.com/861482 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#528904} [modify] https://crrev.com/386ce005b1057beb9b86a7cc04201dabf93af81f/ash/shelf/shelf.cc [modify] https://crrev.com/386ce005b1057beb9b86a7cc04201dabf93af81f/ash/shelf/shelf.h [modify] https://crrev.com/386ce005b1057beb9b86a7cc04201dabf93af81f/ash/system/status_area_widget.cc [modify] https://crrev.com/386ce005b1057beb9b86a7cc04201dabf93af81f/ash/system/status_area_widget.h [modify] https://crrev.com/386ce005b1057beb9b86a7cc04201dabf93af81f/ash/system/tray/system_tray.cc [modify] https://crrev.com/386ce005b1057beb9b86a7cc04201dabf93af81f/ash/system/web_notification/web_notification_tray.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tetsui@chromium.org
, Oct 19 2017Owner: tetsui@chromium.org