New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 769493 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
szager@chromium.org
sriram...@samsung.com
█ satay...@samsung.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 490942



Sign in to add a comment

[root layer scrolls] DragControllerTest failures

Project Member Reported by skobes@chromium.org, Sep 27 2017 
When RootLayerScrolling is marked "stable" in runtime_enabled_features.json5, the following three unit tests fail on Linux:

  DragControllerTest.DragImageForSelectionClipsChildFrameToViewport
  DragControllerTest.DragImageForSelectionClipsChildFrameToViewportWithPageScaleFactor
  DragControllerTest.DragImageForSelectionClipsToViewport

The failures look like this:

../../third_party/WebKit/Source/core/page/DragControllerTest.cpp:268: Failure
      Expected: expected_selection
      Which is: "0,17 30x8"
To be equal to: DragController::ClippedSelection(child_frame)
      Which is: "0,10 30x15"
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53bb1fa412824b4e49a18724ca2b178d998dee02

commit 53bb1fa412824b4e49a18724ca2b178d998dee02
Author: Philip Rogers <pdr@chromium.org>
Date: Tue Oct 03 23:35:12 2017

Make DragControllerTests run with root layer scrolling

These tests now pass with root layer scrolling.

Bug:  769493 
Change-Id: I555ce488df6ed2321093a76b9ef6e0568a09166f
Reviewed-on: https://chromium-review.googlesource.com/699193
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506229}
[modify] https://crrev.com/53bb1fa412824b4e49a18724ca2b178d998dee02/third_party/WebKit/Source/core/page/DragControllerTest.cpp

Comment 2 by pdr@chromium.org, Oct 11 2017

Status: Fixed (was: Available)
►

Sign in to add a comment