New issue
Advanced search Search tips

Issue 769492 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Wallpaper is incorrect at login screen after clicking Add person then Back

Project Member Reported by jamescook@chromium.org, Sep 27 2017

Issue description

Chrome ToT r504699, OS R63-9972, on link

* Have a device with 1 account. Boot to login screen. Wallpaper from user 1 is displayed, with blur.
* Click "Add person". Wallpaper changes to blurred blue.
* Click "Back"

Expected: Wallpaper goes back to user 1
Actual: Wallpaper stays blurry blue

The incorrect wallpaper persists even after login.

This is a regression, it works properly in 61.0.3163.90 beta (on samus).

rkc, can you find an owner for this? (Maybe it's a dupe?)

 

Comment 1 by wzang@chromium.org, Sep 27 2017

Cc: -wzang@chromium.org r...@chromium.org
Owner: wzang@chromium.org

Comment 2 by wzang@chromium.org, Sep 28 2017

I can't reproduce using the same version, I'm using an Eve instead of Link though, but I believe it's unlikely to be device specific? Can you check if you're using an enterprise enrolled account?
Cc: xiy...@chromium.org
This reproduces for me on linux desktop. /w/udd is a user data directory that has a real account in it (jamescooktest1@gmail.com) with real wallpaper.

* out/Default/chrome --ash-host-window-bounds="1024x768" --user-data-dir=/tmp/udd2 --ash-dev-shortcuts --ash-debug-shortcuts --login-manager
* Wallpaper shows
* Click "Add person"
* Wallpaper turns gray
* Click "Back"
* Wallpaper still gray

See screenshots.

(You may have to comment out some DCHECKs to work around a crash in blink, see  issue 769769 . I'm not sure if that problem is related.)


1-with-wallpaper.png
146 KB View Download
2-add-user.png
21.9 KB View Download
3-wallpaper-unchanged.png
30.9 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9088deca286327a07e31e89a984cb330282c3d93

commit 9088deca286327a07e31e89a984cb330282c3d93
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Sep 29 17:39:32 2017

Ensure the correct wallpaper is loaded when Add User screen is closed

If |focusedPod_| is already set, and it is the same with |podToFocus|,
early return is hit in focusPod(), however we should force a focus
update in order to ensure the correct wallpaper is set.

Bug:  769492 
Change-Id: I820a523c863d693663411e436be2baa8b62fa178
Reviewed-on: https://chromium-review.googlesource.com/691046
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505409}
[modify] https://crrev.com/9088deca286327a07e31e89a984cb330282c3d93/ui/login/account_picker/md_user_pod_row.js

Comment 5 by wzang@chromium.org, Sep 29 2017

Status: Fixed (was: Assigned)

Sign in to add a comment