[root layer scrolls] DataTransferTest failures |
|||
Issue description
When RootLayerScrolling is marked "stable" in runtime_enabled_features.json5, the following two unit tests fail on Linux:
DataTransferTest.NodeImageSizeWithPageScaleFactor
DataTransferTest.NodeImageUnderScrollOffset
The failures look like this:
../../third_party/WebKit/Source/core/clipboard/DataTransferTest.cpp:202: Failure
Expected: IntSize(node_width * page_scale_factor, (node_height - scroll_amount) * page_scale_factor)
Which is: "400x262"
To be equal to: image_with_offset->Size()
Which is: "400x282"
../../third_party/WebKit/Source/core/clipboard/DataTransferTest.cpp:164: Failure
Expected: IntSize(500, first_height - scroll_amount)
Which is: "500x490"
To be equal to: first_image->Size()
Which is: "500x500"
,
Sep 28 2017
Use the below command after enabling the RootLayerScrolling in runtime_enabled_features.json5. ./out/Default/webkit_unit_tests -t Default --gtest_filter=DataTransferTest.NodeImageSizeWithPageScaleFactor
,
Sep 28 2017
this test fails due to regression from the below patch https://chromium-review.googlesource.com/c/chromium/src/+/671166 the calculations of device_rect are modified. earlier clip_rect was intersection of css_rect & VisibleRectInDocument() now it is modified to intersection of VisibleRect() * RootFrameToContents()
,
Sep 28 2017
Thanks for the investigation. Philip do you have bandwidth for this one?
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4872f632773a5370b0e22126e28ca6878a1d60c8 commit 4872f632773a5370b0e22126e28ca6878a1d60c8 Author: Philip Rogers <pdr@chromium.org> Date: Mon Oct 02 18:31:46 2017 Make DataTransferTest use RenderingTest DataTransferTest is complex and duplicates logic in RenderingTest. This patch switches the test to use RenderingTest. This lets us remove redundant logic, remove unused variables such as performance_, and will make it easier to write RootLayerScrolling variants of these tests. This is just a cleanup and should have no change in behavior. Bug: 769490 Change-Id: I1c0cad5b943bb0655f12d1363c702f8b8c3bd039 Reviewed-on: https://chromium-review.googlesource.com/692604 Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505686} [modify] https://crrev.com/4872f632773a5370b0e22126e28ca6878a1d60c8/third_party/WebKit/Source/core/clipboard/DataTransferTest.cpp
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9187dc5ec808cf6337f2d8c2ac8357827f32808c commit 9187dc5ec808cf6337f2d8c2ac8357827f32808c Author: pdr <pdr@chromium.org> Date: Tue Oct 03 00:35:20 2017 Make DataTransfer::ClipByVisualViewport RLS-aware With Root Layer Scrolling (RLS), the local frame contents are not scrolled because scrolling is handled by the layout view. This patch updates ClipByVisualViewport to apply the scroll offset itself (for both RLS and !RLS) instead of using RootFrameToContents. Bug: 769490 Change-Id: I3bff26b74f9672882bb8c564067f7e6630bbabf1 Reviewed-on: https://chromium-review.googlesource.com/695720 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505883} [modify] https://crrev.com/9187dc5ec808cf6337f2d8c2ac8357827f32808c/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp [modify] https://crrev.com/9187dc5ec808cf6337f2d8c2ac8357827f32808c/third_party/WebKit/Source/core/clipboard/DataTransferTest.cpp
,
Oct 3 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by suneel.k...@samsung.com
, Sep 28 2017