[root layer scrolls] NGTextFragmentPainterTest failure |
|||
Issue description
When RootLayerScrolling is marked "stable" in runtime_enabled_features.json5, the following unit test fails on Linux:
NGTextFragmentPainterTest.TestTextStyle
The output looks like this:
../../third_party/WebKit/Source/core/paint/ng/ng_text_fragment_painter_test.cc:76: Failure
Expected: &expected[i].Client()
Which is: 0x24b837c04018
To be equal to: &RootPaintController().GetDisplayItemList()[i].Client()
Which is: 0x16edf8bb5418
,
Oct 11 2017
Would you like to put up a patch to fix this Suneel? I think the fix will look very similar to https://chromium-review.googlesource.com/c/chromium/src/+/706108
,
Oct 11 2017
,
Oct 12 2017
Submitted patch https://chromium-review.googlesource.com/c/chromium/src/+/715857
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f2f29778090144dd0c171fe8896082f7d787463 commit 2f2f29778090144dd0c171fe8896082f7d787463 Author: Suneel Kota <suneel.kota@samsung.com> Date: Thu Oct 12 15:47:01 2017 Make RLS versions of NGTextFragmentPainterTest NGTextFragmentPainterTest is useful to test with Root Layer Scrolling (RLS) enabled. This patch adds a RLS version of this test configuration. Fixing the tests to worka with RLS required updating how the background display item client is chosen. Bug: 769489 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I69ef4dc32c4b631e523d6b36f2aca15cc87eb01d Reviewed-on: https://chromium-review.googlesource.com/715857 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#508355} [modify] https://crrev.com/2f2f29778090144dd0c171fe8896082f7d787463/third_party/WebKit/Source/core/paint/ng/ng_text_fragment_painter_test.cc
,
Oct 12 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by suneel.k...@samsung.com
, Oct 11 2017