New issue
Advanced search Search tips

Issue 769477 link

Starred by 1 user
Status: Verified
Owner:
yuweih@chromium.org
Closed: Oct 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[CRD iOS] Swiping before desktop shows up breaks the viewport logic

Project Member Reported by yuweih@chromium.org, Sep 27 2017 
Version: 63.0.3225.0 (ToT)

What steps will reproduce the problem?
(1) Connect to a host
(2) Immediately try to swipe on the screen before the desktop shows up

What is the expected result?

Nothing happens before the desktop shows up. The desktop will later still show up properly.

What happens instead?

The desktop never shows up afterwards.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1314c9312456a558142fa479c98bba8bb8acc63d

commit 1314c9312456a558142fa479c98bba8bb8acc63d
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Sep 28 21:00:25 2017

[CRD iOS] Don't handle gesture when desktop viewport is not ready

The desktop viewport will be used to map some points when handling
gestures. If the viewport is not ready at that time, then we may end up
getting wrong numbers (e.g. NaN) into the InputStrategy. This will
cause subsequent issues in the viewport logic.

This CL fixes this by always checking whether the viewport is ready
before handling the gesture, and adding some DCHECKs to prevent similar
things from happening.

Bug:  769477 
Change-Id: Ied121198559c8d401a66022d2f82663cd0a91dfc
Reviewed-on: https://chromium-review.googlesource.com/688657
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505151}
[modify] https://crrev.com/1314c9312456a558142fa479c98bba8bb8acc63d/remoting/client/gesture_interpreter.cc
[modify] https://crrev.com/1314c9312456a558142fa479c98bba8bb8acc63d/remoting/client/ui/desktop_viewport.cc
[modify] https://crrev.com/1314c9312456a558142fa479c98bba8bb8acc63d/remoting/client/ui/desktop_viewport.h
[modify] https://crrev.com/1314c9312456a558142fa479c98bba8bb8acc63d/remoting/client/ui/view_matrix.cc
[modify] https://crrev.com/1314c9312456a558142fa479c98bba8bb8acc63d/remoting/client/ui/view_matrix.h

Comment 2 by yuweih@chromium.org, Oct 4 2017

Status: Fixed (was: Assigned)

Comment 3 by ajnolley@chromium.org, Nov 9 2017 

Verified Fixed in 34.0.3261.0

Comment 4 by ajnolley@chromium.org, Nov 9 2017

Status: Verified (was: Fixed)
Verified Fixed in 64.0.3261.0
►

Sign in to add a comment