New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769469 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Cannot print to mDNS printer

Project Member Reported by skau@chromium.org, Sep 27 2017

Issue description

Chrome Version: 63
OS: CrOS

What steps will reproduce the problem?
(1) Add a zeroconf printer
(2) Use zeroconf printer to print something
(3) Log out
(4) Log back in
(5) Try to print something else

What is the expected result?
The page prints

What happens instead?
The print job times out.  Problem occurs because CUPS can't resolve the .local hostname so we can't route the print job correctly (or at all).


Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adb0980f878f088970d492185438a3525b177dfc

commit adb0980f878f088970d492185438a3525b177dfc
Author: Sean Kau <skau@chromium.org>
Date: Thu Sep 28 23:26:53 2017

Resolve zeroconf printer IPs in PrinterConfigurer.

It's possible that we have to setup a printer before
ZeroconfPrinterDetector has finished its scan.  Notably, when a printer
is pre-selected in the PrintPreview dialog.  To avoid installing printers
with uris we can't resolve, resolve the IP in configurer.  As a bonus,
we now deselect the printer if it's not immedeately usable.

Bug:  769469 
Change-Id: I96e07edd9a2eaf199f093408bbb6b8cf583fe851
Reviewed-on: https://chromium-review.googlesource.com/688030
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505208}
[modify] https://crrev.com/adb0980f878f088970d492185438a3525b177dfc/chrome/browser/chromeos/printing/printer_configurer.cc
[modify] https://crrev.com/adb0980f878f088970d492185438a3525b177dfc/chromeos/printing/printer_configuration.cc
[modify] https://crrev.com/adb0980f878f088970d492185438a3525b177dfc/chromeos/printing/printer_configuration.h

Comment 2 by skau@chromium.org, Sep 29 2017

Status: Fixed (was: Started)

Comment 3 by skau@chromium.org, Sep 29 2017

Labels: Merge-Request-62 Merge-Request-61
Labels: -Merge-Request-62 Merge-Approved-62
Approved for 62, please verify this CL makes it through the Chrome OS PFQ before merging back.
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61.

Comment 6 by skau@chromium.org, Sep 30 2017

ChromePFQ is struggling.  I'll try to merge tonight or over the weekend when PFQ passes.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 1 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74debd46f1a5c9e2be87ec67ea5678b91ad9d4f1

commit 74debd46f1a5c9e2be87ec67ea5678b91ad9d4f1
Author: Sean Kau <skau@chromium.org>
Date: Sun Oct 01 06:27:23 2017

Resolve zeroconf printer IPs in PrinterConfigurer.

It's possible that we have to setup a printer before
ZeroconfPrinterDetector has finished its scan.  Notably, when a printer
is pre-selected in the PrintPreview dialog.  To avoid installing printers
with uris we can't resolve, resolve the IP in configurer.  As a bonus,
we now deselect the printer if it's not immedeately usable.

TBR=skau@chromium.org

(cherry picked from commit adb0980f878f088970d492185438a3525b177dfc)

Bug:  769469 
Change-Id: I96e07edd9a2eaf199f093408bbb6b8cf583fe851
Reviewed-on: https://chromium-review.googlesource.com/688030
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505208}
Reviewed-on: https://chromium-review.googlesource.com/693965
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#528}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/74debd46f1a5c9e2be87ec67ea5678b91ad9d4f1/chrome/browser/chromeos/printing/printer_configurer.cc
[modify] https://crrev.com/74debd46f1a5c9e2be87ec67ea5678b91ad9d4f1/chromeos/printing/printer_configuration.cc
[modify] https://crrev.com/74debd46f1a5c9e2be87ec67ea5678b91ad9d4f1/chromeos/printing/printer_configuration.h

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 1 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de128d04cfd5bcb87787c67c5de204e3f688ff0c

commit de128d04cfd5bcb87787c67c5de204e3f688ff0c
Author: Sean Kau <skau@chromium.org>
Date: Sun Oct 01 06:29:47 2017

Resolve zeroconf printer IPs in PrinterConfigurer.

It's possible that we have to setup a printer before
ZeroconfPrinterDetector has finished its scan.  Notably, when a printer
is pre-selected in the PrintPreview dialog.  To avoid installing printers
with uris we can't resolve, resolve the IP in configurer.  As a bonus,
we now deselect the printer if it's not immedeately usable.

TBR=skau@chromium.org

(cherry picked from commit adb0980f878f088970d492185438a3525b177dfc)

Bug:  769469 
Change-Id: I96e07edd9a2eaf199f093408bbb6b8cf583fe851
Reviewed-on: https://chromium-review.googlesource.com/688030
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505208}
Reviewed-on: https://chromium-review.googlesource.com/693966
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1298}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/de128d04cfd5bcb87787c67c5de204e3f688ff0c/chrome/browser/chromeos/printing/printer_configurer.cc
[modify] https://crrev.com/de128d04cfd5bcb87787c67c5de204e3f688ff0c/chromeos/printing/printer_configuration.cc
[modify] https://crrev.com/de128d04cfd5bcb87787c67c5de204e3f688ff0c/chromeos/printing/printer_configuration.h

Sign in to add a comment