New issue
Advanced search Search tips

Issue 769467 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

extensions_browsertests failing on chromium.chromiumos/Linux ChromiumOS Tests (1)

Project Member Reported by dmu...@chromium.org, Sep 27 2017

Issue description

extensions_browsertests failing on chromium.chromiumos/Linux ChromiumOS Tests (1)

Builders failed on: 
- Linux ChromiumOS Tests (1): 
  https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29


[ RUN      ] WebViewAPITest.TestDisplayNoneWebviewRemoveChild
DevTools listening on ws://127.0.0.1:57442/devtools/browser/e19a768f-5556-46d8-8527-5cb578390f09
[6445:6445:0927/125500.423260:1614557345:ERROR:proxy_service.cc(1496)] ProxyConfigService for ChromeOS should be created in profile_io_data.cc::CreateProxyConfigService and this should be used only for examples.
../../extensions/browser/guest_view/web_view/web_view_apitest.cc:173: Failure
Value of: done_listener.WaitUntilSatisfied()
  Actual: false
Expected: true
[  FAILED  ] WebViewAPITest.TestDisplayNoneWebviewRemoveChild, where TypeParam =  and GetParam() =  (220 ms)

Cl range: https://chromium.googlesource.com/chromium/src/+log/82741a60c091e28feed56e24bb528b04f9076ae5%5E..3caef7b900b16af22a5eba78a27aef5516011e52?pretty=fuller&n=

failing build:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45111

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45111/steps/extensions_browsertests


 

Comment 2 by dmu...@chromium.org, Sep 27 2017

So flaky test.

Comment 3 by dmu...@chromium.org, Sep 27 2017

Components: Mobile>WebView

Comment 4 by dpa...@chromium.org, Sep 27 2017

FYI looked into https://chromium-review.googlesource.com/#/q/I04e0f81220251cfd3eaab3100b256f13b7f34430, which is within the CL range, and mentions "extensions" in the CL description. I don't see any clear link between the failure and that CL.

The failing test is executing the JS code at [1] and the CL in question is affecting chrome://extensions WebUI page, which I don't see it being triggered by the test. IIUC the test simply adds a webview element with display:none, and then removes it.

[1] https://cs.chromium.org/chromium/src/extensions/test/data/web_view/apitest/main.js?l=631

Comment 5 by dmu...@chromium.org, Sep 27 2017

I chatted with that author too - they didn't see how it could be linked.

It looks like it has been flaky on two bots forever.
Components: -Mobile>WebView
I think you've got the wrong "WebView." This component is for Android WebView [1]. Pass back if I'm mistaken.

[1] https://developer.android.com/reference/android/webkit/WebView.html

Comment 7 by boliu@chromium.org, Sep 27 2017

Components: Platform>Apps>BrowserTag
that one I think

Comment 8 by fsamuel@google.com, Sep 29 2017

Labels: -Sheriff-Chromium
Owner: wjmaclean@chromium.org
Status: Assigned (was: Available)
Since this has been flaky for a while, I'm assigning to wjmaclean@ and removing the sheriff label. Please disable or fix the test.

Comment 9 by glevin@chromium.org, Oct 20 2017

Test is still flaking (though not frequently), most recently on
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45969
I hope to look at this test next week.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/307dc291f2bd4eba41d4c13cdfabfe195bf295ea

commit 307dc291f2bd4eba41d4c13cdfabfe195bf295ea
Author: Trent Apted <tapted@chromium.org>
Date: Mon Oct 23 05:25:03 2017

Disable flaky WebViewAPITest.TestDisplayNoneWebviewRemoveChild

TBR=wjmaclean@chromium.org

No-Try: true
Bug: 769467
Change-Id: Ie8b55e41470065db21d7284bcf4d45dec0150378
Reviewed-on: https://chromium-review.googlesource.com/732801
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510722}
[modify] https://crrev.com/307dc291f2bd4eba41d4c13cdfabfe195bf295ea/extensions/browser/guest_view/web_view/web_view_apitest.cc

There was another flake - https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/63669

Disabled.

CQ is currently busted, so we need as many problems gone as possible to helps sheriffs when it comes back.
Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment