New issue
Advanced search Search tips

Issue 769466 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
szager@chromium.org
pdr@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 490942



Sign in to add a comment

[root layer scrolls] TablePainterTest failures

Project Member Reported by skobes@chromium.org, Sep 27 2017 
When RootLayerScrolling is marked "stable" in runtime_enabled_features.json5, the following unit tests fail on Linux:

  TablePainterTest.Background
  TablePainterTest.BackgroundInSelfPaintingRow
  TablePainterTest.BackgroundWithCellSpacing
  TablePainterTest.CollapsedBorderAndOverflow

The failures look like this:

../../third_party/WebKit/Source/core/paint/TablePainterTest.cpp:42: Failure
      Expected: &expected[i].Client()
      Which is: 0x368065e04018
To be equal to: &RootPaintController().GetDisplayItemList()[i].Client()
      Which is: 0x23e52e5b5418
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1910413c23e0af98a3519f73a62518481cde94b

commit d1910413c23e0af98a3519f73a62518481cde94b
Author: pdr@chromium.org <pdr@chromium.org>
Date: Fri Oct 06 22:37:22 2017

Make RLS versions of TablePainterTest

TablePainterTest is useful to test with Root Layer
Scrolling (RLS) enabled. This patch adds a RLS version
of this test configuration. Fixing the tests to work
with RLS required updating how the background display item
client is chosen.

Bug:  769466 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I967a4754c5b2cb08463e4478f2212bcfbdc8544d
Reviewed-on: https://chromium-review.googlesource.com/706108
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507201}
[modify] https://crrev.com/d1910413c23e0af98a3519f73a62518481cde94b/third_party/WebKit/Source/core/paint/TablePainterTest.cpp

Comment 2 by pdr@chromium.org, Oct 6 2017

Status: Fixed (was: Available)
►

Sign in to add a comment