New issue
Advanced search Search tips

Issue 769465 link

Starred by 1 user
Status: Fixed
Owner:
pdr@chromium.org
Closed: Oct 2017
Cc:
szager@chromium.org
pdr@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 490942



Sign in to add a comment

[root layer scrolls] PaintControllerPaintTest failures

Project Member Reported by skobes@chromium.org, Sep 27 2017 
When RootLayerScrolling is marked "stable" in runtime_enabled_features.json5, the following two unit tests fail on Linux:

  All/PaintControllerPaintTestForSlimmingPaintV1AndV2.FullDocumentPaintingWithCaret/0
  All/PaintControllerPaintTestForSlimmingPaintV1AndV2.InlineRelayout/0

The failures look like this:

../../third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp:47: Failure
      Expected: &expected[i].Client()
      Which is: 0xc7a70204018
To be equal to: &RootPaintController().GetDisplayItemList()[i].Client()
      Which is: 0x1f5813bb5418
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10ec8e6efdd908654e879331d32ac06aab5bbd6e

commit 10ec8e6efdd908654e879331d32ac06aab5bbd6e
Author: Philip Rogers <pdr@chromium.org>
Date: Thu Oct 05 00:50:53 2017

Make RLS versions of PaintControllerPaintTest

PaintControllerPaintTest is useful to test with Root Layer
Scrolling (RLS) enabled. This patch removes the special
test configuration that did not include RLS and runs the
tests with the default paint test configurations which has RLS.

The following tests failed with root layer scrolling and
SPV1: FullDocumentPaintingWithCaret and InlineRelayout.
These failures were due to how the background display
item client works in the SPV1+RLS case, and these tests
have been updated to have different clients in this case.

Bug:  769465 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib2c46aeb57b386635740918c073965257c08f17d
Reviewed-on: https://chromium-review.googlesource.com/699518
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506593}
[modify] https://crrev.com/10ec8e6efdd908654e879331d32ac06aab5bbd6e/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp

Comment 2 by pdr@chromium.org, Oct 5 2017

Owner: pdr@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment