New issue
Advanced search Search tips

Issue 769464 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

SCPaymentsEditorTestCase/testNavigationByTappingReturn is failing on ipad devices

Project Member Reported by liaoyuke@chromium.org, Sep 27 2017

Issue description

this test is flaky on devices, here are examples:

https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad10-device-x64/builds/6963
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad10-device-x64/builds/6962
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad9-device-x64/builds/13276
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad9-device-x64/builds/13275

And here is an example failure log:

SCPaymentsEditorTestCase/testNavigationByTappingReturn: 
../../ios/showcase/payments/sc_payments_editor_egtest.mm:67: error: -[SCPaymentsEditorTestCase testNavigationByTappingReturn] : Exception: AssertionFailedException

Exception Name: AssertionFailedException
Exception Reason: ((([[textField accessibilityIdentifier] isEqualToString:accessibilityID])) is true) failed
Exception Details: Expected accessibility identifier to be City/Province_textField, got Name_textField.

Bundle ID: com.google.ios-showcase-egtests

Stack Trace: (
	0   EarlGrey                            0x000000010485f14c -[GREYDefaultFailureHandler handleException:details:] + 904
	1   ios_showcase_egtests                0x0000000100106d24 _ZN12_GLOBAL__N_150AssertTextFieldWithAccessibilityIDIsFirstResponderEP8NSString + 1692
	2   ios_showcase_egtests                0x00000001001073ac -[SCPaymentsEditorTestCase testNavigationByTappingReturn] + 528
	3   CoreFoundation                      0x000000018167a160 <redacted> + 144
	4   CoreFoundation                      0x000000018156dc3c <redacted> + 284
	5   EarlGrey                            0x000000010484e734 -[GREYTestCaseInvocation invoke] + 92
	6   XCTest                              0x00000001046b00a8 __24-[XCTestCase invokeTest]_block_invoke.275 + 48
	7   XCTest                              0x00000001046afe58 __24-[XCTestCase invokeTest]_block_invoke + 680
	8   XCTest                              0x00000001046f5780 -[XCUITestContext performInScope:] + 208
	9   XCTest                              0x00000001046afba0 -[XCTestCase invokeTest] + 136
	10  EarlGrey                            0x00000001048457d4 -[XCTestCase(GREYAdditions) grey_invokeTest] + 472
	11  XCTest                              0x00000001046b0c78 __26-[XCTestCase performTest:]_block_invoke.382 + 48
	12  XCTest                              0x00000001046fa778 +[XCTContext runInContextForTestCase:block:] + 164
	13  XCTest                              0x00000001046b0674 -[XCTestCase performTest:] + 596
	14  XCTest                              0x00000001046ac868 __27-[XCTestSuite performTest:]_block_invoke + 288
	15  XCTest                              0x00000001046ac290 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 44
	16  XCTest                              0x00000001046ac4a0 -[XCTestSuite performTest:] + 236
	17  XCTest                              0x00000001046ac868 __27-[XCTestSuite performTest:]_block_invoke + 288
	18  XCTest                              0x00000001046ac290 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 44
	19  XCTest                              0x00000001046ac4a0 -[XCTestSuite performTest:] + 236
	20  XCTest                              0x00000001046ac868 __27-[XCTestSuite performTest:]_block_invoke + 288
	21  XCTest                              0x00000001046ac290 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 44
	22  XCTest                              0x00000001046ac4a0 -[XCTestSuite performTest:] + 236
	23  XCTest                              0x0000000104703f5c __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke + 44
	24  XCTest                              0x00000001046bf3e8 -[XCTestObservationCenter _observeTestExecutionForBlock:] + 420
	25  XCTest                              0x0000000104703dd8 -[XCTTestRunSession runTestsAndReturnError:] + 292
	26  XCTest                              0x000000010469bed0 -[XCTestDriver runTestsAndReturnError:] + 312
	27  XCTest                              0x00000001046f9920 _XCTestMain + 620
	28  CoreFoundation                      0x0000000181622160 <redacted> + 20
	29  CoreFoundation                      0x000000018162195c <redacted> + 288
	30  CoreFoundation                      0x000000018161f7b0 <redacted> + 788
	31  CoreFoundation                      0x000000018154e048 CFRunLoopRunSpecific + 444
	32  GraphicsServices                    0x0000000182fd1198 GSEventRunModal + 180
	33  UIKit                               0x0000000187520818 <redacted> + 684
	34  UIKit                               0x000000018751b550 UIApplicationMain + 208
	35  ios_showcase_egtests                0x0000000100101bf8 main + 120
	36  libdyld.dylib                       0x00000001805305b8 <redacted> + 4
)
 
Summary: SCPaymentsEditorTestCase/testNavigationByTappingReturn is flaky on ipad devices (was: SCPaymentsEditorTestCase/testNavigationByTappingReturn is flaky on devices)
Summary: SCPaymentsEditorTestCase/testNavigationByTappingReturn is failing on ipad devices (was: SCPaymentsEditorTestCase/testNavigationByTappingReturn is flaky on ipad devices)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0b3d50b2c3824e4d260af0759d5b998f9db5291

commit f0b3d50b2c3824e4d260af0759d5b998f9db5291
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Sep 27 23:18:14 2017

Disable testNavigationByTappingReturn on ipad devices.

Test is failing on ipad devices.

Bug:  769464 
Change-Id: I9b04bb15b5bdb30afa0aa5a484e4eb25eaeea6de
Reviewed-on: https://chromium-review.googlesource.com/688500
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504796}
[modify] https://crrev.com/f0b3d50b2c3824e4d260af0759d5b998f9db5291/ios/showcase/payments/sc_payments_editor_egtest.mm

Labels: ReleaseBlock-Beta M-63
Status: Started (was: Assigned)
Please fix this before M63 branch on Oct 12th.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe2895e63ab48f2a1efffd7e3544fc9beb89fa61

commit fe2895e63ab48f2a1efffd7e3544fc9beb89fa61
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Tue Oct 03 18:41:13 2017

[PR] Enables SCPaymentsEditorTestCase/testNavigationByTappingReturn

Enables the test by fixing two issues for iPad devices:
- Fixes the test for iPad9 by using a grey_anyOf() matcher for the return
  button's accessibility identifier matcher instead of iOS version check.
- Fixes the flakiness for iPad10 by modifying the test to be more stable so
  that it doesn't require disabling EarlGrey's synchronization.

Bug:  769464 ,  768864 
Change-Id: Iccab74d15c65951c891576a9ed3ca917cce531a9
Reviewed-on: https://chromium-review.googlesource.com/695819
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506118}
[modify] https://crrev.com/fe2895e63ab48f2a1efffd7e3544fc9beb89fa61/ios/showcase/payments/sc_payments_editor_egtest.mm

Status: Fixed (was: Started)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment