New issue
Advanced search Search tips

Issue 769435 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Merge aura::WindowTargeter::GetExtraHitTestShapeRects() and aura::Window::GetHitTestMask()

Project Member Reported by penghuang@chromium.org, Sep 27 2017

Issue description

aura::WindowTargeter::GetExtraHitTestShapeRects() and aura::WindowDelegate::GetHitTestMask() return same data in different form for an aura::Window. Should we merge them? If we want to merge them, where should it be (WindowTargeter or WindowDelegate)?
 

Comment 1 by sky@chromium.org, Sep 27 2017

Owner: varkha@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by varkha@chromium.org, Oct 20 2017

Cc: -varkha@chromium.org
Labels: -Pri-2 Pri-3
Owner: penghuang@chromium.org
I think the logic could be in WindowTargeter because this would make it easier to use with rect-based targeting in Viz.
Components: -Internals>MUS Internals>Services>WindowService
Labels: -Proj-Mustash Proj-Mash-SingleProcess
Is this something we still want to do? I'm assuming we don't need it for mash, but it would be nice. Please add Proj-Mash if it is needed for mash.
Components: -Internals>Services>WindowService Internals>Aura
Labels: -Proj-Mash-SingleProcess OS-Linux OS-Windows
I think this is something we should do, but it's more a cleanup on the aura side and not necessarily something blocking mash work. I'm changing to aura.

Sign in to add a comment