New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 769429 link

Starred by 1 user
Status: Fixed
Owner:
shaktisahu@chromium.org
Closed: Sep 2017
Cc:
█ nyquist@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
In-Product-Help


Sign in to add a comment

IPH : Change download home IPH from rectangle to circle in chrome home mode

Project Member Reported by shaktisahu@chromium.org, Sep 27 2017 
UX : https://docs.google.com/presentation/d/1p9G33j1FNmoeI5jwcqFjBRC1Vm1TbpsJZktwJCXgim0/edit?ts=59c23f9e#slide=id.g244f0963e1_15_3

Also make all IPH circles of same size. 
For modern, they should have baseline size of 12dp (instead of 16dp in non-chrome-home mode)
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe0ffcc10613e4f9c00fc6fc6ae4e9c4feec5914

commit fe0ffcc10613e4f9c00fc6fc6ae4e9c4feec5914
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Fri Sep 29 04:30:15 2017

IPH : multi-window, alignment and circle size fixes

1 - Changed Download Home IPH pulse from rectangle to circle (in chrome home bottom sheet)
2 - Reduced circle radius size for chrome home to 12dp (crbug/769429)
3 - Multi-window : Fixed chrome home IPH on bottom window from getting below the bottom toolbar. (crbug/763813)
4 - Landscape mode : Fixed bubble arrow not aligning to menu button in landscape. (crbug/757971)

Bug:  769429 , 763813,  757971 
Change-Id: Ic41c02ca34f4a3b9e6827ce4cec9f3438eb64bf0
Reviewed-on: https://chromium-review.googlesource.com/688254
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505290}
[modify] https://crrev.com/fe0ffcc10613e4f9c00fc6fc6ae4e9c4feec5914/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/fe0ffcc10613e4f9c00fc6fc6ae4e9c4feec5914/chrome/android/java/src/org/chromium/chrome/browser/widget/PulseDrawable.java
[modify] https://crrev.com/fe0ffcc10613e4f9c00fc6fc6ae4e9c4feec5914/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
[modify] https://crrev.com/fe0ffcc10613e4f9c00fc6fc6ae4e9c4feec5914/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/TextBubble.java
[modify] https://crrev.com/fe0ffcc10613e4f9c00fc6fc6ae4e9c4feec5914/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/ViewAnchoredTextBubble.java

Comment 2 by shaktisahu@chromium.org, Sep 29 2017

Status: Fixed (was: Started)
►

Sign in to add a comment