New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769425 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 772337
issue 771623
issue 776711



Sign in to add a comment

[Feedback Stable] Data in "All sites" are not cleared after click clear browsing data unless relaunch Chrome

Project Member Reported by hongchic...@chromium.org, Sep 27 2017

Issue description

Chrome Version: 61.0.3163.98, 61.0.3163.81, 60.0.3112.116, 60.0.3112.107
OS: Android

What steps will reproduce the problem?
Users report that data in All sites under Site settings are not cleared after they clear "Cookies and site data" by clicking clear browsing data in history page.
I can reproduce this issue and I found the data in All sites are gone after I relaunch Chrome. This might be confusing for users. Thanks. 

https://listnr.corp.google.com/report/72657023828
https://listnr.corp.google.com/report/72623864642
https://listnr.corp.google.com/report/72023646637
https://listnr.corp.google.com/report/73794153586
https://listnr.corp.google.com/report/73794108449
https://listnr.corp.google.com/report/73643233775


What is the expected result?

What happens instead?

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by ew...@chromium.org, Sep 28 2017

Cc: msramek@chromium.org dullweber@chromium.org
+people who work on the CBD dialogue
Thanks! I can't access the reports but this might be the local storage issue:  https://crbug.com/679344  

I will check next week if there are other storage types that are affected as well.
Yes, users also mention local storage is not cleared after click clear browsing data on CBD dialogue. Thanks. 
Blockedon: 771623
Owner: dullweber@chromium.org
Status: Started (was: Untriaged)
There are other issues as well:
 - Session storage seems to have deletion issues. It looks like empty entries are left after deletion.
 - Data for origins with non web schemes (e.g. chrome-devtools://) are counted as cookies. 

Both of these data types are not counted for chrome://settings/siteData, so it probably makes sense to stop counting them for CBD as well.

 - File System entries are not deleted correctly. I filed  https://crbug.com/771623  for this.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85a3a3b12280b4cd2fb5089d8dd7e078c2ec89fa

commit 85a3a3b12280b4cd2fb5089d8dd7e078c2ec89fa
Author: Christian Dullweber <dullweber@chromium.org>
Date: Fri Oct 06 09:29:00 2017

Don't count non-web scheme cookies for CBD

Currently non-web data is counted towards the number of cookies shown in
Clear Browsing Data. The cookie tree model is not counting these entries
as browsing data, so they shouldn't be counted here as well.


Bug:  769425 
Change-Id: I65a63ab73b5e0baa26999d1b19b262ac76846b84
Reviewed-on: https://chromium-review.googlesource.com/700695
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507017}
[modify] https://crrev.com/85a3a3b12280b4cd2fb5089d8dd7e078c2ec89fa/chrome/browser/browsing_data/site_data_counting_helper.cc

Blockedon: 772337
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f88b441b4fdc5f648c511c8daab9061b7843f74

commit 3f88b441b4fdc5f648c511c8daab9061b7843f74
Author: Christian Dullweber <dullweber@chromium.org>
Date: Fri Oct 06 13:47:38 2017

Don't count session_storage for cookie count in CBD

Session storage seems to have an issue with left-over entries after
deletion site data. chrome://settings/siteData doesn't show them,
it might make sense to remove them from this counter as well until
they are deleted correctly.

Bug:  769425 
Change-Id: I14a108a918dbb1f4eb18a619d8163506f17f96d8
Reviewed-on: https://chromium-review.googlesource.com/700677
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507048}
[modify] https://crrev.com/3f88b441b4fdc5f648c511c8daab9061b7843f74/chrome/browser/browsing_data/site_data_counting_helper.cc

Cc: msrchandra@chromium.org sandeepkumars@chromium.org nyerramilli@chromium.org
 Issue 773984  has been merged into this issue.
Cc: keerthan...@techmahindra.com vamshi.k...@techmahindra.com
 Issue 765011  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab39f103c1d4da5ca51e6ea8517e17f5316def09

commit ab39f103c1d4da5ca51e6ea8517e17f5316def09
Author: Christian Dullweber <dullweber@chromium.org>
Date: Thu Oct 19 12:19:39 2017

Add browser_test for counting and deleting site data

This test creates site data entries via javascript and tests that they
are counted and deleted correctly.

Bug:  769425 
Change-Id: I81178ade64a5d76fd19ee7e79c6a55c4c5ae32cc
Reviewed-on: https://chromium-review.googlesource.com/725385
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510059}
[modify] https://crrev.com/ab39f103c1d4da5ca51e6ea8517e17f5316def09/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[add] https://crrev.com/ab39f103c1d4da5ca51e6ea8517e17f5316def09/content/test/data/site_data.html

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ae06a8fb1cded351c7ca8e603427b3d860cc9dc

commit 6ae06a8fb1cded351c7ca8e603427b3d860cc9dc
Author: Christian Dullweber <dullweber@chromium.org>
Date: Fri Oct 20 10:21:59 2017

Add additional site data deletion tests

Add tests for service worker, cache storage and websql.
Add tests for empty filesystems.
Add test to ensure that session storage is not counted as site data.

Bug:  769425 
Change-Id: I01ebaabe40baf22c7c3f6762e60f790e0dbf9686
Reviewed-on: https://chromium-review.googlesource.com/727809
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510394}
[modify] https://crrev.com/6ae06a8fb1cded351c7ca8e603427b3d860cc9dc/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/6ae06a8fb1cded351c7ca8e603427b3d860cc9dc/content/test/data/site_data.html

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4270656328f068a1aeec3abd41fd0b31adc047b2

commit 4270656328f068a1aeec3abd41fd0b31adc047b2
Author: Christian Dullweber <dullweber@chromium.org>
Date: Tue Oct 24 14:57:44 2017

Add browsing_data_remover test for indexedDB

Add a test to verify deletion and counting of indexedDb.

Bug:  769425 
Change-Id: Ie3bfe10e28b2f0455effe279e624f2b0a6324c2a
Reviewed-on: https://chromium-review.googlesource.com/732977
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511146}
[modify] https://crrev.com/4270656328f068a1aeec3abd41fd0b31adc047b2/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/4270656328f068a1aeec3abd41fd0b31adc047b2/content/test/data/browsing_data/site_data.html

Blockedon: 776711
Cc: xingliu@chromium.org ligim...@chromium.org rbasuvula@chromium.org
 Issue 774874  has been merged into this issue.
Status: Fixed (was: Started)
All deletion issues related to this bug have been fixed so I will close it.

Sign in to add a comment