New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769412 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 509038



Sign in to add a comment

Avoid unecessary async_tests with new bluetooth testing api

Project Member Reported by cco3@chromium.org, Sep 27 2017

Issue description

We need to create a bluetooth-specific test method that imports the appropriate dependencies on order to migrate our LayoutTests to be Web Platform Tests.  Most simply, this would involve just wrapping promise_test.

We already have minimal async_tests, and some of them don't actually provide any clarity over a promise_test approach.  We should just use promise tests where applicable.
 

Comment 1 by scheib@chromium.org, Sep 27 2017

Blocking: 509038
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3c7642c49f2145ae41c040a02d1e0570798a000

commit a3c7642c49f2145ae41c040a02d1e0570798a000
Author: Conley Owens <cco3@chromium.org>
Date: Fri Sep 29 21:30:34 2017

bluetooth: Update request-from-iframe test

This test may be simplified by using a promise_test rather than an
async_test.  Additionally, using promise_test will simplify the
transition to new mojo bindings and the migration to Web Platform Tests.

BUG= 769412 

Change-Id: Iccc8fd85ec5bdebc213350e94f33dba0bf4bf92a
Reviewed-on: https://chromium-review.googlesource.com/688020
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505458}
[modify] https://crrev.com/a3c7642c49f2145ae41c040a02d1e0570798a000/third_party/WebKit/LayoutTests/bluetooth/requestDevice/request-from-iframe.html
[modify] https://crrev.com/a3c7642c49f2145ae41c040a02d1e0570798a000/third_party/WebKit/LayoutTests/resources/bluetooth/requestDevice-in-iframe.html

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c404009dd2ca4e5e98b9c796bec2809f112e48ef

commit c404009dd2ca4e5e98b9c796bec2809f112e48ef
Author: Conley Owens <cco3@chromium.org>
Date: Tue Oct 03 00:33:46 2017

bluetooth: Update two-iframes test

This test may be simplified by using a promise_test rather than an
async_test.  Additionally, using promise_test will simplify the
transition to new mojo bindings and the migration to Web Platform
Tests.

BUG= 769412 

Change-Id: I4ae41fa5e5fb43ee611cefc8527bb2e078f1bb71
Reviewed-on: https://chromium-review.googlesource.com/690602
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505881}
[modify] https://crrev.com/c404009dd2ca4e5e98b9c796bec2809f112e48ef/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/two-iframes-from-same-origin.html
[modify] https://crrev.com/c404009dd2ca4e5e98b9c796bec2809f112e48ef/third_party/WebKit/LayoutTests/resources/bluetooth/health-thermometer-two-iframes.html

Comment 4 by cco3@chromium.org, Oct 4 2017

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e95c0692055388f752fd7b8db460024944176534

commit e95c0692055388f752fd7b8db460024944176534
Author: Ovidio Henriquez <odejesush@google.com>
Date: Fri Nov 17 21:42:10 2017

bluetooth: web: test: Update sandboxed iframe test

This change updates the request-from-sandboxed-iframe.html test to be a
promise_test as opposed to being an async_test. This will help us
migrate the test to the wpt/ directory, since we use a wrapper around
promise_test to dynamically load Chromium specific modules.

BUG= 769412 

Change-Id: I7f057261eaa2346821ace3aa6800c7bf82e7d6e7
Reviewed-on: https://chromium-review.googlesource.com/769346
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@google.com>
Cr-Commit-Position: refs/heads/master@{#517566}
[modify] https://crrev.com/e95c0692055388f752fd7b8db460024944176534/third_party/WebKit/LayoutTests/bluetooth/requestDevice/request-from-iframe.html
[modify] https://crrev.com/e95c0692055388f752fd7b8db460024944176534/third_party/WebKit/LayoutTests/bluetooth/requestDevice/request-from-sandboxed-iframe.html
[modify] https://crrev.com/e95c0692055388f752fd7b8db460024944176534/third_party/WebKit/LayoutTests/http/tests/bluetooth/https/requestDevice/cross-origin-iframe.html
[modify] https://crrev.com/e95c0692055388f752fd7b8db460024944176534/third_party/WebKit/LayoutTests/resources/bluetooth/requestDevice-in-iframe.html

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02a8197e3357cfadea9019df500419069d9bafea

commit 02a8197e3357cfadea9019df500419069d9bafea
Author: Ovidio Henriquez <odejesush@google.com>
Date: Tue Dec 05 01:43:47 2017

bluetooth: web: test: Update gc detach test

This change updates the gc-detach.html and detach-gc.html tests to use
promise_test as opposed to async_test. This will help us migrate the
tests to the wpt/ directory, since we use a wrapper around
promise_test to dynamically load Chromium-specific modules.

This change also updates gc-detach.html and detach-gc.html to use
health-thermometer-iframe.html in order to use
getHealthThermometerDevice rather than setBluetoothFakeAdapter. As a
result, health-thermometer-iframe.html now contains a
"RequestAndConnect" message case, and bluetooth-helpers.js does not
rely on the "Ready" message from the health-thermometer-iframe.html
anymore.

Additionally, bluetooth-helpers.js now contains a function called
setUpConnectableHealthThermometerDevice that sets up a
fake_peripheral without requesting the device for tests that require
the device to be requested outside of the main frame.

BUG= 769412 

Change-Id: I310fd68569fb646e9e4e2ffde202b8f953a47e9b
Reviewed-on: https://chromium-review.googlesource.com/777339
Commit-Queue: Ovidio Henriquez <odejesush@google.com>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521584}
[modify] https://crrev.com/02a8197e3357cfadea9019df500419069d9bafea/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/detach-gc.html
[modify] https://crrev.com/02a8197e3357cfadea9019df500419069d9bafea/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/gc-detach.html
[modify] https://crrev.com/02a8197e3357cfadea9019df500419069d9bafea/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
[modify] https://crrev.com/02a8197e3357cfadea9019df500419069d9bafea/third_party/WebKit/LayoutTests/resources/bluetooth/health-thermometer-iframe.html

Sign in to add a comment