Fix bluetooth layout tests with platform-dependent expectations files |
||
Issue descriptionAt least one bluetooth test requires platform dependent expectation files. third_party/WebKit/LayoutTests/bluetooth/idl/idl-BluetoothDevice.html These seem to be unneeded in our case and should be fixed.
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ced8acfc745aa29bce0c6712230d286bc23af689 commit ced8acfc745aa29bce0c6712230d286bc23af689 Author: Conley Owens <cco3@chromium.org> Date: Fri Sep 29 18:40:44 2017 bluetooth: Update BluetoothDevice IDL tests These tests were not functioning correctly because `assert_throws` was not being passed an Error. Furthermore, the use of the `expected.txt` file is brittle since it includes a warning output with a line number. BUG= 769404 Change-Id: Ie867e6b99fc87d7c9b8b7259684f2ddd3cdc37a2 Reviewed-on: https://chromium-review.googlesource.com/688295 Reviewed-by: Vincent Scheib <scheib@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#505429} [modify] https://crrev.com/ced8acfc745aa29bce0c6712230d286bc23af689/third_party/WebKit/LayoutTests/bluetooth/idl/idl-BluetoothDevice.html [delete] https://crrev.com/c2984f64e32d960e68e9c544edec3567ca4d493c/third_party/WebKit/LayoutTests/platform/mac/bluetooth/idl/idl-BluetoothDevice-expected.txt [delete] https://crrev.com/c2984f64e32d960e68e9c544edec3567ca4d493c/third_party/WebKit/LayoutTests/platform/win/bluetooth/idl/idl-BluetoothDevice-expected.txt
,
Oct 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by scheib@chromium.org
, Sep 27 2017Status: Started (was: Untriaged)