Issue metadata
Sign in to add a comment
|
chrome_public_test_apk failing on 2 builders |
||||||||||||||||||||||||
Issue descriptionchrome_public_test_apk failing on 2 builders Builders failed on: - Android Tests: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests - Android Tests (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29 Test failure: org.chromium.chrome.browser.ntp.NewTabPageTest#testRender stack: org.chromium.chrome.test.util.RenderTestRule$RenderTestException: RenderTest Mismatches for: new_tab_page_scrolled at org.chromium.chrome.test.util.RenderTestRule.finished(RenderTestRule.java:215) at org.junit.rules.TestWatcher.finishedQuietly(TestWatcher.java:117) at org.junit.rules.TestWatcher.access$400(TestWatcher.java:46) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:64) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:175) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:40) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:164) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59) at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262) at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:98) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) CL range: https://chromium.googlesource.com/chromium/src/+log/817180284a04ca33e0a244729ee1b9cf3d04143f%5E..cbdf643f13cacd3491febd0cd146b2b1158a27d4?pretty=fuller&n= suspected CL: https://chromium-review.googlesource.com/c/chromium/src/+/674691
,
Sep 27 2017
is this a dup of 762932?
,
Sep 27 2017
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b12dca10a0ba9ea37254c72b270d0b99104f6b7e commit b12dca10a0ba9ea37254c72b270d0b99104f6b7e Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Thu Sep 28 11:37:16 2017 Reland "📰 Use standard styles for classic action items" This reverts 2 CLs, https://crrev.com/c/688582 and https://crrev.com/c/688160. The fix for the failure was landed in https://crrev.com/c/688076 Original change's description: > 📰 Use standard styles for classic action items > > Updates the SuggestionCardActionModern style to be more generic and > be usable for classic cards, use it for the classic generic signin > promo and the action item. > > Preview: https://photos.app.goo.gl/GC9l01D8QI7YSLtI2 > Bug: None > Change-Id: If1a007ad4288cc88511845b3ac89a9c8f2f1cbab > Reviewed-on: https://chromium-review.googlesource.com/674691 > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504678} > Bug: 769403 , 769265 Change-Id: I8c1883181a506e6392e74439984620f0705acd37 Reviewed-on: https://chromium-review.googlesource.com/689515 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#504971} [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/android/java/res/layout/content_suggestions_action_card_modern.xml [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/android/java/res/layout/content_suggestions_status_card_modern.xml [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/android/java/res/layout/new_tab_page_action_card.xml [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/android/java/res/layout/new_tab_page_status_card.xml [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-signin_promo.Nexus_5-19.png [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/test/data/android/render_tests/ArticleSnippetsTest.signin_promo.Nexus_5-19.png |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 27 2017