New issue
Advanced search Search tips

Issue 769401 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug


Sign in to add a comment

Run all browser tests on network service FYI bot

Project Member Reported by jam@chromium.org, Sep 27 2017

Issue description

Now that most tests in content and below are passing, we should expand browser_test to be a blacklist instead of a whitelist. We should also run interactive_ui_tests and other test suites like component_unittests, components_browsertests, extensions_browsertests and unit_tests.

Then we can create child bugs of the parent network bug for all the big groups of failures so that we can find owners.
 
Showing comments 21 - 120 of 120 Older
Blockedon: 779178
Blockedon: 779181
Blockedon: 779197
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e83f760157a448e2a1be3904ea866f01346e45d

commit 6e83f760157a448e2a1be3904ea866f01346e45d
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Fri Oct 27 20:42:46 2017

Update network service browser test filter to add bug link for URL blacklist support.

BUG= 769401 
TBR=jam@chromium.org

Change-Id: If9bae8fc6e94b46dbad8bc17ff34a1aa4a51bfb8
Reviewed-on: https://chromium-review.googlesource.com/742196
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512266}
[modify] https://crrev.com/6e83f760157a448e2a1be3904ea866f01346e45d/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Blockedon: 779210
Blockedon: 779215
Blockedon: 779217
Blockedon: 779236
Project Member

Comment 29 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fca52b6d65cf56db1699035dac956ce362c82307

commit fca52b6d65cf56db1699035dac956ce362c82307
Author: Jun Cai <juncai@chromium.org>
Date: Mon Oct 30 20:10:50 2017

Move some crashed tests to timed out tests

This CL moves some crashed tests to timed out tests to better categorize
them.

Bug:  769401 
Change-Id: I92d7dff7a39c1eb02cf4aa9d62814cf887c52533
Reviewed-on: https://chromium-review.googlesource.com/742458
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512590}
[modify] https://crrev.com/fca52b6d65cf56db1699035dac956ce362c82307/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 30 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0c5c85acca945eb3399fb000b6b1bbdb5b2ab4e

commit c0c5c85acca945eb3399fb000b6b1bbdb5b2ab4e
Author: Jun Cai <juncai@chromium.org>
Date: Mon Oct 30 23:49:43 2017

Update some disabled browser tests with crbug link for network service

This CL categorizes some disabled browser tests with service worker
related crbug link since they have similar stack trace.

This CL also enables a browser test that runs successfully when using
network service.

Bug:  769401 
Change-Id: Icaeaad7c39c45b702bbf4a7e06ea40fbd2ff1985
Reviewed-on: https://chromium-review.googlesource.com/738876
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512678}
[modify] https://crrev.com/c0c5c85acca945eb3399fb000b6b1bbdb5b2ab4e/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 31 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbe92e52f90905fa24b797821131edefc7738fa3

commit cbe92e52f90905fa24b797821131edefc7738fa3
Author: Jun Cai <juncai@chromium.org>
Date: Tue Oct 31 20:23:20 2017

Move some crashed browser tests to failed tests for network service

This CL moves some crashed tests to failed tests to better categorize
them.

TBR=yzshen@chromium.org

Bug:  769401 
Change-Id: I35a54b8a82855fe227365f6b586678d80943a0e3
Reviewed-on: https://chromium-review.googlesource.com/747624
Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512934}
[modify] https://crrev.com/cbe92e52f90905fa24b797821131edefc7738fa3/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 32 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c7f8579022a67cc5a7cbbcdbcad76fa09c8a46c

commit 9c7f8579022a67cc5a7cbbcdbcad76fa09c8a46c
Author: Jun Cai <juncai@chromium.org>
Date: Fri Nov 03 20:59:55 2017

NetworkService: re-categorize some disabled browser tests

This CL enables some browser tests that used to crash, and moves some
crashed tests to failed or timed out tests to better categorize them.

TBR=yzshen@chromium.org

Bug:  769401 
Change-Id: Ibbf8caa636229450acee87830dc31134e7b864ed
Reviewed-on: https://chromium-review.googlesource.com/754004
Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513906}
[modify] https://crrev.com/9c7f8579022a67cc5a7cbbcdbcad76fa09c8a46c/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 33 by bugdroid1@chromium.org, Nov 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c7123a6d4449f631d9037a5d6203b84cb005361

commit 2c7123a6d4449f631d9037a5d6203b84cb005361
Author: Randy Smith <rdsmith@chromium.org>
Date: Sat Nov 04 22:44:48 2017

Suppress browser tests failing on the Mojo FYI bot.

I believe root cause is the reland of this CL:
https://chromium-review.googlesource.com/753801 at p513843.

TBR=mmenke@chromium.org

Bug:  769401 
Change-Id: I50b4aa86f83bce4a04c5a322086c20e6575ba3f0
Reviewed-on: https://chromium-review.googlesource.com/753743
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514057}
[modify] https://crrev.com/2c7123a6d4449f631d9037a5d6203b84cb005361/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 34 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39ba30acf468daf12b38a2c832dc769fcbff0681

commit 39ba30acf468daf12b38a2c832dc769fcbff0681
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Nov 07 16:35:53 2017

Disable DeclarativeNetRequestBrowserTests with the network service.

A bunch were added in https://chromium-review.googlesource.com/737451,
and most (all?) aren't passing on the mojo network service bot.

TBR=rdsmith@chromium.org
NOTRY=true

Bug: 696822, 769401 
Change-Id: I282229d0c816614ba110d0431326eb1982eed176
Reviewed-on: https://chromium-review.googlesource.com/756861
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514488}
[modify] https://crrev.com/39ba30acf468daf12b38a2c832dc769fcbff0681/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Project Member

Comment 36 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3514a2f2db12ec03ec19276fa452ef408024bb80

commit 3514a2f2db12ec03ec19276fa452ef408024bb80
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Nov 09 07:42:12 2017

Fix payments browser_tests with network service

The tests were hanging because the network process only gets the host
resolver rules after SetUpOnMainThread returns. The payments test
harness was navigating in that method. The fix is to move the navigation
out to the test body.

Bug:  769401 
Change-Id: I335b91d400889a9fc8e7e15588df2d9812f65dca
Reviewed-on: https://chromium-review.googlesource.com/758524
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515118}
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/cvc_unmask_view_controller_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/empty_update_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/error_message_view_controller_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/modifiers_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_blob_url_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_completion_status_metrics_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_data_url_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_debit_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_journey_logger_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_no_update_with_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_payment_app_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_shipping_address_instance_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_request_use_stats_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/profile_list_view_controller_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/chrome/browser/ui/views/payments/shipping_option_view_controller_browsertest.cc
[modify] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 37 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab19b8e9c9534a6e9e5771803f35b8d65658cc2b

commit ab19b8e9c9534a6e9e5771803f35b8d65658cc2b
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Nov 10 17:22:38 2017

Store the socket address in NavigationHandle from the browser instead of from the renderer.

There's no reason to trust the renderer. Also, this approach allows NavigationHandle to get this
data for downloads, which I'll use in a future cl.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I064e568adce25b2209541a8fc39e0f02e08eb26b
Reviewed-on: https://chromium-review.googlesource.com/762133
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515579}
[modify] https://crrev.com/ab19b8e9c9534a6e9e5771803f35b8d65658cc2b/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/ab19b8e9c9534a6e9e5771803f35b8d65658cc2b/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/ab19b8e9c9534a6e9e5771803f35b8d65658cc2b/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/ab19b8e9c9534a6e9e5771803f35b8d65658cc2b/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/ab19b8e9c9534a6e9e5771803f35b8d65658cc2b/content/browser/loader/navigation_resource_throttle.cc
[modify] https://crrev.com/ab19b8e9c9534a6e9e5771803f35b8d65658cc2b/content/common/frame_messages.h
[modify] https://crrev.com/ab19b8e9c9534a6e9e5771803f35b8d65658cc2b/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/ab19b8e9c9534a6e9e5771803f35b8d65658cc2b/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/ab19b8e9c9534a6e9e5771803f35b8d65658cc2b/content/test/test_render_frame_host.cc
[modify] https://crrev.com/ab19b8e9c9534a6e9e5771803f35b8d65658cc2b/content/test/test_render_frame_host.h

Project Member

Comment 38 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2ad53b0ff2cddd736be511bf1bc060e8811cf4a

commit f2ad53b0ff2cddd736be511bf1bc060e8811cf4a
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Nov 10 23:02:53 2017

Fix SBNavigationObserverBrowserTest failures with Network Service.

The first fix is to stop using WebContentsObserver::DidGetResourceResponseStart which only works
with ResourceDispatcherHost code path (i.e. non-network-service). Use DidFinishNavigation which
provides the same information.

The second fix is in the tests, to stop navigating in SetUpOnMainThread. With the network
service, the host resolver changes aren't synced until after that method returns.

The related previous cl r515579 plumbed the socket address into NavigationHandle for downloads.

Bug:  769401 
Change-Id: Idd007fd61dd6e31da63c0b01e8d4182f02cf1042
Reviewed-on: https://chromium-review.googlesource.com/763874
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515725}
[modify] https://crrev.com/f2ad53b0ff2cddd736be511bf1bc060e8811cf4a/chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc
[modify] https://crrev.com/f2ad53b0ff2cddd736be511bf1bc060e8811cf4a/chrome/browser/safe_browsing/safe_browsing_navigation_observer.h
[modify] https://crrev.com/f2ad53b0ff2cddd736be511bf1bc060e8811cf4a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
[modify] https://crrev.com/f2ad53b0ff2cddd736be511bf1bc060e8811cf4a/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/f2ad53b0ff2cddd736be511bf1bc060e8811cf4a/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 39 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b128003d84ca7791744bbc5dc4ac92fb54adf12f

commit b128003d84ca7791744bbc5dc4ac92fb54adf12f
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Nov 15 22:37:53 2017

More classification of failing browser_tests with network service.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2b460555ec3882216d572050f21a9b145608d55c
Reviewed-on: https://chromium-review.googlesource.com/771382
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516867}
[modify] https://crrev.com/b128003d84ca7791744bbc5dc4ac92fb54adf12f/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 40 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5bfc97fce316a1b986971184d36e763d4e4168a

commit d5bfc97fce316a1b986971184d36e763d4e4168a
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Nov 20 17:52:14 2017

More classification of failing browser_tests with network service

NOTRY=true

Bug:  769401 
Change-Id: Id963e057735613afd481658c1fa566f0b792dd49
Reviewed-on: https://chromium-review.googlesource.com/779085
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517856}
[modify] https://crrev.com/d5bfc97fce316a1b986971184d36e763d4e4168a/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 41 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61d693b738cadfbfa8fc448990d6ffd2addd798d

commit 61d693b738cadfbfa8fc448990d6ffd2addd798d
Author: Doug Turner <dougt@chromium.org>
Date: Tue Nov 21 05:46:39 2017

Fix ErrorPageAutoReloadTest failures with Network Service.

This CL creates a URLLoaderFactoryPtr based on the existing
URLRequestInterceptor which fails the first N requests then
begins allowing the loads.

If the network service feature flag is not set, we fall back
to just using the old URLRequestInterceptor.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id0a43f204d4323a9df7d4c84b2e09b82a492c9c6
Reviewed-on: https://chromium-review.googlesource.com/778181
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518139}
[modify] https://crrev.com/61d693b738cadfbfa8fc448990d6ffd2addd798d/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/61d693b738cadfbfa8fc448990d6ffd2addd798d/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/61d693b738cadfbfa8fc448990d6ffd2addd798d/content/browser/storage_partition_impl.h
[modify] https://crrev.com/61d693b738cadfbfa8fc448990d6ffd2addd798d/content/public/browser/storage_partition.h
[modify] https://crrev.com/61d693b738cadfbfa8fc448990d6ffd2addd798d/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/61d693b738cadfbfa8fc448990d6ffd2addd798d/content/public/test/test_storage_partition.h
[modify] https://crrev.com/61d693b738cadfbfa8fc448990d6ffd2addd798d/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 42 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8a479a90c17a4789aa952f82b475fd82e0322b1

commit b8a479a90c17a4789aa952f82b475fd82e0322b1
Author: Takeshi Yoshino <tyoshino@chromium.org>
Date: Tue Nov 21 06:15:19 2017

Revert "Fix ErrorPageAutoReloadTest failures with Network Service."

This reverts commit 61d693b738cadfbfa8fc448990d6ffd2addd798d.

Reason for revert: Broke build

Original change's description:
> Fix ErrorPageAutoReloadTest failures with Network Service.
> 
> This CL creates a URLLoaderFactoryPtr based on the existing
> URLRequestInterceptor which fails the first N requests then
> begins allowing the loads.
> 
> If the network service feature flag is not set, we fall back
> to just using the old URLRequestInterceptor.
> 
> Bug:  769401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Id0a43f204d4323a9df7d4c84b2e09b82a492c9c6
> Reviewed-on: https://chromium-review.googlesource.com/778181
> Commit-Queue: Doug Turner <dougt@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518139}

TBR=jam@chromium.org,dougt@chromium.org

Change-Id: I3fc45334cb72dfbf00ef4ec2afbf3f836e218f4e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/780944
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518147}
[modify] https://crrev.com/b8a479a90c17a4789aa952f82b475fd82e0322b1/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/b8a479a90c17a4789aa952f82b475fd82e0322b1/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/b8a479a90c17a4789aa952f82b475fd82e0322b1/content/browser/storage_partition_impl.h
[modify] https://crrev.com/b8a479a90c17a4789aa952f82b475fd82e0322b1/content/public/browser/storage_partition.h
[modify] https://crrev.com/b8a479a90c17a4789aa952f82b475fd82e0322b1/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/b8a479a90c17a4789aa952f82b475fd82e0322b1/content/public/test/test_storage_partition.h
[modify] https://crrev.com/b8a479a90c17a4789aa952f82b475fd82e0322b1/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 43 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c5adea328f9744570e99520da2fa814af71df25

commit 9c5adea328f9744570e99520da2fa814af71df25
Author: Jun Cai <juncai@chromium.org>
Date: Tue Nov 21 15:19:01 2017

NetworkService: Fix ChromeContentRendererClientBrowserTest browser tests

This CL fixes ChromeContentRendererClientBrowserTest browser tests by
adding code to ignore certificate error when setting up the tests.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iec113e7471dbe90cbfb0f10aa662df35ff6b8dee
Reviewed-on: https://chromium-review.googlesource.com/777849
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518255}
[modify] https://crrev.com/9c5adea328f9744570e99520da2fa814af71df25/chrome/renderer/DEPS
[modify] https://crrev.com/9c5adea328f9744570e99520da2fa814af71df25/chrome/renderer/chrome_content_renderer_client_browsertest.cc
[modify] https://crrev.com/9c5adea328f9744570e99520da2fa814af71df25/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 44 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79668236c9383030bd4cacb206d8896165f86b7c

commit 79668236c9383030bd4cacb206d8896165f86b7c
Author: Doug Turner <dougt@chromium.org>
Date: Tue Nov 21 23:13:55 2017

Fix ErrorPageAutoReloadTest failures with Network Service.

This CL creates a URLLoaderFactoryPtr based on the existing
URLRequestInterceptor which fails the first N requests then
begins allowing the loads.

If the network service feature flag is not set, we fall back
to just using the old URLRequestInterceptor.

Relanding after adding common:interfaces to public_deps.


Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If9cda1d728161a7067d8d2f4f8d88b06e55059c9
Reviewed-on: https://chromium-review.googlesource.com/782703
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518430}
[modify] https://crrev.com/79668236c9383030bd4cacb206d8896165f86b7c/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/79668236c9383030bd4cacb206d8896165f86b7c/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/79668236c9383030bd4cacb206d8896165f86b7c/content/browser/storage_partition_impl.h
[modify] https://crrev.com/79668236c9383030bd4cacb206d8896165f86b7c/content/public/browser/storage_partition.h
[modify] https://crrev.com/79668236c9383030bd4cacb206d8896165f86b7c/content/public/common/BUILD.gn
[modify] https://crrev.com/79668236c9383030bd4cacb206d8896165f86b7c/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/79668236c9383030bd4cacb206d8896165f86b7c/content/public/test/test_storage_partition.h
[modify] https://crrev.com/79668236c9383030bd4cacb206d8896165f86b7c/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 45 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ee4cceca036affd692ce4707640ee1abde192df

commit 6ee4cceca036affd692ce4707640ee1abde192df
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed Nov 22 00:01:17 2017

Revert "Fix ErrorPageAutoReloadTest failures with Network Service."

This reverts commit 79668236c9383030bd4cacb206d8896165f86b7c.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 518430 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc5NjY4MjM2YzkzODMwMzBiZDRjYWNiMjA2ZDg4OTYxNjVmODZiN2MM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Mac/28083

Original change's description:
> Fix ErrorPageAutoReloadTest failures with Network Service.
> 
> This CL creates a URLLoaderFactoryPtr based on the existing
> URLRequestInterceptor which fails the first N requests then
> begins allowing the loads.
> 
> If the network service feature flag is not set, we fall back
> to just using the old URLRequestInterceptor.
> 
> Relanding after adding common:interfaces to public_deps.
> 
> 
> Bug:  769401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: If9cda1d728161a7067d8d2f4f8d88b06e55059c9
> Reviewed-on: https://chromium-review.googlesource.com/782703
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Doug Turner <dougt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518430}

Change-Id: I49c1ff44c4e7aebffc09770c04a8b8e7d71e7862
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/783496
Cr-Commit-Position: refs/heads/master@{#518460}
[modify] https://crrev.com/6ee4cceca036affd692ce4707640ee1abde192df/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/6ee4cceca036affd692ce4707640ee1abde192df/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/6ee4cceca036affd692ce4707640ee1abde192df/content/browser/storage_partition_impl.h
[modify] https://crrev.com/6ee4cceca036affd692ce4707640ee1abde192df/content/public/browser/storage_partition.h
[modify] https://crrev.com/6ee4cceca036affd692ce4707640ee1abde192df/content/public/common/BUILD.gn
[modify] https://crrev.com/6ee4cceca036affd692ce4707640ee1abde192df/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/6ee4cceca036affd692ce4707640ee1abde192df/content/public/test/test_storage_partition.h
[modify] https://crrev.com/6ee4cceca036affd692ce4707640ee1abde192df/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 46 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa18e5700153acdb3e3376af0c168f87dcbdf282

commit aa18e5700153acdb3e3376af0c168f87dcbdf282
Author: Doug Turner <dougt@chromium.org>
Date: Wed Nov 22 05:03:19 2017

Fix ErrorPageAutoReloadTest failures with Network Service.

This CL creates a URLLoaderFactoryPtr based on the existing
URLRequestInterceptor which fails the first N requests then
begins allowing the loads.

If the network service feature flag is not set, we fall back
to just using the old URLRequestInterceptor.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2f5dd028853a130b8f665c355815ce8c424c823c
Reviewed-on: https://chromium-review.googlesource.com/784054
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518537}
[modify] https://crrev.com/aa18e5700153acdb3e3376af0c168f87dcbdf282/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/aa18e5700153acdb3e3376af0c168f87dcbdf282/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/aa18e5700153acdb3e3376af0c168f87dcbdf282/content/browser/storage_partition_impl.h
[modify] https://crrev.com/aa18e5700153acdb3e3376af0c168f87dcbdf282/content/public/browser/storage_partition.h
[modify] https://crrev.com/aa18e5700153acdb3e3376af0c168f87dcbdf282/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/aa18e5700153acdb3e3376af0c168f87dcbdf282/content/public/test/test_storage_partition.h
[modify] https://crrev.com/aa18e5700153acdb3e3376af0c168f87dcbdf282/extensions/browser/guest_view/web_view/web_ui/BUILD.gn
[modify] https://crrev.com/aa18e5700153acdb3e3376af0c168f87dcbdf282/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 47 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a1dde7d98e0748b2b1b4bae2907bd50bf6d77c8

commit 2a1dde7d98e0748b2b1b4bae2907bd50bf6d77c8
Author: Doug Turner <dougt@chromium.org>
Date: Wed Nov 22 08:23:31 2017

Adds creates a URLLoaderFactory to replace AddressUnreachableInterceptor

This Cl adds a new AddressUnreachableURLLoaderFactory which fails to load
a given URL and will forward other URLs to the default url loader.

This CL also cleans up how we install test a URLLoaderFactory.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I353e1ee5347f72c80a7c6c06a5ac859f40bc8690
Reviewed-on: https://chromium-review.googlesource.com/780769
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518566}
[modify] https://crrev.com/2a1dde7d98e0748b2b1b4bae2907bd50bf6d77c8/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/2a1dde7d98e0748b2b1b4bae2907bd50bf6d77c8/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 48 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e66e726ef7ec207b7b5cd41603f6e5682eb12f1

commit 0e66e726ef7ec207b7b5cd41603f6e5682eb12f1
Author: Jun Cai <juncai@chromium.org>
Date: Wed Nov 22 16:53:03 2017

NetworkService: List ResourceDispatcherHost related browser tests under its own category in the filter

Since ResourceDispatcherHost isn't used with the network service, this CL lists
ResourceDispatcherHost related browser tests under its own category in the filter
with a bug filed.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I92eb230212eb5e326c7614a6f704ae9b44ded334
Reviewed-on: https://chromium-review.googlesource.com/782759
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518656}
[modify] https://crrev.com/0e66e726ef7ec207b7b5cd41603f6e5682eb12f1/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/0e66e726ef7ec207b7b5cd41603f6e5682eb12f1/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 49 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb

commit 4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Dec 01 20:24:43 2017

Set the prefetch load flag without a resource throttle for compatibility with the network service.

This was originally added in 440645 using a resource throttle. Since resource throttles don't work
with the network service (as net runs out of process), instead do this in the same
ContentBrowserClient callback which is used to add extra headers for prerendering requests.

Also convert a few prefetch tests for this to use the new URLLoaderInterceptor so that they pass
with the network service.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I993912ff991dda33c0fb58ae8e38f88fd16ee4ac
Reviewed-on: https://chromium-review.googlesource.com/802996
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521034}
[modify] https://crrev.com/4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
[modify] https://crrev.com/4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb/chrome/browser/prerender/prerender_resource_throttle.cc
[modify] https://crrev.com/4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb/chrome/browser/prerender/prerender_resource_throttle.h
[modify] https://crrev.com/4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb/chrome/browser/prerender/prerender_test_utils.cc
[modify] https://crrev.com/4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb/chrome/browser/prerender/prerender_test_utils.h
[modify] https://crrev.com/4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb/content/public/browser/content_browser_client.h
[modify] https://crrev.com/4c6cd83cb2f24e0b7e3139ef408a538750d1ebfb/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 50 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c2fc6bedd31d505dc7492baa672106f9b00912f

commit 5c2fc6bedd31d505dc7492baa672106f9b00912f
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Dec 07 22:50:26 2017

Update network service browser_tests filter with now passing tests.

TBR=yzshen@chromium.org
NOTRY=true

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I057a44cb8bab233f93f3d66d717f31b653ba09b5
Reviewed-on: https://chromium-review.googlesource.com/815381
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522587}
[modify] https://crrev.com/5c2fc6bedd31d505dc7492baa672106f9b00912f/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 51 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a796fa5605119535041802efe09b9e98099273d1

commit a796fa5605119535041802efe09b9e98099273d1
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Dec 12 17:12:32 2017

Fix session restore with network service.

This involved:
-persisting cookies with network service
-converting the browser tests to work with the network service

Bug:  789644 ,  769401 ,  776589 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I70320d5550e433049a910c64f055c1809aecbff1
Reviewed-on: https://chromium-review.googlesource.com/818486
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523462}
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/android_webview/browser/cookie_manager.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/chrome/browser/profiles/profile.h
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/chrome/browser/sessions/better_session_restore_browsertest.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/components/safe_browsing/browser/safe_browsing_url_request_context_getter.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/content/browser/net/quota_policy_cookie_store.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/content/browser/notification_service_impl.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/content/network/BUILD.gn
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/content/network/DEPS
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/content/network/network_context.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/content/public/browser/cookie_store_factory.h
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/content/public/browser/notification_service.h
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/content/public/common/network_service.mojom
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/content/public/test/url_loader_interceptor.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/content/public/test/url_loader_interceptor.h
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/content/utility/utility_main.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/headless/lib/browser/headless_url_request_context_getter.cc
[modify] https://crrev.com/a796fa5605119535041802efe09b9e98099273d1/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 52 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f682b8b1ae4237177aabfe35db99f8213ebb485f

commit f682b8b1ae4237177aabfe35db99f8213ebb485f
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Tue Dec 19 20:26:07 2017

Network service browser tests: update filter.

Disable two newly-added failing tests:
- DicePrepareMigrationChromeSynEndpointBrowserTest.EnableSyncAfterToken
- DicePrepareMigrationChromeSynEndpointBrowserTest.EnableSyncBeforeToken

BUG= 769401 
TBR=jam@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id80bad0891bd430f7a689bcb25d2b38d27d518bf
Reviewed-on: https://chromium-review.googlesource.com/834796
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525128}
[modify] https://crrev.com/f682b8b1ae4237177aabfe35db99f8213ebb485f/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 53 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2400940df4f5477c640536533fbb5f95f787ccca

commit 2400940df4f5477c640536533fbb5f95f787ccca
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Tue Dec 19 20:36:10 2017

Network service browser tests: update the filter.

This CL disables some newly-added failing tests:
-SaveCardBubbleViewsFullFormBrowserTest.Local_ClickingLearnMoreClosesBubble
-SaveCardBubbleViewsFullFormBrowserTest.Local_ClickingNoThanksClosesBubbleIfSecondaryUiMdExpOff
-SaveCardBubbleViewsFullFormBrowserTest.Local_ClickingSaveClosesBubble
-SaveCardBubbleViewsFullFormBrowserTest.Local_ShouldNotHaveNoThanksButtonIfSecondaryUiMdExpOn
-SaveCardBubbleViewsFullFormBrowserTest.Local_SubmittingFormShowsBubbleIfGetUploadDetailsRpcFails
-SaveCardBubbleViewsFullFormBrowserTest.Logic_ShouldAttemptToOfferToSaveIfEverythingFound
-SaveCardBubbleViewsFullFormBrowserTest.Logic_ShouldNotOfferToSaveIfAddressNotFound
-SaveCardBubbleViewsFullFormBrowserTest.Logic_ShouldNotOfferToSaveIfCvcNotFoundAndCvcExpOff
-SaveCardBubbleViewsFullFormBrowserTest.Logic_ShouldNotOfferToSaveIfInvalidCvcFoundAndCvcExpOff
-SaveCardBubbleViewsFullFormBrowserTest.Logic_ShouldNotOfferToSaveIfNameNotFound
-SaveCardBubbleViewsFullFormBrowserTest.Upload_ClickingNoThanksClosesBubbleIfSecondaryUiMdExpOff
-SaveCardBubbleViewsFullFormBrowserTest.Upload_ClickingSaveClosesBubble
-SaveCardBubbleViewsFullFormBrowserTest.Upload_ConfirmButtonIsDisabledIfInvalidCvcAndCvcExpOn
-SaveCardBubbleViewsFullFormBrowserTest.Upload_ConfirmButtonIsDisabledIfNoCvcAndCvcExpOn
-SaveCardBubbleViewsFullFormBrowserTest.Upload_Entering3DigitCvcAndClickingConfirmClosesBubbleIfNoCvcAndCvcExpOn
-SaveCardBubbleViewsFullFormBrowserTest.Upload_Entering4DigitCvcAndClickingConfirmClosesBubbleIfNoCvcAndCvcExpOn
-SaveCardBubbleViewsFullFormBrowserTest.Upload_ShouldNotHaveLearnMoreLinkIfNewUiExperimentOn
-SaveCardBubbleViewsFullFormBrowserTest.Upload_ShouldNotHaveNoThanksButtonIfSecondaryUiMdExpOn
-SaveCardBubbleViewsFullFormBrowserTest.Upload_SubmittingFormWithInvalidCvcShowsBubbleIfCvcExpOn
-SaveCardBubbleViewsFullFormWithShippingBrowserTest.Logic_ShouldAttemptToOfferToSaveIfStreetAddressesConflict
-SaveCardBubbleViewsFullFormWithShippingBrowserTest.Logic_ShouldNotOfferToSaveIfNamesConflict
-SaveCardBubbleViewsFullFormWithShippingBrowserTest.Logic_ShouldNotOfferToSaveIfPostalCodesConflict

BUG= 769401 
TBR=jam@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I78834a1f8f0959dae0f46e981a33b3e0396bb3e3
Reviewed-on: https://chromium-review.googlesource.com/834756
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525130}
[modify] https://crrev.com/2400940df4f5477c640536533fbb5f95f787ccca/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 54 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6

commit 3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Dec 20 15:21:36 2017

Ensure that ContentBrowserClient::GetNetLog can be called on the IO thread.

This is already the case for chrome & content_shell, but wasn't for android_webview or headless.

This is split off from https://chromium-review.googlesource.com/c/chromium/src/+/826303 which needs this behavior.

Bug:  769401 
Change-Id: I9777d85de6206ba932a83d6b48516acdf5de1671
Reviewed-on: https://chromium-review.googlesource.com/836069
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525332}
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/android_webview/browser/aw_browser_context.h
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/android_webview/browser/net/aw_url_request_context_getter.h
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/content/public/browser/content_browser_client.h
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/headless/lib/browser/headless_browser_context_impl.cc
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/headless/lib/browser/headless_browser_impl.cc
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/headless/lib/browser/headless_browser_impl.h
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/headless/lib/browser/headless_browser_main_parts.cc
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/headless/lib/browser/headless_browser_main_parts.h
[modify] https://crrev.com/3d31864dcbbd9cb6c2704ea1fe5805cbef258ce6/headless/lib/browser/headless_content_browser_client.cc

Project Member

Comment 55 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec2f082bd780b48f29e10389f8c542468a68d412

commit ec2f082bd780b48f29e10389f8c542468a68d412
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Dec 20 21:35:11 2017

Follow-up to r525102 to remove old QUIC certs in unittests.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I97d40b2383c0f29f1f79ced1cf94f136ef64cb10
Reviewed-on: https://chromium-review.googlesource.com/834748
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525466}
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/components/cronet/android/BUILD.gn
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/components/cronet/android/test/javatests/src/org/chromium/net/CronetTestRule.java
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/components/cronet/android/test/quic_test_server.cc
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/ChromiumNativeTestSupport.java
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/components/cronet/android/test/src/org/chromium/net/CronetTestUtil.java
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/components/cronet/android/test/src/org/chromium/net/QuicTestServer.java
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/components/grpc_support/test/quic_test_server.cc
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/net/BUILD.gn
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/net/data/ssl/certificates/README
[rename] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/net/data/ssl/certificates/quic-leaf-cert.key
[add] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/net/data/ssl/certificates/quic-leaf-cert.key.pkcs8.pem
[rename] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/net/data/ssl/certificates/quic-leaf-cert.key.sct
[delete] https://crrev.com/f407f479ac2b02b2a28d46ed2ed4b2590ad790e2/net/data/ssl/certificates/quic_chain.crt
[delete] https://crrev.com/f407f479ac2b02b2a28d46ed2ed4b2590ad790e2/net/data/ssl/certificates/quic_root.crt
[delete] https://crrev.com/f407f479ac2b02b2a28d46ed2ed4b2590ad790e2/net/data/ssl/certificates/quic_test.example.com.crt
[delete] https://crrev.com/f407f479ac2b02b2a28d46ed2ed4b2590ad790e2/net/data/ssl/certificates/quic_test.example.com.key
[delete] https://crrev.com/f407f479ac2b02b2a28d46ed2ed4b2590ad790e2/net/data/ssl/certificates/quic_test.example.com.key.pkcs8
[delete] https://crrev.com/f407f479ac2b02b2a28d46ed2ed4b2590ad790e2/net/data/ssl/certificates/quic_test.example.com.key.pkcs8.pem
[delete] https://crrev.com/f407f479ac2b02b2a28d46ed2ed4b2590ad790e2/net/data/ssl/certificates/quic_test_ecc.example.com.crt
[delete] https://crrev.com/f407f479ac2b02b2a28d46ed2ed4b2590ad790e2/net/data/ssl/certificates/quic_test_ecc.example.com.key
[delete] https://crrev.com/f407f479ac2b02b2a28d46ed2ed4b2590ad790e2/net/data/ssl/certificates/quic_test_ecc.example.com.sct
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/net/data/ssl/scripts/generate-quic-chain.sh
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/net/quic/chromium/crypto/proof_verifier_chromium_test.cc
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/net/quic/chromium/crypto_test_utils_chromium.cc
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/net/quic/chromium/quic_end_to_end_unittest.cc
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/net/url_request/url_request_quic_perftest.cc
[modify] https://crrev.com/ec2f082bd780b48f29e10389f8c542468a68d412/net/url_request/url_request_quic_unittest.cc

Project Member

Comment 57 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb1a53847ff40591250a072f6cc7f4c39f0379f4

commit eb1a53847ff40591250a072f6cc7f4c39f0379f4
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Jan 05 20:49:21 2018

Add a few capabilities to URLLoaderThrottles in preparation for adding a prefetch implementation.

1) Give the throttle non-const access to ResourceRequest in WillStartRequest, so that it can change
values. This will be used to change priority.
2) Pass the ResourceResponseHead in WillRedirectRequest
3) Allow a throttle to modify the priority after the request starts.
4) Give ContentRendererClient::WillSendRequest information about the type of request, which it
might need when adding a throttle.
5) Give ContentBrowserClient::CreateURLLoaderThrottles the NavigationUIData, which it might need
when adding a throttle.
6) Move setting the net::LOAD_IGNORE_LIMITS for sync XHRs to the renderer so that
URLLoaderThrottles see it.
7) Handle the case of URLLoaderThrottle::WillRedirectRequest cancelling the request which would
delete the ThrottlingURLLoader.

This is extracted from https://chromium-review.googlesource.com/c/chromium/src/+/845114/12 so that
change can be just the prefetch specific change.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I43e12e0f0a2c5e89988fe7f7db75d4627166123c
Reviewed-on: https://chromium-review.googlesource.com/852514
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527376}
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/android_webview/renderer/aw_content_renderer_client.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/android_webview/renderer/aw_content_renderer_client.h
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/chrome/renderer/chrome_content_renderer_client_browsertest.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/components/safe_browsing/browser/base_parallel_resource_throttle.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/components/safe_browsing/browser/browser_url_loader_throttle.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/components/safe_browsing/browser/browser_url_loader_throttle.h
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/components/safe_browsing/renderer/renderer_url_loader_throttle.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/components/safe_browsing/renderer/renderer_url_loader_throttle.h
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/common/loader_util.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/common/loader_util.h
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/common/throttling_url_loader.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/common/throttling_url_loader.h
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/network/url_loader.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/public/browser/content_browser_client.h
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/public/common/url_loader.mojom
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/public/common/url_loader_throttle.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/public/common/url_loader_throttle.h
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/extensions/shell/renderer/shell_content_renderer_client.cc
[modify] https://crrev.com/eb1a53847ff40591250a072f6cc7f4c39f0379f4/extensions/shell/renderer/shell_content_renderer_client.h

Project Member

Comment 58 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abc11c4016be30266a1c786f975dd1d695f36f28

commit abc11c4016be30266a1c786f975dd1d695f36f28
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Jan 05 21:55:33 2018

Fix the failing SaveCardBubbleViews tests with network service.

With out of process network service, updating host resolver rules doesn't happen until after
SetUpOnMainThread so navigations can't start in that method using resolved hostnames. The fix for
these tests is simple, since they don't need to use a different hostname and can just use the
default 127.0.0.1.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib4ef60dcd0e68784b509334cc77c48956ce43b65
Reviewed-on: https://chromium-review.googlesource.com/852643
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527399}
[modify] https://crrev.com/abc11c4016be30266a1c786f975dd1d695f36f28/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/abc11c4016be30266a1c786f975dd1d695f36f28/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/abc11c4016be30266a1c786f975dd1d695f36f28/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 59 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/023dc17fbac58909877928165a9350b7d1895fe1

commit 023dc17fbac58909877928165a9350b7d1895fe1
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Jan 08 21:30:12 2018

Port PrerenderResourceThrottle to work with Network Service.

This throttle is used for Prerendering and NoStatePrefetch. A new URLLoaderThrottle,
PrerenderURLLoaderThrottle, is created as a replacement. It's used for subresources in the renderer
 when both the network service is enabled and disabled. In the browser, PrerenderURLLoaderThrottle
is used if the network service is enabled. When network service is disabled,
PrerenderResourceThrottle is still used in the browser until URLLoader is used
( http://crbug.com/740130 ).

Two behavior change with NoStatePrefetch that were needed:
1) The subresource data is sent to the renderer. This is needed
so that the URLLoaderThrottle gets notifications. The data isn't delivered to Blink but is just
consumed, which maintains the previous intent of not storing increasing renderer memory by having
this data in Blink's caches.
2) The prefetch renderer is kept alive until all fetched subresources complete. Previously it was
kept alive only until the main resource is parsed. This is needed to ensure all the subresources
get put into the cache and the URLLoaderThrottle get their notifications for histogramming
purposes.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I3028beeb357f91ce53b9474bc47e9b98d1fa4248
Reviewed-on: https://chromium-review.googlesource.com/845114
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527760}
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/prerender/prerender_contents.h
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/prerender/prerender_histograms.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/prerender/prerender_histograms.h
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/prerender/prerender_resource_throttle.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/prerender/prerender_unittest.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/renderer_host/chrome_navigation_ui_data.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/browser/renderer_host/chrome_navigation_ui_data.h
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/common/BUILD.gn
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/common/prerender.mojom
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/common/prerender_messages.h
[add] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/common/prerender_url_loader_throttle.cc
[add] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/common/prerender_url_loader_throttle.h
[add] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/common/prerender_util.cc
[add] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/common/prerender_util.h
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/renderer/chrome_render_frame_observer.h
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/renderer/plugins/chrome_plugin_placeholder.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/renderer/plugins/chrome_plugin_placeholder.h
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/renderer/prerender/prerender_dispatcher.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/renderer/prerender/prerender_dispatcher.h
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/renderer/prerender/prerender_helper.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/chrome/renderer/prerender/prerender_helper.h
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/content/public/common/content_constants.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/content/public/common/content_constants.h
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/content/renderer/loader/request_extra_data.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/content/renderer/loader/request_extra_data.h
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/content/renderer/loader/web_url_loader_impl.h
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/023dc17fbac58909877928165a9350b7d1895fe1/tools/metrics/histograms/histograms.xml

Project Member

Comment 60 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e663c8dc3e147e8386269a448a0989faa4812f81

commit e663c8dc3e147e8386269a448a0989faa4812f81
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Mon Jan 08 21:46:22 2018

Revert "Port PrerenderResourceThrottle to work with Network Service."

This reverts commit 023dc17fbac58909877928165a9350b7d1895fe1.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 527760 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAyM2RjMTdmYmFjNTg5MDk4Nzc5MjgxNjVhOTM1MGI3ZDE4OTVmZTEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.gpu/GPU%20Mac%20Builder/110305

Original change's description:
> Port PrerenderResourceThrottle to work with Network Service.
> 
> This throttle is used for Prerendering and NoStatePrefetch. A new URLLoaderThrottle,
> PrerenderURLLoaderThrottle, is created as a replacement. It's used for subresources in the renderer
>  when both the network service is enabled and disabled. In the browser, PrerenderURLLoaderThrottle
> is used if the network service is enabled. When network service is disabled,
> PrerenderResourceThrottle is still used in the browser until URLLoader is used
> ( http://crbug.com/740130 ).
> 
> Two behavior change with NoStatePrefetch that were needed:
> 1) The subresource data is sent to the renderer. This is needed
> so that the URLLoaderThrottle gets notifications. The data isn't delivered to Blink but is just
> consumed, which maintains the previous intent of not storing increasing renderer memory by having
> this data in Blink's caches.
> 2) The prefetch renderer is kept alive until all fetched subresources complete. Previously it was
> kept alive only until the main resource is parsed. This is needed to ensure all the subresources
> get put into the cache and the URLLoaderThrottle get their notifications for histogramming
> purposes.
> 
> Bug:  769401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I3028beeb357f91ce53b9474bc47e9b98d1fa4248
> Reviewed-on: https://chromium-review.googlesource.com/845114
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Nate Chapin <japhet@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Matthew Cary <mattcary@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527760}

Change-Id: I838ebf8b506e746126e0284ef5e210aeb13ce3c1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/855064
Cr-Commit-Position: refs/heads/master@{#527764}
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/prerender/prerender_contents.h
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/prerender/prerender_histograms.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/prerender/prerender_histograms.h
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/prerender/prerender_resource_throttle.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/prerender/prerender_unittest.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/renderer_host/chrome_navigation_ui_data.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/browser/renderer_host/chrome_navigation_ui_data.h
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/common/BUILD.gn
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/common/prerender.mojom
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/common/prerender_messages.h
[delete] https://crrev.com/5ffcbbf7625bdfc6cc239f531fc3a6437fbf776a/chrome/common/prerender_url_loader_throttle.cc
[delete] https://crrev.com/5ffcbbf7625bdfc6cc239f531fc3a6437fbf776a/chrome/common/prerender_url_loader_throttle.h
[delete] https://crrev.com/5ffcbbf7625bdfc6cc239f531fc3a6437fbf776a/chrome/common/prerender_util.cc
[delete] https://crrev.com/5ffcbbf7625bdfc6cc239f531fc3a6437fbf776a/chrome/common/prerender_util.h
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/renderer/chrome_render_frame_observer.h
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/renderer/plugins/chrome_plugin_placeholder.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/renderer/plugins/chrome_plugin_placeholder.h
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/renderer/prerender/prerender_dispatcher.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/renderer/prerender/prerender_dispatcher.h
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/renderer/prerender/prerender_helper.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/chrome/renderer/prerender/prerender_helper.h
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/content/public/common/content_constants.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/content/public/common/content_constants.h
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/content/renderer/loader/request_extra_data.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/content/renderer/loader/request_extra_data.h
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/content/renderer/loader/web_url_loader_impl.h
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/e663c8dc3e147e8386269a448a0989faa4812f81/tools/metrics/histograms/histograms.xml

Project Member

Comment 61 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59da6672c532313992f814731f883f61238a10ba

commit 59da6672c532313992f814731f883f61238a10ba
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Jan 08 21:50:39 2018

Don't sniff the mime type of an explicit download when using network service.

The mime sniffing option was added in the first commit of ResourceDownload in r496847. However the
non-network service path in DownloadManagerImpl::BeginDownloadRequest doesn't add the
MimeSniffingResourceHandler. So this change makes the two code paths more consistent.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I6db5038755d6cc0ce6277d4ddf3b029f97b4a9fd
Reviewed-on: https://chromium-review.googlesource.com/853778
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527765}
[modify] https://crrev.com/59da6672c532313992f814731f883f61238a10ba/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/59da6672c532313992f814731f883f61238a10ba/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 62 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d237798e0cda528c0753036cd4be799e24ad7fd8

commit d237798e0cda528c0753036cd4be799e24ad7fd8
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Jan 09 00:11:08 2018

Port PrerenderResourceThrottle to work with Network Service.

This throttle is used for Prerendering and NoStatePrefetch. A new URLLoaderThrottle,
PrerenderURLLoaderThrottle, is created as a replacement. It's used for subresources in the renderer
 when both the network service is enabled and disabled. In the browser, PrerenderURLLoaderThrottle
is used if the network service is enabled. When network service is disabled,
PrerenderResourceThrottle is still used in the browser until URLLoader is used
( http://crbug.com/740130 ).

Two behavior change with NoStatePrefetch that were needed:
1) The subresource data is sent to the renderer. This is needed
so that the URLLoaderThrottle gets notifications. The data isn't delivered to Blink but is just
consumed, which maintains the previous intent of not storing increasing renderer memory by having
this data in Blink's caches.
2) The prefetch renderer is kept alive until all fetched subresources complete. Previously it was
kept alive only until the main resource is parsed. This is needed to ensure all the subresources
get put into the cache and the URLLoaderThrottle get their notifications for histogramming
purposes.

Bug:  769401 
Change-Id: I6fe30e6c48d4791b30530e4e45bf8061d4b04db6
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/845114
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527760}

TBR=tsepez,japhet,asvitkine,mattcary
for reland after conflict with another cl

Change-Id: I6fe30e6c48d4791b30530e4e45bf8061d4b04db6
Reviewed-on: https://chromium-review.googlesource.com/855041
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527821}
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/prerender/prerender_contents.h
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/prerender/prerender_histograms.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/prerender/prerender_histograms.h
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/prerender/prerender_resource_throttle.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/prerender/prerender_unittest.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/renderer_host/chrome_navigation_ui_data.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/browser/renderer_host/chrome_navigation_ui_data.h
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/common/BUILD.gn
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/common/prerender.mojom
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/common/prerender_messages.h
[add] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/common/prerender_url_loader_throttle.cc
[add] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/common/prerender_url_loader_throttle.h
[add] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/common/prerender_util.cc
[add] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/common/prerender_util.h
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/renderer/chrome_render_frame_observer.h
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/renderer/plugins/chrome_plugin_placeholder.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/renderer/plugins/chrome_plugin_placeholder.h
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/renderer/prerender/prerender_dispatcher.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/renderer/prerender/prerender_dispatcher.h
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/renderer/prerender/prerender_helper.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/chrome/renderer/prerender/prerender_helper.h
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/content/public/common/content_constants.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/content/public/common/content_constants.h
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/content/renderer/loader/request_extra_data.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/content/renderer/loader/request_extra_data.h
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/content/renderer/loader/web_url_loader_impl.h
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/d237798e0cda528c0753036cd4be799e24ad7fd8/tools/metrics/histograms/histograms.xml

Project Member

Comment 63 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96721289b5bdc87d6c74880d474ea8089f09b504

commit 96721289b5bdc87d6c74880d474ea8089f09b504
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Jan 09 03:27:34 2018

Support MockCertVerifier when network service is enabled

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I688d7ca2ba7868c5a87e4c6837c1fcb8914095ad
Reviewed-on: https://chromium-review.googlesource.com/853301
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Doug Turner <dougt@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527890}
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/chrome/browser/net/dns_probe_browsertest.cc
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/chrome/browser/ssl/cert_verifier_browser_test.cc
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/chrome/browser/ssl/cert_verifier_browser_test.h
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/chrome/test/base/interactive_ui_tests_main.cc
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/content/network/network_context.cc
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/content/network/network_context.h
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/content/public/common/content_switches.cc
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/content/public/common/content_switches.h
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/content/public/common/network_param.typemap
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/content/public/common/network_service.mojom
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/content/public/common/network_service_test.mojom
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/content/public/test/network_service_test_helper.cc
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/content/public/test/network_service_test_helper.h
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/content/test/BUILD.gn
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/mojo/public/cpp/bindings/sync_call_restrictions.h
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/services/network/public/cpp/network_param_ipc_traits.cc
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/96721289b5bdc87d6c74880d474ea8089f09b504/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 64 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30e7c56b8ab3d8fe7a2c4ba9bb5088e8d20b2077

commit 30e7c56b8ab3d8fe7a2c4ba9bb5088e8d20b2077
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Jan 10 20:19:55 2018

Update network service browser tests filter file.

These tests now pass:
WebViewTests/WebViewTest.DownloadPermission/0
WebViewTests/WebViewTest.DownloadPermission/1
SSLUITest.MarkBlobAsNonSecure/0
SSLUITest.MarkBlobAsNonSecure/1

The other removed lines are tests that no longer exist.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic4e0a9f27f1d7cbd1ed8cdf303cfa0ab401f97e1
Reviewed-on: https://chromium-review.googlesource.com/860750
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528408}
[modify] https://crrev.com/30e7c56b8ab3d8fe7a2c4ba9bb5088e8d20b2077/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 65 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92

commit 7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Jan 11 21:36:16 2018

Fix single-process and network-service-in-process issues with network service.

1) Run the network service on the IO thread when --single-process flag is used. This fixes asserts
that arise from some net/ classes that only expect to be called on one thread.
2) Make tests that use net::MockCertVerifier or net::NetworkChangeNotifier work without needing the
test mojo interface.
3) Don't instantiate NetworkServiceTestHelper in the browser to avoid collisions with other test
classes.
4) Assert if any network-process restart tests are run when the network service is running in
process.

In the future once all network requests are only made by the network service, we can revisit this
and enable the test interface when running in-process. Until then, it's much simpler to avoid
having multiple instances of the test and production classes in the browser during tests.

Bug:  769401 

Change-Id: I96dc3bd7f461ba0551cbeb6d55af1723590f43c3
Reviewed-on: https://chromium-review.googlesource.com/861063
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528763}
[modify] https://crrev.com/7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92/chrome/browser/net/network_connection_tracker_browsertest.cc
[modify] https://crrev.com/7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92/chrome/browser/ssl/DEPS
[modify] https://crrev.com/7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92/chrome/browser/ssl/cert_verifier_browser_test.cc
[modify] https://crrev.com/7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92/chrome/test/base/chrome_test_launcher.cc
[modify] https://crrev.com/7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92/content/public/test/browser_test_base.cc
[modify] https://crrev.com/7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92/content/public/test/browser_test_utils.h
[modify] https://crrev.com/7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92/content/shell/utility/shell_content_utility_client.cc
[modify] https://crrev.com/7c5c7e4c164bcdac7592bc72f0e4bcee9bc72c92/content/shell/utility/shell_content_utility_client.h

Project Member

Comment 66 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16f761349c375d769a7ebd0525b50403ed832acb

commit 16f761349c375d769a7ebd0525b50403ed832acb
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Jan 11 22:57:33 2018

Fix DownloadExtensionTest with network service

Also try renabling these tests on Windows since the output from previous flakes was related to
URLRequests which aren't used anymore.

Sheriffs: if these tests flake on Windows, please redisable all the tests via the ifdef that I
removed instead of reverting.

Bug:  769401 , 776973 , 306144 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ice922d72c8911e5daa6d8b038d8496e681f8e8ec
Reviewed-on: https://chromium-review.googlesource.com/859116
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Min Qin(OOO 12/7-1/10) <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528794}
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/chrome/test/ppapi/ppapi_filechooser_browsertest.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/browser/download/download_item_impl.h
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/browser/download/resource_downloader.h
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/public/browser/download_item.h
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/public/test/fake_download_item.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/public/test/fake_download_item.h
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/public/test/mock_download_item.h
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/public/test/network_service_test_helper.cc
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/public/test/test_download_http_response.h
[delete] https://crrev.com/f5e97c7c18f90cefd0948e547e2e4253e411f5b5/content/public/test/test_download_request_handler.cc
[delete] https://crrev.com/f5e97c7c18f90cefd0948e547e2e4253e411f5b5/content/public/test/test_download_request_handler.h
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/content/test/BUILD.gn
[modify] https://crrev.com/16f761349c375d769a7ebd0525b50403ed832acb/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 67 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e850e3aa1bef3f509d10ca249f800a354efebf43

commit e850e3aa1bef3f509d10ca249f800a354efebf43
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Jan 11 23:32:26 2018

Fix WebNavigationApiTest tests with network service.

1) Replace the ResourceThrottle with a NavigationThrottle.
2) Add support for the _test_resources special casing in tests (added in r436172).

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8e9da92a0a53c89fdff09e2e7f3aaf0e29b8e54f
Reviewed-on: https://chromium-review.googlesource.com/862482
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528814}
[modify] https://crrev.com/e850e3aa1bef3f509d10ca249f800a354efebf43/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/e850e3aa1bef3f509d10ca249f800a354efebf43/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/e850e3aa1bef3f509d10ca249f800a354efebf43/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/e850e3aa1bef3f509d10ca249f800a354efebf43/extensions/browser/extension_protocols.h
[modify] https://crrev.com/e850e3aa1bef3f509d10ca249f800a354efebf43/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 68 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/710d01e5e5ab4259f08ab2e199438aaf0e3807b3

commit 710d01e5e5ab4259f08ab2e199438aaf0e3807b3
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Jan 12 18:22:48 2018

Enable a number of now passing browser tests with network service.

I ran these locally 20x to make sure none were flaky.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia20b480cd6ccabcc9090378f1be41b56668562b9
Reviewed-on: https://chromium-review.googlesource.com/864785
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528994}
[modify] https://crrev.com/710d01e5e5ab4259f08ab2e199438aaf0e3807b3/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Blockedon: 803871
Project Member

Comment 70 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c451c570a19d24dc67bfc4d62d9bbcda7a6a340b

commit c451c570a19d24dc67bfc4d62d9bbcda7a6a340b
Author: Doug Turner <dougt@chromium.org>
Date: Fri Jan 19 18:24:24 2018

Simplify browser timing info tests to work with Network Service.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I6f4f5b375e06809d85a1d24c4b6d3a8a137bcc6d
Reviewed-on: https://chromium-review.googlesource.com/867414
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530567}
[modify] https://crrev.com/c451c570a19d24dc67bfc4d62d9bbcda7a6a340b/chrome/browser/net/load_timing_browsertest.cc
[modify] https://crrev.com/c451c570a19d24dc67bfc4d62d9bbcda7a6a340b/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 71 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75db4df5e60a9a4f28c22ea0c58d243ffe1fc774

commit 75db4df5e60a9a4f28c22ea0c58d243ffe1fc774
Author: Yuri Wiitala <miu@chromium.org>
Date: Mon Jan 22 02:05:43 2018

Fix crash-on-start caused by recent Network Service browser tests change.

The crash was caused by https://chromium-review.googlesource.com/853301
because it added a call into base::CommandLine::ForCurrentProcess().
This change adds the missing instantiation of base::CommandLine in the
main() function for performance_browser_tests.

TBR=jam@chromium.org

Bug:  803455 ,  769401 
Change-Id: I8450b01559359d12f5258922d4b570e2d8b43647
Reviewed-on: https://chromium-review.googlesource.com/877823
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530798}
[modify] https://crrev.com/75db4df5e60a9a4f28c22ea0c58d243ffe1fc774/chrome/test/base/browser_perf_tests_main.cc

Project Member

Comment 72 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d222acb9fc688336b57ae0a026760bd61582e5c2

commit d222acb9fc688336b57ae0a026760bd61582e5c2
Author: Colin Blundell <blundell@chromium.org>
Date: Thu Feb 01 15:58:54 2018

Remove passing browsertest from Network Service failures

DnsProbeBrowserTest.OtherErrorWithCorrectionsFailure passes after the
change made to dns_probe_browsertest.cc in
https://chromium-review.googlesource.com/c/chromium/src/+/853301,
wherein this browsertest can now handle requests to
http(s)://mock.failed.request with the Network Service enabled
(without the Network Service these requests are handled by
URLRequestFailedJob).

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I36a3180fa222a50eec7ca21ab30dbb086624aea8
Reviewed-on: https://chromium-review.googlesource.com/897666
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533683}
[modify] https://crrev.com/d222acb9fc688336b57ae0a026760bd61582e5c2/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Owner: ----
Project Member

Comment 75 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f192f9181ced5a7651e22b3bceb588be63fc8394

commit f192f9181ced5a7651e22b3bceb588be63fc8394
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Mar 02 02:16:07 2018

Enable browser_tests with the network service that now pass.

TBR=chongz@chromium.org

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ibfc3887f8ba894bf13ec6680937d90882b29d868
Reviewed-on: https://chromium-review.googlesource.com/944904
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540415}
[modify] https://crrev.com/f192f9181ced5a7651e22b3bceb588be63fc8394/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 76 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a06743beedd721ac6002fc6576107218edcc3261

commit a06743beedd721ac6002fc6576107218edcc3261
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Mar 02 20:24:29 2018

Remove network service browser_tests filter entries for now-deleted tests.

TBR=chongz@chromium.org

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I1e6fad5551a92e80ea24103325bed2eb732cac07
Reviewed-on: https://chromium-review.googlesource.com/946745
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540605}
[modify] https://crrev.com/a06743beedd721ac6002fc6576107218edcc3261/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 77 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf6c37f2a74323ce77cd1f0dc202e45e860bd078

commit cf6c37f2a74323ce77cd1f0dc202e45e860bd078
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Mar 05 21:04:59 2018

Enable browser_tests with the network service that now pass.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iff19122ad8221e8ad6d3acf206ce48ac069d025d
Reviewed-on: https://chromium-review.googlesource.com/949457
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540933}
[modify] https://crrev.com/cf6c37f2a74323ce77cd1f0dc202e45e860bd078/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 78 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8339c1bfb31cb8e0988410fb26b5e5b0ccffc365

commit 8339c1bfb31cb8e0988410fb26b5e5b0ccffc365
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Mar 05 23:33:20 2018

Redisable LoginPromptBrowserTest.BlockCrossdomainPromptForSubresources with network service.

I saw a flake on trybots.

TBR=rockot@chromium.org
NOTRY=true

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I42b7af3f1c4c0bfcaac80f12712f43aab2758f80
Reviewed-on: https://chromium-review.googlesource.com/950123
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540980}
[modify] https://crrev.com/8339c1bfb31cb8e0988410fb26b5e5b0ccffc365/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 79 by jam@chromium.org, Mar 6 2018

Summary: Run all browser tests on network service FYI bot (was: Run all of browser_tests and interactive_ui_tests on network service FYI bot)

Comment 80 by jam@chromium.org, Mar 6 2018

Blockedon: 819246

Comment 81 by jam@chromium.org, Mar 6 2018

Blockedon: 819248

Comment 82 by jam@chromium.org, Mar 6 2018

Blockedon: 819249
Project Member

Comment 83 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c972fcf62f530fdb8d234c806d1d855b4a28cd5

commit 5c972fcf62f530fdb8d234c806d1d855b4a28cd5
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Mar 07 20:22:21 2018

Convert ui_test_utils::GetCookies to work with network service.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic00aa9c4eada086ec810ae6167e614ed72e5a046
Reviewed-on: https://chromium-review.googlesource.com/953086
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541551}
[modify] https://crrev.com/5c972fcf62f530fdb8d234c806d1d855b4a28cd5/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/5c972fcf62f530fdb8d234c806d1d855b4a28cd5/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 84 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16bf7b0f8d541ae06832a782888e04786f3d5755

commit 16bf7b0f8d541ae06832a782888e04786f3d5755
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Mar 14 20:34:36 2018

Fix cookie access for extensions and apps.

The first fix is to get the CookieManager from the render process' StoragePartition, instead of
using GetDefaultStoragePartition. The second fix is to not use the StoragePartition's CookieManager
(which is used for web requests) when ContentBrowserClient::OverrideRequestContextForURL returns a
different store (e.g. for chrome-extension scheme).

Bug:  769401 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id61abda2cd38957867fb3848d06b1b18d9e89b79
Reviewed-on: https://chromium-review.googlesource.com/957554
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543186}
[modify] https://crrev.com/16bf7b0f8d541ae06832a782888e04786f3d5755/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/16bf7b0f8d541ae06832a782888e04786f3d5755/content/browser/frame_host/render_frame_message_filter.h
[modify] https://crrev.com/16bf7b0f8d541ae06832a782888e04786f3d5755/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/16bf7b0f8d541ae06832a782888e04786f3d5755/content/browser/renderer_host/render_view_host_unittest.cc
[modify] https://crrev.com/16bf7b0f8d541ae06832a782888e04786f3d5755/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 85 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2e9a9dd0da94ebfa423c9e8ecfb5bb42d8bb3b5

commit e2e9a9dd0da94ebfa423c9e8ecfb5bb42d8bb3b5
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Mar 15 18:18:51 2018

Fix resumed downloads using the wrong StoragePartition with the network service.

There are two fixes:
-ensure that intercepted navigations have the correct StoragePartition: this was currently not true
because ResourceDownloader::InterceptNavigationResponse was using empty site url. The fix is to pass
the right one in from DownloadManagerImpl::InterceptNavigationOnChecksComplete. This is similar to
the fix in r528794 but instead of for new downloads, it's for intercepted downloads.
-pass the (now correct) StoragePartition to BeginDownloadInternal, instead of it creating it from
the render frame ID, as that doesn't work with storage partitions for web views.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I65caeaefbf489ab5a2c955d8a7a8d0efb562d281
Reviewed-on: https://chromium-review.googlesource.com/957983
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543449}
[modify] https://crrev.com/e2e9a9dd0da94ebfa423c9e8ecfb5bb42d8bb3b5/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/e2e9a9dd0da94ebfa423c9e8ecfb5bb42d8bb3b5/content/browser/download/download_item_impl_delegate.cc
[modify] https://crrev.com/e2e9a9dd0da94ebfa423c9e8ecfb5bb42d8bb3b5/content/browser/download/download_item_impl_delegate.h
[modify] https://crrev.com/e2e9a9dd0da94ebfa423c9e8ecfb5bb42d8bb3b5/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/e2e9a9dd0da94ebfa423c9e8ecfb5bb42d8bb3b5/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/e2e9a9dd0da94ebfa423c9e8ecfb5bb42d8bb3b5/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/e2e9a9dd0da94ebfa423c9e8ecfb5bb42d8bb3b5/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/e2e9a9dd0da94ebfa423c9e8ecfb5bb42d8bb3b5/content/browser/download/resource_downloader.h
[modify] https://crrev.com/e2e9a9dd0da94ebfa423c9e8ecfb5bb42d8bb3b5/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 86 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f76c8484593c804889e33905bf1ba76cea5108b

commit 1f76c8484593c804889e33905bf1ba76cea5108b
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Mar 16 21:44:32 2018

Fix webview tag's using an on-disk directory with the network service enabled.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia9ad46583b00f88631eccbc65c23cf6864134f26
Reviewed-on: https://chromium-review.googlesource.com/965921
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543837}
[modify] https://crrev.com/1f76c8484593c804889e33905bf1ba76cea5108b/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/1f76c8484593c804889e33905bf1ba76cea5108b/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/1f76c8484593c804889e33905bf1ba76cea5108b/chrome/browser/net/profile_network_context_service.h
[modify] https://crrev.com/1f76c8484593c804889e33905bf1ba76cea5108b/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 87 by bugdroid1@chromium.org, Mar 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a8a322ad719a0503ba7e8452fad79b6b79cbd04

commit 7a8a322ad719a0503ba7e8452fad79b6b79cbd04
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Sat Mar 17 02:42:10 2018

Revert "Fix webview tag's using an on-disk directory with the network service enabled."

This reverts commit 1f76c8484593c804889e33905bf1ba76cea5108b.

Reason for revert: WebViewTests/WebViewTest.DownloadCookieIsolation_CrossSession/0 is flaky with network service.

Original change's description:
> Fix webview tag's using an on-disk directory with the network service enabled.
> 
> Bug:  769401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ia9ad46583b00f88631eccbc65c23cf6864134f26
> Reviewed-on: https://chromium-review.googlesource.com/965921
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543837}

TBR=creis@chromium.org,jam@chromium.org,mmenke@chromium.org

Bug:  769401 ,  822999 
Change-Id: I0feb3dcddc8c7a767b1026c9f3a206419ab89225
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/967056
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543921}
[modify] https://crrev.com/7a8a322ad719a0503ba7e8452fad79b6b79cbd04/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/7a8a322ad719a0503ba7e8452fad79b6b79cbd04/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/7a8a322ad719a0503ba7e8452fad79b6b79cbd04/chrome/browser/net/profile_network_context_service.h
[modify] https://crrev.com/7a8a322ad719a0503ba7e8452fad79b6b79cbd04/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 88 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc0b2a64386480ae1b7545b8cf49efb66ee89c93

commit cc0b2a64386480ae1b7545b8cf49efb66ee89c93
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Mar 20 19:32:50 2018

Fix webview tag's using an on-disk directory with the network service enabled.

To fix the flakiness in the tests that span restarts, explicit calls are added to ensure the cookie
store is flushed.

Bug:  769401 ,  820996 
Change-Id: I8b02a0aa3882420a6055292f75730c607ce143b0
Reviewed-on: https://chromium-review.googlesource.com/967058
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544488}
[modify] https://crrev.com/cc0b2a64386480ae1b7545b8cf49efb66ee89c93/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/cc0b2a64386480ae1b7545b8cf49efb66ee89c93/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/cc0b2a64386480ae1b7545b8cf49efb66ee89c93/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/cc0b2a64386480ae1b7545b8cf49efb66ee89c93/chrome/browser/net/profile_network_context_service.h
[modify] https://crrev.com/cc0b2a64386480ae1b7545b8cf49efb66ee89c93/chrome/browser/sessions/better_session_restore_browsertest.cc
[modify] https://crrev.com/cc0b2a64386480ae1b7545b8cf49efb66ee89c93/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/cc0b2a64386480ae1b7545b8cf49efb66ee89c93/content/public/test/browser_test_utils.h
[modify] https://crrev.com/cc0b2a64386480ae1b7545b8cf49efb66ee89c93/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 89 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e79cf0ca820c9c83af104df0555550e86ce0048

commit 9e79cf0ca820c9c83af104df0555550e86ce0048
Author: Doug Turner <dougt@chromium.org>
Date: Thu Apr 05 21:32:30 2018

Moves CT policy handling to the Profile impl.

This allows CT Policy to be enforced when the Network Service is enabled.
It is a small refactoring of the CTPolicyManager so that it no longer
knows about preferences, but instead is passed the required and exclude lists.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ibb369371d14a14d4e5fdb216da0e906494120fa2
Reviewed-on: https://chromium-review.googlesource.com/978587
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548561}
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/components/certificate_transparency/ct_policy_manager.cc
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/components/certificate_transparency/ct_policy_manager.h
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/components/certificate_transparency/ct_policy_manager_unittest.cc
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/components/certificate_transparency/pref_names.cc
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/components/certificate_transparency/pref_names.h
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/components/mirroring/service/fake_network_service.h
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/content/public/test/network_service_test_helper.cc
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/services/network/BUILD.gn
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/services/network/DEPS
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/services/network/network_context.cc
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/services/network/network_context.h
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/services/network/public/mojom/network_service_test.mojom
[modify] https://crrev.com/9e79cf0ca820c9c83af104df0555550e86ce0048/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 90 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/223596735161897be77f4f101ebce88904004aeb

commit 223596735161897be77f4f101ebce88904004aeb
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Fri Apr 06 17:50:39 2018

Ensure PolicyTest.CertificateTransparencyEnforcementDisabledForUrls actually tests

During a refactor, an accidental disabling of the CT enforcement crept
in, meaning the test no longer tested that the policy overrode any
CT requirements.

BUG= 769401 
TBR=pastarmovj@chromium.org

Change-Id: I2c060f0027ad838d4447235fe368f0fa2c1cd2ca
Reviewed-on: https://chromium-review.googlesource.com/998547
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548850}
[modify] https://crrev.com/223596735161897be77f4f101ebce88904004aeb/chrome/browser/policy/policy_browsertest.cc

Comment 91 by jam@chromium.org, Apr 13 2018

Blockedon: 832749
Project Member

Comment 92 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4386f5bb325f3e2cfcb4f1f7122a534b07055ea7

commit 4386f5bb325f3e2cfcb4f1f7122a534b07055ea7
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Apr 13 17:20:41 2018

Update network service browser_tests filter with now passing tests.

TBR=cmumford@chromium.org

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9e976ebd5d9a345f86980fe5b1e963c0c3f4b1fe
Reviewed-on: https://chromium-review.googlesource.com/1012128
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550665}
[modify] https://crrev.com/4386f5bb325f3e2cfcb4f1f7122a534b07055ea7/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 93 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66794f382fea436bdc66c49de16e7582b33bb4c9

commit 66794f382fea436bdc66c49de16e7582b33bb4c9
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Apr 13 20:36:25 2018

Annotate a few browser test failures with network service.

TBR=juncai@chromium.org

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8c3f9956b131c171fc35e5fdb78f5f9ec53e2cd1
Reviewed-on: https://chromium-review.googlesource.com/1012445
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550749}
[modify] https://crrev.com/66794f382fea436bdc66c49de16e7582b33bb4c9/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 94 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4386f5bb325f3e2cfcb4f1f7122a534b07055ea7

commit 4386f5bb325f3e2cfcb4f1f7122a534b07055ea7
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Apr 13 17:20:41 2018

Update network service browser_tests filter with now passing tests.

TBR=cmumford@chromium.org

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9e976ebd5d9a345f86980fe5b1e963c0c3f4b1fe
Reviewed-on: https://chromium-review.googlesource.com/1012128
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550665}
[modify] https://crrev.com/4386f5bb325f3e2cfcb4f1f7122a534b07055ea7/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 95 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66794f382fea436bdc66c49de16e7582b33bb4c9

commit 66794f382fea436bdc66c49de16e7582b33bb4c9
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Apr 13 20:36:25 2018

Annotate a few browser test failures with network service.

TBR=juncai@chromium.org

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8c3f9956b131c171fc35e5fdb78f5f9ec53e2cd1
Reviewed-on: https://chromium-review.googlesource.com/1012445
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550749}
[modify] https://crrev.com/66794f382fea436bdc66c49de16e7582b33bb4c9/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 96 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/926e9c1d7a3631ff5b6b3580716e37df331d7197

commit 926e9c1d7a3631ff5b6b3580716e37df331d7197
Author: Doug Turner <dougt@chromium.org>
Date: Wed Apr 25 22:03:17 2018

Enable testing of SymantecMessageSSLUITest* in Network Service.

This CL allows this test to toggle SetShouldNotRequireCTForTesting.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I31108cbbec240660c87209f65be067a0b30c9339
Reviewed-on: https://chromium-review.googlesource.com/999099
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553779}
[modify] https://crrev.com/926e9c1d7a3631ff5b6b3580716e37df331d7197/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/926e9c1d7a3631ff5b6b3580716e37df331d7197/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 97 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b040956bdc64f1eb47dfd3a8069023913efe55a

commit 4b040956bdc64f1eb47dfd3a8069023913efe55a
Author: Doug Turner <dougt@chromium.org>
Date: Mon Apr 30 23:20:08 2018

Add InterceptNetworkTransactions equivalent for Network Service.

Existing testing code needs a way to error out the transport layer so that
we can test caching behavior. This CL adds a new API to the network service
for testing that will force the transport layer to return the given error
code.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I67acfc0027bbb32ba751b61afd238e951dd39e67
Reviewed-on: https://chromium-review.googlesource.com/1034122
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554916}
[modify] https://crrev.com/4b040956bdc64f1eb47dfd3a8069023913efe55a/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/4b040956bdc64f1eb47dfd3a8069023913efe55a/services/network/network_context.cc
[modify] https://crrev.com/4b040956bdc64f1eb47dfd3a8069023913efe55a/services/network/network_context.h
[modify] https://crrev.com/4b040956bdc64f1eb47dfd3a8069023913efe55a/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/4b040956bdc64f1eb47dfd3a8069023913efe55a/services/network/test/test_network_context.h
[modify] https://crrev.com/4b040956bdc64f1eb47dfd3a8069023913efe55a/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 98 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0443d29b09d752f5bcf3543facce8858e0d7dbb1

commit 0443d29b09d752f5bcf3543facce8858e0d7dbb1
Author: Doug Turner <dougt@chromium.org>
Date: Tue May 01 03:15:39 2018

Fix ConfirmCacheInformationPlumbed to work with NetworkService

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I45c64d6c5c18b8a11a84e1527db171b42e2c3c78
Reviewed-on: https://chromium-review.googlesource.com/1034297
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554986}
[modify] https://crrev.com/0443d29b09d752f5bcf3543facce8858e0d7dbb1/content/renderer/browser_render_view_browsertest.cc
[modify] https://crrev.com/0443d29b09d752f5bcf3543facce8858e0d7dbb1/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 99 by jam@chromium.org, May 4 2018

Blockedon: 839982
Project Member

Comment 100 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/736f651f73554720c316234e9559927ee207c2e3

commit 736f651f73554720c316234e9559927ee207c2e3
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon May 07 21:27:32 2018

Remove check in MaybeCreateExtensionSubresourceURLLoaderFactory that committed frames must have a URL.

Sometimes empty URLs are committed. This fixes 2 PlatformAppBrowserTest tests with network service enabled.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I229327523ef4fe7d512def62efb021b1da5d8605
Reviewed-on: https://chromium-review.googlesource.com/1047204
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556573}
[modify] https://crrev.com/736f651f73554720c316234e9559927ee207c2e3/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/736f651f73554720c316234e9559927ee207c2e3/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 101 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ab2ed9fce253c53d1425efa7bedfa90ca739be5

commit 1ab2ed9fce253c53d1425efa7bedfa90ca739be5
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed May 09 06:08:08 2018

Disable ConditionalCacheCountingHelperBrowserTest.Count with the network service.

TBR=mmenke@chromium.org

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I40368e2ed5c01cb0234f7ba23bcf0f50ed4372da
Reviewed-on: https://chromium-review.googlesource.com/1051251
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557108}
[modify] https://crrev.com/1ab2ed9fce253c53d1425efa7bedfa90ca739be5/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 102 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84d795bcd1775f4c89690dad60ad5c9838166ccf

commit 84d795bcd1775f4c89690dad60ad5c9838166ccf
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Wed May 09 07:06:00 2018

Refactor Certificate Transparency initialization for S13N

Chrome is currently experimenting with using DNS as part of
ensuring the Certificate Transparency logs provide globally
consistent views. When using the Network Service, certificate
verification is performed in the service/context, rather than
the browser context, meaning that the consistency proof
checking also needs to be moved into the Network Service.

However, Certificate Transparency support is also being moved
up into Chrome proper, rather than as part of //net, in order
to ensure the ecosystem does not prematurely ossify.

This CL moves the DNS portion from //chrome, and in particular,
the IOThread, into the Network Service, while moving
initialization of the logs up from //net and into //chrome, by
way of explicit parameters in the NetworkContextParams. If the
set of logs are not supplied, no CT support is initialized, and
if they are supplied, then log consistency checking is enabled if
the base::Feature is enabled.

Bug:  702062 ,  769401 ,  803871 ,  835849 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8befb033255366d8431922e29e18879d3cf1b7dc
Reviewed-on: https://chromium-review.googlesource.com/1020304
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557112}
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/chrome/browser/BUILD.gn
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/chrome/browser/component_updater/sth_set_component_installer.cc
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/chrome/browser/component_updater/sth_set_component_installer.h
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/chrome/browser/component_updater/sth_set_component_installer_unittest.cc
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/chrome/browser/io_thread.cc
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/chrome/browser/io_thread.h
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/chrome/browser/io_thread_browsertest.cc
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/chrome/browser/net/default_network_context_params.cc
[delete] https://crrev.com/5bc74f5fff976f92f3b9ff3a71c9d1d8ffc58802/chrome/browser/net/sth_distributor_provider.cc
[delete] https://crrev.com/5bc74f5fff976f92f3b9ff3a71c9d1d8ffc58802/chrome/browser/net/sth_distributor_provider.h
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/chrome/browser/profiles/profile_io_data.h
[delete] https://crrev.com/5bc74f5fff976f92f3b9ff3a71c9d1d8ffc58802/chrome/browser/ssl/certificate_transparency_browsertest.cc
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/chrome/test/BUILD.gn
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/net/cert/signed_certificate_timestamp.h
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/BUILD.gn
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/network_context.cc
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/network_context.h
[add] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/network_context_cert_transparency_unittest.cc
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/network_service.cc
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/network_service.h
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/cpp/BUILD.gn
[add] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/cpp/digitally_signed.typemap
[add] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/cpp/digitally_signed_mojom_traits.cc
[add] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/cpp/digitally_signed_mojom_traits.h
[add] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/cpp/digitally_signed_mojom_traits_unittest.cc
[add] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/cpp/signed_tree_head.typemap
[add] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/cpp/signed_tree_head_mojom_traits.cc
[add] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/cpp/signed_tree_head_mojom_traits.h
[add] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/cpp/signed_tree_head_mojom_traits_unittest.cc
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/cpp/typemaps.gni
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/mojom/BUILD.gn
[add] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/mojom/ct_log_info.mojom
[add] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/mojom/digitally_signed.mojom
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/mojom/network_service.mojom
[add] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/public/mojom/signed_tree_head.mojom
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/services/network/url_request_context_builder_mojo.cc
[modify] https://crrev.com/84d795bcd1775f4c89690dad60ad5c9838166ccf/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 103 by jam@chromium.org, May 17 2018

Blockedon: 844032

Comment 104 by jam@chromium.org, May 17 2018

Blockedon: 844034
Project Member

Comment 105 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63d75345745e5a7d991ce4cd1ecd7c6f8dbd3515

commit 63d75345745e5a7d991ce4cd1ecd7c6f8dbd3515
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu May 17 16:23:13 2018

Categorize some browser_tests failures with network service.

Bug:  769401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I11f506899c0c92d5d521d598bff2b6d8c7929c3f
Reviewed-on: https://chromium-review.googlesource.com/1064315
Reviewed-by: Doug Turner <dougt@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559560}
[modify] https://crrev.com/63d75345745e5a7d991ce4cd1ecd7c6f8dbd3515/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 106 by dxie@chromium.org, May 17 2018

Labels: -Pri-2 Proj-Servicification-Canary OS-All Pri-1

Comment 107 by dxie@chromium.org, May 18 2018

Labels: -OS-All OS-Linux OS-Mac OS-Chrome OS-Android
Project Member

Comment 108 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffb4d2c901b863c2a4f077b0241830567408faa2

commit ffb4d2c901b863c2a4f077b0241830567408faa2
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Jun 22 14:56:55 2018

Fix SecurityStateTabHelperTest.DefaultSecurityLevelOn*FilesystemUrl tests with network service.

The problem was that empty filesystem objects weren't calling URLLoaderClient::OnReceiveResponse.

Bug:  769401 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I3e9266848642f9fa7d761b605370335441d94511
Reviewed-on: https://chromium-review.googlesource.com/1110275
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569627}
[modify] https://crrev.com/ffb4d2c901b863c2a4f077b0241830567408faa2/content/browser/fileapi/file_system_url_loader_factory.cc
[modify] https://crrev.com/ffb4d2c901b863c2a4f077b0241830567408faa2/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 109 by dxie@chromium.org, Jun 26 2018

Owner: jam@chromium.org
Status: Assigned (was: Started)
making Jam@ the owner for this meta bug. Others will contribute as well.
Project Member

Comment 110 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91de2a347a0372128c51c770e912097ce4c07a70

commit 91de2a347a0372128c51c770e912097ce4c07a70
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Aug 07 13:30:01 2018

NetworkService: Fix SSLUITest.TestBadHTTPSDownload/*

The test was using a notification to watch for the download that is only
sent by the RDH, which is not used when the network service was enabled.
Make the test use a download testing observer class instead.

Since the test was the only thing using the notification, also remove
the old notification from RDH.

And remove a couple obsolete entries from
testing/buildbot/filters/mojo.fyi.network_browser_tests.filter, while
I'm modifying it.

Bug:  769401 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5e0cd2ecc1c7e10933ad1903e6eaa9c6fee83c61
Reviewed-on: https://chromium-review.googlesource.com/1162646
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581211}
[modify] https://crrev.com/91de2a347a0372128c51c770e912097ce4c07a70/chrome/browser/chrome_notification_types.h
[modify] https://crrev.com/91de2a347a0372128c51c770e912097ce4c07a70/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/91de2a347a0372128c51c770e912097ce4c07a70/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/91de2a347a0372128c51c770e912097ce4c07a70/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 111 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ba139bfc881e3b1813637a5c72f41bc5d75db2b

commit 6ba139bfc881e3b1813637a5c72f41bc5d75db2b
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Aug 07 17:23:50 2018

Update filters/mojo.fyi.network_browser_tests.filter.

Remove several tests that have been renamed, and annotate two other sets
of tests with more details and new bugs.

Bug:  769401 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ic8d7b9158ebb6b3c551546c83639e3ad1431db26
Reviewed-on: https://chromium-review.googlesource.com/1164313
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581267}
[modify] https://crrev.com/6ba139bfc881e3b1813637a5c72f41bc5d75db2b/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 112 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa6d8593a3ff0cbede6f25317704576bebe84654

commit aa6d8593a3ff0cbede6f25317704576bebe84654
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Aug 08 15:57:07 2018

Enable now passing browser_tests with network service.

Bug:  769401 , 865350 , 844915 ,773295
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ie7c87877597686927a401b64120c444c79a8912c
Reviewed-on: https://chromium-review.googlesource.com/1166593
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581577}
[modify] https://crrev.com/aa6d8593a3ff0cbede6f25317704576bebe84654/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 113 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d1ff918101bdbb85a4a3976c9d9eb6e56715df9

commit 1d1ff918101bdbb85a4a3976c9d9eb6e56715df9
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Aug 10 16:18:23 2018

Fix extensions management browser tests with network service.

Bug:  769401 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ie6dff50674507ec518d5c8043cba7e3202b6f2ff
Reviewed-on: https://chromium-review.googlesource.com/1168736
Reviewed-by: Doug Turner <dougt@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582190}
[modify] https://crrev.com/1d1ff918101bdbb85a4a3976c9d9eb6e56715df9/chrome/browser/extensions/api/management/management_browsertest.cc
[modify] https://crrev.com/1d1ff918101bdbb85a4a3976c9d9eb6e56715df9/content/public/test/url_loader_interceptor.cc
[modify] https://crrev.com/1d1ff918101bdbb85a4a3976c9d9eb6e56715df9/content/public/test/url_loader_interceptor.h
[modify] https://crrev.com/1d1ff918101bdbb85a4a3976c9d9eb6e56715df9/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Labels: -Proj-Servicification-Canary Proj-Servicification
removing Proj-Servicification-Canary as everything that remains which we want for canary has a canary blocking bug
Labels: Hotlist-KnownIssue
Project Member

Comment 116 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1897a16bb790b1fd4bb30ada29f39d150f6a06b

commit f1897a16bb790b1fd4bb30ada29f39d150f6a06b
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Aug 14 21:22:40 2018

Fix broken ExtensionDisabledGlobalErrorTest.* with network service

These were using a URLRequestInterceptor, which doesn't work with the
network service. Switched to using content::URLLoaderInterceptor.

Bug:  769401 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5032eaccac335a060d0d3dedd83d8d723c471d34
Reviewed-on: https://chromium-review.googlesource.com/1173012
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583038}
[modify] https://crrev.com/f1897a16bb790b1fd4bb30ada29f39d150f6a06b/chrome/browser/extensions/extension_disabled_ui_browsertest.cc
[modify] https://crrev.com/f1897a16bb790b1fd4bb30ada29f39d150f6a06b/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 117 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea566cb937ac6f20bdd5490cb490668796d53f04

commit ea566cb937ac6f20bdd5490cb490668796d53f04
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Aug 14 21:23:06 2018

Fix WebViewTest.WebViewInBackgroundPage with network service

Moved the onComplete listener to before the webview request is made so
the listener can be set up when the auth request is made. This is
necessary because of how network service handles the webRequest API. See
http://crrev.com/c/1139048 for more info.

Bug:  769401 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I0537bfaac2c8ba60fc4afeffcd3c39802eda01c1
Reviewed-on: https://chromium-review.googlesource.com/1174706
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583039}
[modify] https://crrev.com/ea566cb937ac6f20bdd5490cb490668796d53f04/chrome/test/data/extensions/platform_apps/web_view/background/background.js
[modify] https://crrev.com/ea566cb937ac6f20bdd5490cb490668796d53f04/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Status: Fixed (was: Assigned)
Project Member

Comment 120 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d9aeb31ecd4b5745038bf5c1b6eb2827b665b21

commit 2d9aeb31ecd4b5745038bf5c1b6eb2827b665b21
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Jan 07 19:49:30 2019

Remove network service browser_tests filter file.

The one remaining entry is expected to fail, so I moved that to the test body.

Bug:  769401 
Change-Id: Ib76d42b9ffea431ccf364fb9ae014200dfa5fc9d
Reviewed-on: https://chromium-review.googlesource.com/c/1398304
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620432}
[modify] https://crrev.com/2d9aeb31ecd4b5745038bf5c1b6eb2827b665b21/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/2d9aeb31ecd4b5745038bf5c1b6eb2827b665b21/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/2d9aeb31ecd4b5745038bf5c1b6eb2827b665b21/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/2d9aeb31ecd4b5745038bf5c1b6eb2827b665b21/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/2d9aeb31ecd4b5745038bf5c1b6eb2827b665b21/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/2d9aeb31ecd4b5745038bf5c1b6eb2827b665b21/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/2d9aeb31ecd4b5745038bf5c1b6eb2827b665b21/testing/buildbot/chromium.win.json
[modify] https://crrev.com/2d9aeb31ecd4b5745038bf5c1b6eb2827b665b21/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/2c35ba440c2891cb4f1423c70323fb08b1936895/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/2d9aeb31ecd4b5745038bf5c1b6eb2827b665b21/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/2d9aeb31ecd4b5745038bf5c1b6eb2827b665b21/testing/buildbot/tryserver.chromium.linux.json

Showing comments 21 - 120 of 120 Older

Sign in to add a comment