New issue
Advanced search Search tips

Issue 769399 link

Starred by 1 user
Status: Fixed
Owner:
dhadd...@chromium.org
Closed: Oct 2017
Cc:
akes...@chromium.org
xixuan@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add new metrics for devserver provision

Project Member Reported by dhadd...@chromium.org, Sep 27 2017 
I want to add metrics for when the au_e2etest performs provision.

Adding a field to the existing metrics is dangerous if there are multiple clients. 

So I will add a new metric with the new field I want. Then when it is pushed to prod, I will remove the existing metrics.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a7dce787522674a6a36a929f924cea410f36cb29

commit a7dce787522674a6a36a929f924cea410f36cb29
Author: David Haddock <dhaddock@chromium.org>
Date: Wed Oct 18 03:49:08 2017

[autotest] Add replacement metrics for provisions.

These new metrics will replace the exisitng metrics.
The end goal is to get an additional field in the existing metrics which
we cannot do currently.

BUG= chromium:769399 
TEST=au_e2etest and autoupdate_provision pass

Change-Id: I7a395f830de58317fce0f18e960253dd1b1a511a
Reviewed-on: https://chromium-review.googlesource.com/687956
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/a7dce787522674a6a36a929f924cea410f36cb29/client/common_lib/cros/dev_server.py
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d78c249fc2d74a09751f5707ca07ef4cccf526e2

commit d78c249fc2d74a09751f5707ca07ef4cccf526e2
Author: David Haddock <dhaddock@chromium.org>
Date: Sat Oct 21 00:59:28 2017

[autotest] Replace existing devserver metrics.

In a previous CL I added additional metrics. Now I will replace the
original ones with these. This two step process was done to avoid adding
a new field to an existing metric.

BUG= chromium:769399 
TEST=autoupdate_EndToEndTest and provision_AutoUpdate pass

Change-Id: I027125ac5c5661e566a86c16aa3e7bdff288cc07
Reviewed-on: https://chromium-review.googlesource.com/727539
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/d78c249fc2d74a09751f5707ca07ef4cccf526e2/client/common_lib/cros/dev_server.py

Comment 3 by dhadd...@chromium.org, Oct 23 2017

Status: Fixed (was: Untriaged)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment