New issue
Advanced search Search tips

Issue 769396 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cros tryjob run unknown build configs on tryjobs

Project Member Reported by nxia@chromium.org, Sep 27 2017

Issue description

Now cros tryjob allows people to trigger unknown build config tryjobs and then fails it on the remote tryjob build. It should die instead of allowing the unknown tryjob taking up the buildslaves ?


nxia@nxia:~/chromiumos/chromite$ cros tryjob binhost 

Unknown build configs; are you sure you want to schedule for binhost? (yes/No)? yes

No patches were provided; are you sure you want to just run a remote build of ToT? (yes/No)? yes
Verifying patches...
Submitting tryjob...
Successfully sent PUT request to [buildbucket_bucket:master.chromiumos.tryserver] with [config:binhost] [buildbucket_id:8967273521893011120].
Tryjob submitted!
To view your tryjobs, visit:
  https://uberchromegw.corp.google.com/i/chromiumos.tryserver/waterfall?committer=nxia@chromium.org&builder=etc
 
There are cases when cros tryjob doesn't know if a build config is valid, mostly involving builds on branches. That used to cause me problems from time to time, which is why I added the ability to submit unknown configs.

It does confirm before submitting them. My thinking was that that would be enough to keep this from being a problem.

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment