New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769395 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Change Quick view strings to sentence case

Project Member Reported by mcirimele@chromium.org, Sep 27 2017

Issue description

Quick view uses title case (capitalizing the first letter of each word). We normally use sentence case within ChromeOS, and should change the strings to match this. 
 

Comment 1 by sashab@chromium.org, Feb 23 2018

Cc: weifangsun@chromium.org
Labels: CrOS-FilesApp-QuickView Hotlist-GoodFirstBug
Owner: ----
Status: Available (was: Untriaged)

Comment 2 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-QuickView CrOSFilesFeature-QuickView
Owner: lucmult@chromium.org
Status: Started (was: Available)
Attached a screenshot from a local build with changes.
Screenshot AFTER -redacted.png
73.0 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e86d99f5b5c8a1aad84385ee700ccc34e2dc129e

commit e86d99f5b5c8a1aad84385ee700ccc34e2dc129e
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Fri Mar 09 01:23:27 2018

Convert File App quick view strings to sentence case

Convert all messages with prefix IDS_FILE_BROWSER_METADATA.

Also fix 2 types: "for" and "screenshot" that I noticed.

Tested in a local chromeOS build.

Bug:  769395 
Change-Id: Ie286f00f2ec54b3227ded5fedcd944e55ade1685
Reviewed-on: https://chromium-review.googlesource.com/952108
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541979}
[modify] https://crrev.com/e86d99f5b5c8a1aad84385ee700ccc34e2dc129e/chrome/app/chromeos_strings.grdp

Status: Fixed (was: Started)

Sign in to add a comment