New issue
Advanced search Search tips

Issue 769394 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 526463



Sign in to add a comment

Add Event.Latency.ScrollUpdate.Touch.TimeToScrollUpdateSwapBegin2 for wheel scrolling.

Project Member Reported by sahel@chromium.org, Sep 27 2017

Issue description

The above metric currently is measured for touch scrolling only. Once wheel scroll latching is enabled by default, we will have non-first GSU events for wheel scrolling. It will be possible to record the metric for wheel scrolling then. The new metrics should be:
Event.Latency.ScrollUpdate.Wheel.TimeToScrollUpdateSwapBegin2
Event.ScrollUpdate.Wheel.TimeToScrollUpdateSwapBegin
 

Comment 1 by sahel@chromium.org, Sep 27 2017

Blockedon: 526463

Comment 2 by sahel@chromium.org, Oct 3 2017

Description: Show this description

Comment 3 by sahel@chromium.org, Oct 3 2017

Cc: nzolghadr@chromium.org
Owner: sahel@chromium.org

Comment 4 by sahel@chromium.org, Oct 5 2017

Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e332e456ba64bb161da4064c370ca59b7c708c70

commit e332e456ba64bb161da4064c370ca59b7c708c70
Author: Sahel Sharify <sahel@chromium.org>
Date: Wed Oct 25 20:30:43 2017

Event.Latency.ScrollUpdate.Wheel.TimeToScrollUpdateSwapBegin2 is added.

This metrics weren't measured for wheel since first GestureUpdate event
latencies are measured in Event.Latency.ScrollBegin.Wheel.* and excluded
from Event.Latency.ScrollUpdate.Wheel.*; When wheel scroll latching
is disabled all update events are first updates since every update is
wrapped between a GSB-GSE pair and that's why this metrics were not
necessary for wheel events. This cl adds the end-to-end scroll
latency for non-first GSU events with wheel source to measure the
performance impact of wheel scroll latching.

Bug:  769394 
Test: RenderWidgetHostLatencyTrackerTest.TestWheelToScrollHistograms
Change-Id: I0de5c046adb303693190890a34cc8039a7221894
Reviewed-on: https://chromium-review.googlesource.com/699210
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511570}
[modify] https://crrev.com/e332e456ba64bb161da4064c370ca59b7c708c70/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/e332e456ba64bb161da4064c370ca59b7c708c70/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/e332e456ba64bb161da4064c370ca59b7c708c70/tools/metrics/rappor/rappor.xml
[modify] https://crrev.com/e332e456ba64bb161da4064c370ca59b7c708c70/tools/metrics/ukm/ukm.xml
[modify] https://crrev.com/e332e456ba64bb161da4064c370ca59b7c708c70/ui/latency/latency_tracker.cc

Comment 6 by sahel@chromium.org, Oct 25 2017

Status: Fixed (was: Assigned)

Sign in to add a comment